[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #10 from Fedora Update System  ---
python3-nose-1.3.7-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-20 17:57:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
python3-nose-1.3.7-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-05d0cc6652

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #6 from Denis Fateyev  ---
The wording "you may assume that enough of an environment exists for RPM to
function and execute basic shell scripts" is vague. Coreutils may be needed to
execute some abstract shell scripts, or maybe not. The list of the packages
which are always present in build environment would work better.
We're at 'perl-sig' just always include coreutils into BRs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python3-nose

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #8 from Fedora Update System  ---
python3-nose-1.3.7-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-05d0cc6652

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #5 from Orion Poplawski  ---
BuildRequires

It is important that your package list all necessary build dependencies using
the BuildRequires?: tag. You may assume that enough of an environment exists
for RPM to function and execute basic shell scripts, but you should not assume
any other packages are present as RPM dependencies and anything brought into
the buildroot by the build system may change over time. 


It's pretty clear that mv/cp/etc falls under that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #3 from Orion Poplawski  ---
* Tue Feb 2 2016 Orion Poplawski  - 1.3.7-2
- Fix URL
- Fix long line in description
- Include more documentation

No need to BR coreutils, that is expected in the buildroot.

Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-nose.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-nose-1.3.7-2.el7.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Denis Fateyev  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Denis Fateyev  ---
(In reply to Orion Poplawski from comment #3)
> No need to BR coreutils, that is expected in the buildroot.
There is a tendency nowadays to add everything to BRs, since according the
recent changes the exception list is gone. Although I'm not insisting in this
case.
The package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #2 from Denis Fateyev  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 308 files have unknown license.
 Detailed output of licensecheck in
 /home/mock/sandbox/review/1294862-python3-nose/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.4/site-
 packages/nose(python3-nose), /usr/lib/python3.4/site-
 packages/nose/sphinx/__pycache__(python3-nose), /usr/lib/python3.4
 /site-packages/nose/tools(python3-nose), /usr/lib/python3.4/site-
 packages/nose/sphinx(python3-nose), /usr/lib/python3.4/site-
 packages/nose/plugins/__pycache__(python3-nose), /usr/lib/python3.4
 /site-packages/nose-1.3.7-py3.4.egg-info(python3-nose),
 /usr/lib/python3.4/site-packages/nose/__pycache__(python3-nose),
 /usr/lib/python3.4/site-packages/nose/tools/__pycache__(python3-nose),
 /usr/lib/python3.4/site-packages/nose/ext(python3-nose),
 /usr/lib/python3.4/site-packages/nose/ext/__pycache__(python3-nose),
 /usr/lib/python3.4/site-packages/nose/plugins(python3-nose)
Note: not related to epel7

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD 

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862
Bug 1294862 depends on bug 1294860, which changed state.

Bug 1294860 Summary: Review Request: python3-coverage - Code coverage testing 
module for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1294860

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Dan Kenigsberg  changed:

   What|Removed |Added

 Blocks||1301291




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1301291
[Bug 1301291] RFE: Introduce python3-nose and python3-six to RHEL-7
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862
Bug 1294862 depends on bug 1294704, which changed state.

Bug 1294704 Summary: Review Request: python3-setuptools - Easily build and 
distribute Python packages
https://bugzilla.redhat.com/show_bug.cgi?id=1294704

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Orion Poplawski  changed:

   What|Removed |Added

 Blocks||1297514




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1297514
[Bug 1297514] Review Request: python3-numpy - A fast multidimensional array
facility for Python 3
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Denis Fateyev  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||de...@fateyev.com
   Assignee|nob...@fedoraproject.org|de...@fateyev.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #1 from Orion Poplawski  ---
Copr: https://copr.fedoraproject.org/coprs/g/python/python3_epel7/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Orion Poplawski  changed:

   What|Removed |Added

 Depends On||1294704, 1294860




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1294704
[Bug 1294704] Review Request: python3-setuptools - Easily build and
distribute Python packages
https://bugzilla.redhat.com/show_bug.cgi?id=1294860
[Bug 1294860] Review Request: python3-coverage - Code coverage testing
module for Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review