[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

Tomas Tomecek  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-03-29 02:19:31



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

Mike McCune  changed:

   What|Removed |Added

 Status|MODIFIED|POST



--- Comment #17 from Mike McCune  ---
This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see mmcc...@redhat.com with any questions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

Sat6QE Jenkins  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #16 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-urwidtrees

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

Tomas Tomecek  changed:

   What|Removed |Added

 Status|NEW |POST



--- Comment #15 from Tomas Tomecek  ---
William, thanks a lot for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #14 from William Moreno  ---
Package Aproved
===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #13 from Tomas Tomecek  ---
Updated

koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=13090686

spec: https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees.spec
srpm:
https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees-1.0-1.gitfbcb183.fc22.src.rpm


Added %license to every subpackage.
Added python-urwidtrees-doc subpackage with documentation.
Synced version with upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #12 from Upstream Release Monitoring 
 ---
ttomecek's scratch build of python-urwidtrees-1.0.0-1.gitfbcb183.fc22.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=13090685

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #11 from Upstream Release Monitoring 
 ---
ttomecek's scratch build of python-urwidtrees-1.0.0-1.gitfbcb183.fc22.src.rpm
for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13090507

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #10 from William Moreno  ---
There is a text with the license upstream:
https://github.com/pazz/urwidtrees/blob/master/LICENSE.md

You can patch it and include it in the rpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #9 from Tomas Tomecek  ---
(In reply to William Moreno from comment #8)
> Need work:
> The text of the license must be included in %license.
> See:
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#License_Text

Upstream doesn't include it. Tried to ask for a release with license:

https://github.com/pazz/urwidtrees/issues/23#issuecomment-168948700

> Large documentation files must go in a -doc subpackage. There is a sphinx
> doc than you can build and include as subpackage.

good point, will do

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #8 from William Moreno  ---
The package named according to the Package Naming Guidelines OK
The spec file name must match the base package %{name} OK 
The package must be licensed with a Fedora approved license OK
The License field match the actual license OK
The spec file must be written in American English OK
The spec file for the package MUST be legible OK
The package build in rawhide OK
BuildRequires OK
No bundled libraries OK
Directories ownership OK
Permissions on files OK
Consistently use macros OK
Source is code nor binary OK

Need work:
The text of the license must be included in %license.
See:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

Large documentation files must go in a -doc subpackage. There is a sphinx doc
than you can build and include as subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #5 from Upstream Release Monitoring 
 ---
ttomecek's scratch build of python-urwidtrees-1.0.1-1.fc22.src.rpm for rawhide
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12647826

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #4 from Upstream Release Monitoring 
 ---
ttomecek's scratch build of python-urwidtrees-1.0.1-1.fc22.src.rpm for rawhide
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12647780

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #6 from Upstream Release Monitoring 
 ---
ttomecek's scratch build of python-urwidtrees-1.0.1-1.fc22.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12647868

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #7 from Tomas Tomecek  ---
Oh, it was working for me locally but I haven't tried koji, my bad, sorry about
that.

Here's a successful koji build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=12647868


I have also updated spec and srpm at fp:

https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees.spec
https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees-1.0.1-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

Tomas Tomecek  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #1 from Tomas Tomecek  ---
Any update?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456



--- Comment #2 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-urwidtrees-1.0.1.1-1.fc24.src.rpm for
rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12597310

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295456] Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295456

Tomas Tomecek  changed:

   What|Removed |Added

 Blocks||1293503




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1293503
[Bug 1293503] alot-0.3.7 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review