[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-03-09 09:28:21 |2016-04-06 13:21:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #19 from Fedora Update System  ---
pdc-client-0.9.0-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #18 from Fedora Update System  ---
pdc-client-0.9.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-360eaf7066

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #17 from Fedora Update System  ---
pdc-client-0.9.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-360eaf7066

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #16 from Fedora Update System  ---
pdc-client-0.2.0.2-4.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-03-09 09:28:21



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #15 from Fedora Update System  ---
pdc-client-0.2.0.2-4.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6b092329a1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
pdc-client-0.2.0.2-4.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-748c15ba3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #13 from Fedora Update System  ---
pdc-client-0.2.0.2-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-748c15ba3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #11 from Fedora Update System  ---
pdc-client-0.2.0.2-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-748c15ba3c

--- Comment #12 from Fedora Update System  ---
pdc-client-0.2.0.2-4.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6b092329a1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #13 from Fedora Update System  ---
pdc-client-0.2.0.2-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-748c15ba3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #11 from Fedora Update System  ---
pdc-client-0.2.0.2-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-748c15ba3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Ralph Bean  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rb...@redhat.com
  Flags||fedora-review+



--- Comment #9 from Ralph Bean  ---
Looks good to me.  Nice, simple python package.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 35 files have
 unknown license. Detailed output of licensecheck in
 /home/threebean/1297411-pdc-client/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /etc/bash_completion.d(lldpad, hub, fcoe-utils, filesystem, yum-utils,
 lxc, bash-completion, fedpkg, udisks, devassistant-cli)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = 

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/pdc-client

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411
Bug 1297411 depends on bug 1296974, which changed state.

Bug 1296974 Summary: Review Request: python-beanbag - A helper module for 
accessing REST APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1296974

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #8 from Stanislav Ochotnicky  ---
Good point, forgot to change the URL after the new PDC came up.

New spec/srpm (just applied your patch):
Spec URL: http://sochotni.fedorapeople.org/packages/pdc-client.spec
SRPM URL:
http://sochotni.fedorapeople.org/packages/pdc-client-0.2.0.2-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #7 from Upstream Release Monitoring 
 ---
ralph's scratch build of pdc-client-0.2.0.2-2.fc23.src.rpm for epel7-candidate
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12902422

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #6 from Upstream Release Monitoring 
 ---
ralph's scratch build of pdc-client-0.2.0.2-2.fc23.src.rpm for epel7-candidate
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12902357

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Ralph Bean  changed:

   What|Removed |Added

 CC||rb...@redhat.com



--- Comment #5 from Ralph Bean  ---
Created attachment 1122176
  --> https://bugzilla.redhat.com/attachment.cgi?id=1122176=edit
A patch to make the default configuration point to fedora's prod instance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #4 from Upstream Release Monitoring 
 ---
sochotni's scratch build of pdc-client-0.2.0.2-1.fc22.src.rpm for f24 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12709079

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #3 from Upstream Release Monitoring 
 ---
sochotni's scratch build of pdc-client-0.2.0.2-1.fc22.src.rpm for
epel7-candidate failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12709037

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411



--- Comment #2 from Stanislav Ochotnicky  ---
Updated for latest release. Upstream now has setup.py and should be making
releases normally (hopefully :-))

Spec URL: http://sochotni.fedorapeople.org/packages/pdc-client.spec
SRPM URL:
http://sochotni.fedorapeople.org/packages/pdc-client-0.2.0.2-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Stanislav Ochotnicky  changed:

   What|Removed |Added

 Depends On||1296974



--- Comment #1 from Stanislav Ochotnicky  ---
I'll note this is not final version and will likely need tweaks as upstream
fixes up their pypi releases. But should be close enough for initial review. 

I have included py3 parts even if they are not used right now.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1296974
[Bug 1296974] Review Request: python-beanbag - A helper module for
accessing REST APIs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review