[Bug 1298180] Review Request: python-libcnml - a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #18 from Fedora Update System  ---
python-libcnml-0.9.4-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml - a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-22 20:25:11



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml - a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #16 from Fedora Update System  ---
python-libcnml-0.9.4-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-107691ff35

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml - a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #17 from Fedora Update System  ---
python-libcnml-0.9.4-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-107691ff35

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml - a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml - a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #15 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-libcnml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Fabio Alessandro Locati  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Fabio Alessandro Locati  ---
Very good, the package is APPROVED. Remember to re-enable the checks as soon as
the network connection problem is fixed upstream.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 6 files have
 unknown license. Detailed output of licensecheck in
 /home/fale/Downloads/python-libcnml/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-libcnml , python3-libcnml
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for 

[Bug 1298180] Review Request: python-libcnml - a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Germano Massullo  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-libcnml, a CNML  |python-libcnml - a CNML
   |parser library for Python   |parser library for Python



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #12 from Germano Massullo  ---
Spec URL:
https://germano.fedorapeople.org/package_reviews/python-libcnml/review_request/python-libcnml.spec

SRPM URL (GPG signed):
https://fedorapeople.org/~germano/package_reviews/python-libcnml/review_request/python-libcnml-0.9.4-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #13 from Germano Massullo  ---
Koji build works http://koji.fedoraproject.org/koji/taskinfo?taskID=12759124

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Germano Massullo  changed:

   What|Removed |Added

 Blocks|1301260 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1301260
[Bug 1301260] Review Request: python-responses - An utility library for
mocking out the requests Python library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #11 from Germano Massullo  ---
libcnml does not block responses and viceversa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #9 from Germano Massullo  ---
added BuildRequire python-six but the tests still fail


[...]

==
ERROR: test_findNodefromIPv4 (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
--
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py",
line 156, in setUp
self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in
__init__
self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in
load
self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
==
ERROR: test_getDevices (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
--
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py",
line 156, in setUp
self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in
__init__
self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in
load
self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
==
ERROR: test_getInterfaces (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
--
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py",
line 156, in setUp
self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in
__init__
self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in
load
self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name 

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #10 from Germano Massullo  ---
https://github.com/PabloCastellano/libcnml/issues/18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Fabio Alessandro Locati  changed:

   What|Removed |Added

 Blocks||1301260




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1301260
[Bug 1301260] Review Request: python-responses - An utility library for
mocking out the requests Python library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #5 from Germano Massullo  ---
(In reply to Fabio Alessandro Locati from comment #4)
> 1. This is not solved by upstream commit, since the version you are
> packaging does not include that commit
> 
> 2. Please, do fix your changelog. If the package version and release are
> 0.9.3-1, you can not have a changelog entry for 2.2.1-1
> 
> 3. The current spec does not compile (see
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12670254). It requires
> python2-six and python3-six as BuildRequire since you are running the tests.
> 
> 4. Even adding python2-six and python3-six as for 3., some checks for
> python3 fails, at least on my machine.

 STATUS AND COMMENTS 
1. TODO
2. DONE
3 & 4. NEEDINFO Could you please test it against F23? I successfully created
the package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #7 from Germano Massullo  ---
 STATUS AND COMMENTS 
4. FAILED, koji build fails. I am going to check

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Germano Massullo  changed:

   What|Removed |Added

 Blocks||1301268




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1301268
[Bug 1301268] Review Request: python-netdiff - Python library for parsing
network topology data (eg: dynamic routing protocols, NetJSON, CNML) and
detect changes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #4 from Fabio Alessandro Locati  ---
1. This is not solved by upstream commit, since the version you are packaging
does not include that commit

2. Please, do fix your changelog. If the package version and release are
0.9.3-1, you can not have a changelog entry for 2.2.1-1

3. The current spec does not compile (see
http://koji.fedoraproject.org/koji/taskinfo?taskID=12670254). It requires
python2-six and python3-six as BuildRequire since you are running the tests.

4. Even adding python2-six and python3-six as for 3., some checks for python3
fails, at least on my machine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #3 from Germano Massullo  ---
Added macros to allow EPEL7 support

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #2 from Germano Massullo  ---
(In reply to Fabio Alessandro Locati from comment #1)
> Few preliminary comments:
> 
> 1. libcnml/libcnml.py should be executable or without shabang (probably the
> former)
> 
> 2. The chengelog is needed

1. just fixed upstream [1]
2. I am going to add it now.

If there is nothing else, I proceed with the creation of a new SRPM file

[1]: https://github.com/PabloCastellano/libcnml/issues/17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180

Fabio Alessandro Locati  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|fa...@locati.cc
  Flags||fedora-review?



--- Comment #1 from Fabio Alessandro Locati  ---
Few preliminary comments:

1. libcnml/libcnml.py should be executable or without shabang (probably the
former)

2. The chengelog is needed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review