[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #21 from Fedora Update System  ---
python-epub-0.5.2-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #20 from Fedora Update System  ---
python-epub-0.5.2-3.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #19 from Fedora Update System  ---
python-epub-0.5.2-3.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-03-03 21:18:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
python-epub-0.5.2-4.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-11455d1187

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #17 from Fedora Update System  ---
python-epub-0.5.2-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-11455d1187

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #16 from Fedora Update System  ---
python-epub-0.5.2-3.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2d67009c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
python-epub-0.5.2-3.fc22 has been pushed to the Fedora 22 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-204860a60c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Filip Szymański  changed:

   What|Removed |Added

   See Also|https://bugzilla.redhat.com |
   |/show_bug.cgi?id=1281313|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #14 from Fedora Update System  ---
python-epub-0.5.2-3.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-204860a60c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #13 from Fedora Update System  ---
python-epub-0.5.2-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2d67009c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-epub

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #11 from Filip Szymański  ---
(In reply to Antonio Trande from comment #10)
> Package approved.
> 
> Note.
> Consider providing  this package for EPEL if possible.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Antonio Trande  ---
Package approved.

Note.
Consider providing  this package for EPEL if possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #9 from Upstream Release Monitoring 
 ---
fszymanski's scratch build of python-epub-0.5.2-3.fc23.src.rpm for f23
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13110139

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #8 from Filip Szymański  ---
(In reply to Antonio Trande from comment #6)
> About tests?

I'm sorry it was very late and I missed it.
The tarball from PyPI is missing some test files (e.g. test.epub) so I changed
the Source0 URL to Bitbucket. I added a unittest patch to setup.py and I moved
the html files to a doc subpackage.

Spec URL: https://fszymanski.fedorapeople.org/python-epub/python-epub.spec
SRPM URL:
https://fszymanski.fedorapeople.org/python-epub/python-epub-0.5.2-3.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #7 from Upstream Release Monitoring 
 ---
fszymanski's scratch build of python-epub-0.5.2-3.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13109799

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #6 from Antonio Trande  ---
About tests?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #5 from Filip Szymański  ---
Spec URL: https://fszymanski.fedorapeople.org/python-epub/python-epub.spec
SRPM URL:
https://fszymanski.fedorapeople.org/python-epub/python-epub-0.5.2-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #4 from Upstream Release Monitoring 
 ---
fszymanski's scratch build of python-epub-0.5.2-2.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13099451

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #3 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= Issues =

- Source code contains HTML documentation and man page; however, it's
  available in French only.

- Please, do package Python2 files in a python2-epub:

%files -n python2-%{srcname}

instead of

%files

  This package does not provide a python2 sub-package:

Provides

python3-epub:
python3-epub

python-epub:
python-epub

- Perform all tests if possible.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 14 files have unknown license. Detailed
 output of licensecheck in /home/sagitter/FedoraReview/1299146-python-
 epub/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.5/site-packages,
 /usr/lib/python3.5
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.5/site-
 packages, /usr/lib/python3.5
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python3-epub
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not 

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Filip Szymański  changed:

   What|Removed |Added

   See Also|https://bugzilla.redhat.com |
   |/show_bug.cgi?id=1301129|
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #2 from Filip Szymański  ---
My Fedora 'packager' membership has been sponsored.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Filip Szymański  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1281313



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Filip Szymański  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1301129



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146



--- Comment #1 from Upstream Release Monitoring 
 ---
fszymanski's scratch build of python-epub-0.5.2-1.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12577081

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299146] Review Request: python-epub - Python library for reading EPUB files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299146

Filip Szymański  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review