[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- Issues can be closed automatically only be updates. So bug numbers don't work for rawhide because there are no updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #9 from Paul Belanger --- Ah, thanks. I seem to always miss that. Aside from manually close the issue, do bug numbers in commit message not work for rawhide? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 Paul Belanger changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NOTABUG Last Closed||2016-02-04 10:23:08 --- Comment #8 from Paul Belanger --- Thanks, I've added the code to pkgdb and push into rawhide. Thanks again for all the help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl Resolution|NOTABUG |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #7 from Paul Belanger --- Great, thanks everybody for the help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-grafyaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 Haïkel Guémar changed: What|Removed |Added Status|ASSIGNED|MODIFIED Flags|fedora-review? |fedora-review+ --- Comment #5 from Haïkel Guémar --- Small fix required before import, doc subpackage can be installed without its license file. Please add it. I hereby approve this package into Fedora Packages Collection, please submit a SCM request in PkgDB. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 6 files have unknown license. Detailed output of licensecheck in /home/haikel/1299580-python-grafyaml/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.5/site-packages, /usr/lib/python3.5 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.5/site- packages, /usr/lib/python3.5 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{vers
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #4 from Paul Belanger --- *** Bug 1299594 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #3 from Paul Belanger --- Oh, how odd. I guess scratch builds did work. It gave me an error first time around. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #2 from Upstream Release Monitoring --- pabelanger's scratch build of python-grafyaml-0.0.5-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12593864 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1299580 --- Comment #1 from Paul Belanger --- So, I posted this using fedora-create-review but sadly, I could not get koji scratch build to work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review