[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 Damian Wrobel changed: What|Removed |Added Status|NEW |CLOSED CC||dwro...@ertelnet.rybnik.pl Resolution|--- |DUPLICATE Last Closed||2018-02-12 11:55:58 --- Comment #16 from Damian Wrobel --- *** This bug has been marked as a duplicate of bug 1540833 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 --- Comment #15 from Damian Wrobel --- *** Bug 1540833 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 David Benoit changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 David Benoit changed: What|Removed |Added Depends On|201449 (FE-DEADREVIEW) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 David Benoit changed: What|Removed |Added Depends On||201449 (FE-DEADREVIEW) Flags|needinfo? | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 David Benoit changed: What|Removed |Added CC||dben...@redhat.com Flags||needinfo? --- Comment #14 from David Benoit --- Has there been any progress on this? I'd love to see Racket in the Fedora repositories. Is there anything I can do do help move this along? I've never submitted a package for review before. If I start a new rpm build with updated sources, should I open a new Bugzilla report, or post here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 Saša Janiška changed: What|Removed |Added CC||g...@atmarama.com --- Comment #13 from Saša Janiška --- Racket language does deserve, imho, to be present in the distribution like Fedora, so please help to make it happen! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 --- Comment #12 from Jens Petersen --- However it might be better to first get the current package into Fedora. :) While it is good you have plenty of comments, it makes the rpm fields/headers at the top of the spec file a bit hard to read. It would be good to do another koji scratch build since aarch64 and ppc64le have been added as new archs to F26 Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 --- Comment #11 from Jens Petersen --- I am completely new to racket, but overall your approach sounds reasonable. It would probably be ideal if interdependencies (Requires) could be autogenerated. I would suggest experiementing with the packaging first in Copr. For others: most current copr currently seems to be: https://copr.fedorainfracloud.org/coprs/jsouthworth/racket/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 --- Comment #10 from Brandon Thomas --- I based the above spec off of a previous attempt, and it has the same breakdown as before (racket and racket-devel), but I think I can break the package down a bit better. Because this is often used as an introductory language in higher education, I want to try to make this as non-confusing as possible to new programmers. So I propose the following breakdown: racket-core: Core Racket components racket-gtk: Graphical Racket components (requires: racket-core) racket-doc: Racket documentation racket-devel: Libraries to link with Racket racket-ide: The DrRacket IDE for Racket (requires: racket-gtk) racket: The complete Racket distribution (requires: racket-ide, racket-doc) It is backwards compatible with previous attempts at adding Racket to Fedora (including the spec files above). I decided against calling "racket-ide" as "drracket", because lots of people think that DrRacket is the name of the entire distribution, and they might install that thinking they're installing everything, only to get mad when the documentation feature of drracket doesn't work (and as a new programmer who isn't familiar with Linux, it can be frustrating). AFAIK, there isn't a list of packages that require graphical libraries, but here's what I can see off of the bat (usr/share/racket/pkgs): draw, draw-lib, future-visualizer, future-visualizer-typed, games, gui, gui-lib, gui-pkg-manager-lib, images-gui-lib (I want to keep some images functionality for servers running racket, if it doesn't break anything), pict (unfortunately I don't think I can break off just the gui component), pict-doc, pict-lib, pict-snip, picturing-programs, plot-gui-lib (again, I want to keep some plot functionality if possible), rackunit-gui, redex-gui-lib, slideshow, slideshow-exe, slideshow-lib, slideshow-plugin. And for DrRacket: drracket, drracket-plugin-lib, drracket-tool. What to people think? Should I keep it the same as before, or should I try to break it down like this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 --- Comment #9 from Brandon Thomas --- Thanks. I updated the package: Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/racket/racket.git/plain/racket.spec?id=3fb66397e0661e8c3447306d65bc185597480d65 Patch URL: http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/racket/racket.git/tree/xform-errors-converting-fix.patch?id=3fb66397e0661e8c3447306d65bc185597480d65 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bthomas/racket/fedora-23-x86_64/00155492-racket/racket-6.3-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 Neal Gompa changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #8 from Neal Gompa --- Also, adding FE-NEEDSPONSOR, since this is your first package review. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219
--- Comment #7 from Neal Gompa ---
You don't need "rm -rf ${RPM_BUILD_ROOT}" in the install step. rpmbuild
automatically cleans the build root before starting %install.
Other than that, I don't see anything standing out to me.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 --- Comment #6 from Brandon Thomas --- All right, I made the changes suggested by Neal. I also managed to find some more information about the build error; it seems to be related to a past bug. I patched it so it compiled on rawhide, and opened a bug report upstream. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/racket/racket.git/plain/racket.spec?id=e2ca824cadf6247cd0d74692b1619b005711ced7 Patch URL: http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/racket/racket.git/plain/xform-errors-converting-fix.patch?id=e2ca824cadf6247cd0d74692b1619b005711ced7 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bthomas/racket/fedora-23-x86_64/00155390-racket/racket-6.3-1.fc23.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12664534 Copr Builds: https://copr.fedorainfracloud.org/coprs/bthomas/racket/build/155390/ Upstream Bug: https://github.com/racket/racket/issues/1222 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 --- Comment #5 from Upstream Release Monitoring --- bthomas's scratch build of racket-6.3-1.fc23.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12664534 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219
--- Comment #4 from Neal Gompa ---
Now that I can see your spec, I see a few things you can correct pretty
quickly.
* You do not need to do the export CFLAGS bit, as %configure handles that.
* %configure instead of %{configure}. I'm a bit hazy on this, but I think using
%{configure} can mess up some circumstances (but I'm not sure). In any case, it
makes stylistic sense to use %configure there anyway.
* %make_build instead of make %{?_smp_mflags}. Unless you are targeting EPEL
with this, you should use this instead, as it's cleaner and more obvious what
it is. (Actually, I believe %make_build now works in EL7 at least, so you could
probably get away with using it even there).
* %make_install instead of "make install %{?_smp_mflags}
DESTDIR=${RPM_BUILD_ROOT}". Unless there's a very good reason to, you should
use %make_install.
* Unless you are targeting EL5, you do not need a %clean section.
* Instead of using ExclusiveArch, use "ExcludeArch: %{arm}", as you indicate
that only ARM is failing right now. Generally, you should only exclude
architectures that don't work, rather than making it only build on a subset of
architectures.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 Brandon Thomas changed: What|Removed |Added Flags|needinfo?(bthomaszx@gmail.c | |om) | --- Comment #3 from Brandon Thomas --- Oh, sorry! Fedora Account System Username: bthomas Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/racket/racket.git/plain/racket.spec?id=6d83ebe32b8a565d813ce0a0ff3e20125316b4a0 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bthomas/racket/fedora-23-x86_64/00155292-racket/racket-6.3-1.fc23.src.rpm I ran the build on Copr, and it fails for rawhide, but works for Fedora 21, 22 and 23. I haven't found any related bugs upstream. I'm going to try to drill down on this some more to create a patch and isolate what changed in rawhide. Build Log (rawhide): https://copr-be.cloud.fedoraproject.org/results/bthomas/racket/fedora-rawhide-x86_64/00155292-racket/build.log.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||d...@bureau-13.org --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- *** Bug 808350 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 Neal Gompa changed: What|Removed |Added CC||bthoma...@gmail.com, ||ngomp...@gmail.com Flags||needinfo?(bthomaszx@gmail.c ||om) --- Comment #1 from Neal Gompa --- Could you please put it somewhere that is easily accessible? For example, you could use Copr to upload the SRPM and have it build there, and then go ahead and link us to the Spec in dist-git and the SRPM in the repo directory. Also, your FAS user is not your email address. Please provide the correct FAS username. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
