[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

Marcus Karlsson  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-22 16:42:57



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #14 from Fedora Update System  ---
openshift-restclient-java-3.0.1-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-729f5f7830

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #13 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/openshift-restclient-java

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #12 from Marcus Karlsson  ---
Thanks, I missed the one in the javadoc package. I'll remove it too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from gil cattaneo  ---
NON blocking issues:
Should be remove Group fileds, no longer needed.

%package javadoc
-Group:  Documentation
Summary:Javadoc for %{name}

Thanks for your work.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #10 from Marcus Karlsson  ---
Thanks for the review, and sorry for the delay on my end. I have updated the
spec file as follows:

I have received a license clarification from upstream developer André
Dietisheim who confirmed that the license of DeploymentConfig.java as included
in the tarball is EPL. I have included the email that I received complete with
all headers as a source file and marked as %license in the package. The license
header had already been added to the file in the upstream repository.

It turns out the comment in the spec regarding the tests were not entirely
correct. They fail to run but it's not because of JUnit, it's because of a
missing dependency on an assert from fest-assert which has not been packaged. I
have included a patch which rewrites the test cases that uses the assertion so
that they instead use equivalent JUnit assertions. I have also added a second
patch that fixes three failing test cases, which to my understanding is because
of an inconsistency between the test cases and the sample data which they
operate on. The failing tests had also already been fixed in the upstream
repository.

Also, the group field has been removed.

Updated SPEC URL:
https://www.acc.umu.se/~mk/fedora/openshift-restclient-java/openshift-restclient-java.spec
Updated SRPM URL:
https://www.acc.umu.se/~mk/fedora/openshift-restclient-java/openshift-restclient-java-3.0.1-1.fc25.src.rpm
Updated Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=13206620

Here is a diff of the spec file from the last version:

--- openshift-restclient-java.spec.orig2016-03-02 23:39:44.225597729 +0100
+++ openshift-restclient-java.spec2016-03-02 23:55:08.077415306 +0100
@@ -5,26 +5,35 @@
 Release:1%{?dist}
 Summary:OpenShift Java REST Client

-Group:  Development/Libraries
 License:EPL
 URL:https://github.com/openshift/openshift-restclient-java
 Source0:   
https://github.com/openshift/%{name}/archive/%{name}-%{version}.%{rls_tag}.tar.gz
+
+# Clarification of license of
src/main/java/com/openshift/internal/restclient/model/DeploymentConfig.java
+Source1:license-clarification.txt
+
 BuildArch:  noarch

-BuildRequires: maven-local
-BuildRequires: mvn(com.jcraft:jsch)
-BuildRequires: mvn(commons-codec:commons-codec)
-BuildRequires: mvn(commons-io:commons-io)
-BuildRequires: mvn(commons-lang:commons-lang)
-BuildRequires: mvn(junit:junit)
-BuildRequires: mvn(log4j:log4j)
-BuildRequires: mvn(org.apache.commons:commons-compress)
-BuildRequires: mvn(org.apache.httpcomponents:httpclient)
-BuildRequires: mvn(org.apache.httpcomponents:httpcore)
-BuildRequires: mvn(org.jboss:jboss-dmr)
-BuildRequires: mvn(org.mockito:mockito-core)
-BuildRequires: mvn(org.slf4j:slf4j-api)
-BuildRequires: mvn(org.slf4j:slf4j-log4j12)
+# Remove dependency on fest-assert since it's not packaged.
+Patch0: %{name}-test-fest-assert.patch
+
+# Fix failing tests in ImageStreamingTest. They are already fixed in upstream
git.
+Patch1: %{name}-test-imagestreamtest.patch
+
+BuildRequires:  maven-local
+BuildRequires:  mvn(com.jcraft:jsch)
+BuildRequires:  mvn(commons-codec:commons-codec)
+BuildRequires:  mvn(commons-io:commons-io)
+BuildRequires:  mvn(commons-lang:commons-lang)
+BuildRequires:  mvn(junit:junit)
+BuildRequires:  mvn(log4j:log4j)
+BuildRequires:  mvn(org.apache.commons:commons-compress)
+BuildRequires:  mvn(org.apache.httpcomponents:httpclient)
+BuildRequires:  mvn(org.apache.httpcomponents:httpcore)
+BuildRequires:  mvn(org.jboss:jboss-dmr)
+BuildRequires:  mvn(org.mockito:mockito-core)
+BuildRequires:  mvn(org.slf4j:slf4j-api)
+BuildRequires:  mvn(org.slf4j:slf4j-log4j12)

 %description
 This is the Java REST client for the version 3 architecture of OpenShift based
@@ -41,25 +50,27 @@

 %prep
 %setup -qn %{name}-%{name}-%{version}.%{rls_tag}
+cp %{SOURCE1} .
 chmod -x license README.md

+%patch0 -p1
+%patch1 -p1
+
 %pom_remove_dep org.easytesting:fest-assert

 %build
-# Tests skipped because of wrong junit version
-# (Fedora is 4.10, this expects 4.8)
-%mvn_build --skip-tests
+%mvn_build

 %install
 %mvn_install

 %files -f .mfiles
 %dir %{_javadir}/%{name}
-%license epl-v10.html license
+%license epl-v10.html license license-clarification.txt
 %doc README.md DESIGN.md

 %files javadoc -f .mfiles-javadoc
-%license epl-v10.html license
+%license epl-v10.html license license-clarification.txt

 %changelog
 * Sun Jan 10 2016 Marcus Karlsson  - 3.0.1-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #9 from Upstream Release Monitoring 
 ---
marcusk's scratch build of openshift-restclient-java-3.0.1-1.fc25.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13205948

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #6 from gil cattaneo  ---
can you take this for me https://bugzilla.redhat.com/show_bug.cgi?id=1264337 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #8 from gil cattaneo  ---
NON blocking issues:
Should be remove Group fileds, are unneccessary.
Blocking issues:
Missing license headers in 
openshift-restclient-java-openshift-restclient-java-3.0.1.Final/src/main/java/com/openshift/internal/restclient/model/DeploymentConfig.java
Would you please contact upstream to fix it?
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

Why you can't run test suite? Is strictly related at Junit version?
Can you try to explain more in detail in the spec file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #5 from Marcus Karlsson  ---
Thanks. I agree with all your suggestions and I've updated the spec to address
them.

Updated spec URL:
https://www.acc.umu.se/~mk/fedora/openshift-restclient-java/openshift-restclient-java.spec
Updated SRPM URL:
https://www.acc.umu.se/~mk/fedora/openshift-restclient-java/openshift-restclient-java-3.0.1-1.fc24.src.rpm
Updated Koji build URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=12763777

Here is a diff of the spec file from the original version:

--- SPECS/openshift-restclient-java.spec.old2016-01-31 19:25:16.342412006
+0100
+++ SPECS/openshift-restclient-java.spec2016-01-31 19:32:33.512994198 +0100
@@ -12,16 +12,19 @@
 BuildArch:  noarch

 BuildRequires: maven-local
-BuildRequires: jsch
+BuildRequires: mvn(com.jcraft:jsch)
+BuildRequires: mvn(commons-codec:commons-codec)
+BuildRequires: mvn(commons-io:commons-io)
+BuildRequires: mvn(commons-lang:commons-lang)
+BuildRequires: mvn(junit:junit)
+BuildRequires: mvn(log4j:log4j)
+BuildRequires: mvn(org.apache.commons:commons-compress)
+BuildRequires: mvn(org.apache.httpcomponents:httpclient)
+BuildRequires: mvn(org.apache.httpcomponents:httpcore)
 BuildRequires: mvn(org.jboss:jboss-dmr)
 BuildRequires: mvn(org.mockito:mockito-core)
-BuildRequires: mvn(junit:junit)
+BuildRequires: mvn(org.slf4j:slf4j-api)
 BuildRequires: mvn(org.slf4j:slf4j-log4j12)
-BuildRequires: mvn(log4j:log4j)
-BuildRequires: mvn(org.codehaus.mojo:properties-maven-plugin)
-BuildRequires: mvn(commons-io:commons-io)
-BuildRequires: mvn(org.apache.maven.plugins:maven-resources-plugin)
-Requires: jsch

 %description
 This is the Java REST client for the version 3 architecture of OpenShift based
@@ -38,7 +41,7 @@

 %prep
 %setup -qn %{name}-%{name}-%{version}.%{rls_tag}
-chmod -x license
+chmod -x license README.md

 %pom_remove_dep org.easytesting:fest-assert

@@ -52,11 +55,11 @@

 %files -f .mfiles
 %dir %{_javadir}/%{name}
-%license epl-v10.html
-%doc license
+%license epl-v10.html license
+%doc README.md DESIGN.md

 %files javadoc -f .mfiles-javadoc
-%license epl-v10.html
+%license epl-v10.html license

 %changelog
 * Sun Jan 10 2016 Marcus Karlsson  - 3.0.1-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #2 from gil cattaneo  ---
maybe you can use BuildRequires: mvn(com.jcraft:jsch) instead of BuildRequires:
jsch. Reading the pom file properties-maven-plugin should be not involved as
build tool, and should be removed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #3 from gil cattaneo  ---
these BRs deps are not listed:

mvn(commons-codec:commons-codec)
mvn(commons-lang:commons-lang)
mvn(org.apache.commons:commons-compress)
mvn(org.apache.httpcomponents:httpclient)
mvn(org.apache.httpcomponents:httpcore)
mvn(org.slf4j:slf4j-api)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
Hi,
jsch should be already listed as requires. you could remove:
Requires: jsch
you can also remove:
BuildRequires: mvn(org.apache.maven.plugins:maven-resources-plugin)
license file is part of the license stuff, you should handle it with %license
macro
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review