[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/tar-split

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Jan Chaloupka  ---
Summary:
- golang side of the spec file fine
- license ok
- rpmlint ok

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871



--- Comment #8 from Antonio Murdaca  ---
Spec URL:
https://github.com/gofed/reviews/raw/master/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec
SRPM URL:
https://github.com/gofed/reviews/raw/master/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.12-1.fc23.src.rpm

Koji builds:

- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12774264
- rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12774380

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871



--- Comment #5 from Antonio Murdaca  ---
https://github.com/gofed/reviews/pull/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871

Jan Chaloupka  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jchal...@redhat.com
  Flags||fedora-review+



--- Comment #6 from Jan Chaloupka  ---
$ rpmlint
/home/jchaloup/rpmbuild/SRPMS/golang-github-vbatts-tar-split-0.9.12-1.fc20.src.rpm
golang-github-vbatts-tar-split.src: W: spelling-error Summary(en_US)
disassembly -> disassemble, dis assembly, dis-assembly
golang-github-vbatts-tar-split.src: W: summary-not-capitalized C tar archive
assembly/disassembly
golang-github-vbatts-tar-split.src: W: spelling-error %description -l en_US
Pristinely -> Pristine
golang-github-vbatts-tar-split.src: E: description-line-too-long C Pristinely
disassembling a tar archive, and stashing needed raw bytes and offsets to
reassemble a validating original archive.
golang-github-vbatts-tar-split.src: W: invalid-license BSD 3-clause
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

In summary
- license should be "BSD"
- capitalize summary
- break description into two lines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871

Jan Chaloupka  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871

Jan Chaloupka  changed:

   What|Removed |Added

 CC||jchal...@redhat.com



--- Comment #4 from Jan Chaloupka  ---
Can you create PR with your spec file and srpm here [1]? Github allows us to
comment each line of a spec file. So we don't have to comment affected lines
here and get confused what does it actually means.

Steps:
1) create directory with expected package name
2) create spec file (with patches and other important files) and srpm in that
directory
3) create PR.
4) post link to the PR here.

In future, I would like to recommend using Github for golang related comments.

[1] https://github.com/gofed/reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871



--- Comment #3 from Antonio Murdaca  ---
Updated package to v0.9.12

spec and SRPM updated

Spec URL:
https://raw.githubusercontent.com/runcom/fedora-pkgs/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec
SRPM URL:
https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.12-1.fc23.src.rpm

Koji builds:

- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12755197
- rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12755203

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871



--- Comment #2 from Antonio Murdaca  ---
spec and SRPM updated

Spec URL:
https://raw.githubusercontent.com/runcom/fedora-pkgs/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec
SRPM URL:
https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.11-1.fc23.src.rpm

Koji builds:

- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12738989
- rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12738992

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871



--- Comment #1 from Antonio Murdaca  ---
This is missing cmd/ command directory which needs to be packaged as well - so
tar-split provides a cmd/ and devel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review