[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217

Jerry James  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-03-05 10:58:33



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-latexcodec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #11 from Jerry James  ---
Thank you for the review, Mohamed.  New package request submitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
 CC||zbys...@in.waw.pl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217

Mohamed El Morabity  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Mohamed El Morabity  ---
Perfect :)

Package approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217

Jerry James  changed:

   What|Removed |Added

 Blocks||1312410




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1312410
[Bug 1312410] Review Request: python-sphinxcontrib-bibtex - Sphinx
extension for BibTeX style citations
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #9 from Jerry James  ---
Okay, finally got a few minutes to update the URL and add the underscore
bundling Provides.  New URLs:

Spec URL:
https://jjames.fedorapeople.org/python-latexcodec/python-latexcodec.spec
SRPM URL:
https://jjames.fedorapeople.org/python-latexcodec/python-latexcodec-1.0.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #8 from Mohamed El Morabity  ---
(In reply to Jerry James from comment #7)
> > - I cant' find any Javascript code in the sources whereas you specified your
> > package bundles jquery.
> 
> It's in the documentation generated by sphinx.  If you look in the binary
> RPM, you will see it.  It is true that the source RPM contains no
> Javascript. :-)
It's OK for me :). Then don't forgot to add also "bundle(js-underscore)"
(underscore.js is not provided directly by sphinx).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #7 from Jerry James  ---
Thank you very much for the review, Mohamed.

(In reply to Mohamed El Morabity from comment #6)
> - about the project URL: maybe you should set it to
> https://github.com/mcmtroffaes/latexcodec/, as specified on the Pypy page.
> Not a blocker anyway :)

Sure, I can make that change.

> - I cant' find any Javascript code in the sources whereas you specified your
> package bundles jquery.

It's in the documentation generated by sphinx.  If you look in the binary RPM,
you will see it.  It is true that the source RPM contains no Javascript. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217

Mohamed El Morabity  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



--- Comment #6 from Mohamed El Morabity  ---
The package looks quite fine at first sight :).
Just a few notes:
- about the project URL: maybe you should set it to
https://github.com/mcmtroffaes/latexcodec/, as specified on the Pypy page. Not
a blocker anyway :)
- I cant' find any Javascript code in the sources whereas you specified your
package bundles jquery.

Here is the complete review:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.txt is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1167360 bytes in 90 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No 

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #5 from Jiri Konecny  ---
It's working correctly now. Seems that there was an issue on my side. Sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #2 from Jerry James  ---
I don't know what you are talking about.  I successfully used both links at
work and at home.  My files are inside a public_html folder.  Everything
appears to be fine from here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217

Mohamed El Morabity  changed:

   What|Removed |Added

 CC||pikachu.2...@gmail.com
   Assignee|nob...@fedoraproject.org|pikachu.2...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #3 from Mohamed El Morabity  ---
Everything's fine here also. I will review this pacckage BTW.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217



--- Comment #4 from Jerry James  ---
Thank you, Mohamed.  If you need something reviewed, let me know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304217] Review Request: python-latexcodec - Lexer and codec to work with LaTeX code in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304217

Jiri Konecny  changed:

   What|Removed |Added

 CC||jkone...@redhat.com



--- Comment #1 from Jiri Konecny  ---
Please fix permissions for your links. They can't be reached. I'm getting 403
Forbidden.

If I'm right, you need to have public_html folder in your home directory on the
fedorapeople.org server to be accessible from the outside.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review