[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #18 from Fedora Update System  ---
R-RInside-0.2.13-1.el6, R-Rcpp-0.12.3-3.el6, R-highlight-0.4.7-1.el6,
R-inline-0.3.14-1.el6, R-littler-0.3.0-1.el6 has been pushed to the Fedora EPEL
6 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #17 from Fedora Update System  ---
R-RInside-0.2.13-1.el7, R-Rcpp-0.12.3-3.el7, R-highlight-0.4.7-1.el7,
R-inline-0.3.14-1.el7, R-littler-0.3.0-1.el7 has been pushed to the Fedora EPEL
7 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-02-22 15:50:08 |2016-03-12 14:58:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #16 from Fedora Update System  ---
R-RInside-0.2.13-1.el7, R-Rcpp-0.12.3-3.el7, R-highlight-0.4.7-1.el7,
R-inline-0.3.14-1.el7, R-littler-0.3.0-1.el7 has been pushed to the Fedora EPEL
7 testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9ad155732b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #15 from Fedora Update System  ---
R-RInside-0.2.13-1.el6, R-Rcpp-0.12.3-3.el6, R-highlight-0.4.7-1.el6,
R-inline-0.3.14-1.el6, R-littler-0.3.0-1.el6 has been pushed to the Fedora EPEL
6 testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-359b7ddb9a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #13 from Fedora Update System  ---
R-RInside-0.2.13-1.el7 R-Rcpp-0.12.3-3.el7 R-littler-0.3.0-1.el7
R-inline-0.3.14-1.el7 R-highlight-0.4.7-1.el7 has been submitted as an update
to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9ad155732b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #14 from Fedora Update System  ---
R-RInside-0.2.13-1.el6 R-Rcpp-0.12.3-3.el6 R-littler-0.3.0-1.el6
R-inline-0.3.14-1.el6 R-highlight-0.4.7-1.el6 has been submitted as an update
to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-359b7ddb9a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #12 from Fedora Update System  ---
R-highlight-0.4.7-1.fc23, R-inline-0.3.14-1.fc23 has been pushed to the Fedora
23 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-22 15:50:08



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #11 from Fedora Update System  ---
R-highlight-0.4.7-1.fc22, R-inline-0.3.14-1.fc22 has been pushed to the Fedora
22 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #10 from Fedora Update System  ---
R-highlight-0.4.7-1.fc23, R-inline-0.3.14-1.fc23 has been pushed to the Fedora
23 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5c7fbfc747

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
R-highlight-0.4.7-1.fc22, R-inline-0.3.14-1.fc22 has been pushed to the Fedora
22 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3d572c4db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/R-highlight

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #7 from Fedora Update System  ---
R-highlight-0.4.7-1.fc22 R-inline-0.3.14-1.fc22 has been submitted as an update
to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3d572c4db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #7 from Fedora Update System  ---
R-highlight-0.4.7-1.fc22 R-inline-0.3.14-1.fc22 has been submitted as an update
to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3d572c4db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #7 from Fedora Update System  ---
R-highlight-0.4.7-1.fc22 R-inline-0.3.14-1.fc22 has been submitted as an update
to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3d572c4db

--- Comment #8 from Fedora Update System  ---
R-highlight-0.4.7-1.fc22 R-inline-0.3.14-1.fc22 has been submitted as an update
to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3d572c4db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #6 from Fedora Update System  ---
R-highlight-0.4.7-1.fc23 R-inline-0.3.14-1.fc23 has been submitted as an update
to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5c7fbfc747

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #1 from Mukundan Ragavan  ---
Full review below -



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


---> Can install manually without problems.

- Package have the default element marked as %%doc :DESCRIPTION, NEWS

---> Same issue as in bug #1305334. No issues here.

- Package requires R-core.

---> This is present. Arch specific entry.

- Package contains the mandatory BuildRequires.
  Note: Missing BuildRequires on R-devel, tex(latex)
  See: http://fedoraproject.org/wiki/Packaging:R

---> R-core-devel is in BR. This is fine.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

---> looks fine.


[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* GPL (v3 or later)", "LGPL (v3 or later)", "GPL
 (v3 or later)", "Unknown or generated". 14 files have unknown license.
 Detailed output of licensecheck in

/home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1305333-R-highlight/licensecheck.txt

---> I don't see any issues in the files listed in licensecheck.


[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: The package has the standard %install 

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #2 from Mukundan Ragavan  ---
Scratch build - http://koji.fedoraproject.org/koji/taskinfo?taskID=12947547

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Mukundan Ragavan  ---
All seems to be well here. Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333



--- Comment #4 from Upstream Release Monitoring 
 ---
nonamedotc's scratch build of R-highlight-0.4.7-1.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12947547

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Mukundan Ragavan  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|nonamed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Mattias Ellert  changed:

   What|Removed |Added

 Blocks||1305335




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305335
[Bug 1305335] Review Request: R-Rcpp - Seamless R and C++ Integration
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review