[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #20 from Fedora Update System  ---
R-RInside-0.2.13-1.el6, R-Rcpp-0.12.3-3.el6, R-highlight-0.4.7-1.el6,
R-inline-0.3.14-1.el6, R-littler-0.3.0-1.el6 has been pushed to the Fedora EPEL
6 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #19 from Fedora Update System  ---
R-RInside-0.2.13-1.el7, R-Rcpp-0.12.3-3.el7, R-highlight-0.4.7-1.el7,
R-inline-0.3.14-1.el7, R-littler-0.3.0-1.el7 has been pushed to the Fedora EPEL
7 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #18 from Fedora Update System  ---
R-RInside-0.2.13-1.fc23, R-Rcpp-0.12.3-3.fc23, R-littler-0.3.0-1.fc23 has been
pushed to the Fedora 23 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336
Bug 1305336 depends on bug 1305335, which changed state.

Bug 1305335 Summary: Review Request: R-Rcpp - Seamless R and C++ Integration
https://bugzilla.redhat.com/show_bug.cgi?id=1305335

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-03-04 20:20:35



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #17 from Fedora Update System  ---
R-RInside-0.2.13-1.fc22, R-Rcpp-0.12.3-3.fc22, R-littler-0.3.0-1.fc22 has been
pushed to the Fedora 22 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #16 from Fedora Update System  ---
R-RInside-0.2.13-1.fc23, R-Rcpp-0.12.3-3.fc23, R-littler-0.3.0-1.fc23 has been
pushed to the Fedora 23 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b55f0bcc50

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #15 from Fedora Update System  ---
R-RInside-0.2.13-1.el7, R-Rcpp-0.12.3-3.el7, R-highlight-0.4.7-1.el7,
R-inline-0.3.14-1.el7, R-littler-0.3.0-1.el7 has been pushed to the Fedora EPEL
7 testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9ad155732b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #14 from Fedora Update System  ---
R-RInside-0.2.13-1.el6, R-Rcpp-0.12.3-3.el6, R-highlight-0.4.7-1.el6,
R-inline-0.3.14-1.el6, R-littler-0.3.0-1.el6 has been pushed to the Fedora EPEL
6 testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-359b7ddb9a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
R-RInside-0.2.13-1.fc22, R-Rcpp-0.12.3-3.fc22, R-littler-0.3.0-1.fc22 has been
pushed to the Fedora 22 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d74f736f60

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #12 from Fedora Update System  ---
R-RInside-0.2.13-1.el6 R-Rcpp-0.12.3-3.el6 R-littler-0.3.0-1.el6
R-inline-0.3.14-1.el6 R-highlight-0.4.7-1.el6 has been submitted as an update
to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-359b7ddb9a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #11 from Fedora Update System  ---
R-RInside-0.2.13-1.el7 R-Rcpp-0.12.3-3.el7 R-littler-0.3.0-1.el7
R-inline-0.3.14-1.el7 R-highlight-0.4.7-1.el7 has been submitted as an update
to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9ad155732b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #9 from Fedora Update System  ---
R-RInside-0.2.13-1.fc22 R-Rcpp-0.12.3-3.fc22 R-littler-0.3.0-1.fc22 has been
submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d74f736f60

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #10 from Fedora Update System  ---
R-RInside-0.2.13-1.fc22 R-Rcpp-0.12.3-3.fc22 R-littler-0.3.0-1.fc22 has been
submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d74f736f60

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #8 from Fedora Update System  ---
R-RInside-0.2.13-1.fc23 R-Rcpp-0.12.3-3.fc23 R-littler-0.3.0-1.fc23 has been
submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b55f0bcc50

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #7 from Fedora Update System  ---
R-RInside-0.2.13-1.fc23 R-Rcpp-0.12.3-3.fc23 R-littler-0.3.0-1.fc23 has been
submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b55f0bcc50

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/R-RInside

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #5 from Upstream Release Monitoring 
 ---
nonamedotc's scratch build of R-RInside-0.2.13-1.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13101320

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #4 from Mukundan Ragavan  ---
> 
> Unversioned so-files
> 
> R-RInside: /usr/lib64/R/library/RInside/libs/RInside.so
> R-RInside: /usr/lib64/libRInside.so
> 

For the sake of clarity 
- first entry is not an issue. 
- second file is also fine - at least, as far as I can tell.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #3 from Mukundan Ragavan  ---
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Mukundan Ragavan  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

---> installs fine.

$ rpm -qa R-RInside*
R-RInside-examples-0.2.13-1.fc24.x86_64
R-RInside-0.2.13-1.fc24.x86_64


- Package have the default element marked as %%doc :DESCRIPTION


---> This is also fine.

- Header files in -devel subpackage, if present.
  Note: R-RInside-examples :
  /usr/lib64/R/library/RInside/examples/qt/qtdensity.h R-RInside-examples :
 
/usr/lib64/R/library/RInside/examples/sandboxed_server/client/callback_helper.h
  R-RInside-examples :
  /usr/lib64/R/library/RInside/examples/sandboxed_server/client/rinsideclient.h
  R-RInside-examples :
  /usr/lib64/R/library/RInside/examples/sandboxed_server/common/binarystream.h
  R-RInside-examples :
  /usr/lib64/R/library/RInside/examples/sandboxed_server/common/constants.h
  R-RInside-examples :
  /usr/lib64/R/library/RInside/examples/sandboxed_server/common/typeid.h R
  -RInside-examples :
  /usr/lib64/R/library/RInside/examples/sandboxed_server/datatypes/bar.h R
  -RInside-examples :
 
/usr/lib64/R/library/RInside/examples/sandboxed_server/datatypes/bar_rcpp_wrapper_declarations.h
  R-RInside-examples :
 
/usr/lib64/R/library/RInside/examples/sandboxed_server/datatypes/bar_rcpp_wrapper_definitions.h
  R-RInside-examples :
  /usr/lib64/R/library/RInside/examples/sandboxed_server/datatypes/foo.h R
  -RInside-examples :
 
/usr/lib64/R/library/RInside/examples/sandboxed_server/datatypes/foo_rcpp_wrapper_declarations.h
  R-RInside-examples :
 
/usr/lib64/R/library/RInside/examples/sandboxed_server/datatypes/foo_rcpp_wrapper_definitions.h
  R-RInside-examples :
 
/usr/lib64/R/library/RInside/examples/sandboxed_server/server/internalfunction_clone.h
  R-RInside-examples :
 
/usr/lib64/R/library/RInside/examples/sandboxed_server/server/rinside_callbacks.h
  R-RInside-examples :
  /usr/lib64/R/library/RInside/examples/sandboxed_server/server/rinsideserver.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


---> All these are perfectly fine.


- Package requires R-core.

---> This is fine.

- Package contains the mandatory BuildRequires.
  Note: Missing BuildRequires on R-devel, tex(latex)
  See: http://fedoraproject.org/wiki/Packaging:R


---> No issues here.

- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


---> I think this is a bogus warning.

$ rpm -qlp R-RInside-devel-0.2.13-1.fc24.x86_64.rpm 
/usr/lib64/R/library/RInside/include
/usr/lib64/R/library/RInside/include/Callbacks.h
/usr/lib64/R/library/RInside/include/MemBuf.h
/usr/lib64/R/library/RInside/include/RInside.h
/usr/lib64/R/library/RInside/include/RInsideCommon.h
/usr/lib64/R/library/RInside/include/RInsideConfig.h



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.

---> License file not included in the tarball and not included in the rpm.
Please get this to upstream's attention


[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 76 files have
 unknown license. Detailed output of licensecheck in

/home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1305336-R-RInside/licensecheck.txt


---> looks fine.


[-]: License file installed when any subpackage combination is installed.

---> See above.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package 

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336



--- Comment #1 from Mukundan Ragavan  ---
I am traveling tomorrow .. will review on Sunday.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|nonamed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Mattias Ellert  changed:

   What|Removed |Added

 Depends On||1305335




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305335
[Bug 1305335] Review Request: R-Rcpp - Seamless R and C++ Integration
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review