[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #1 from Athmane Madjoudj --- Rpmlint output: python-pyuv.x86_64: W: spelling-error Summary(en_US) libuv -> Malibu python-pyuv.x86_64: W: spelling-error %description -l en_US libuv -> Malibu python-pyuv.x86_64: W: spelling-error %description -l en_US epoll -> poll, e poll python-pyuv.x86_64: W: spelling-error %description -l en_US kequeue -> queue python3-pyuv.x86_64: W: spelling-error Summary(en_US) libuv -> Malibu python3-pyuv.x86_64: W: spelling-error %description -l en_US libuv -> Malibu python3-pyuv.x86_64: W: spelling-error %description -l en_US epoll -> poll, e poll python3-pyuv.x86_64: W: spelling-error %description -l en_US kequeue -> queue python-pyuv.src: W: spelling-error Summary(en_US) libuv -> Malibu python-pyuv.src: W: spelling-error %description -l en_US libuv -> Malibu python-pyuv.src: W: spelling-error %description -l en_US epoll -> poll, e poll python-pyuv.src: W: spelling-error %description -l en_US kequeue -> queue -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #2 from Upstream Release Monitoring --- athmane's scratch build of python-pyuv-1.2.0-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12916998 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #3 from Upstream Release Monitoring --- athmane's scratch build of python-pyuv-1.2.0-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12917017 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #4 from Upstream Release Monitoring --- athmane's scratch build of python-pyuv-1.2.0-1.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12917036 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #5 from Athmane Madjoudj --- New spec: Spec URL: https://athmane.fedorapeople.org/pkgs/python-pyuv.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/python-pyuv-1.2.0-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #6 from Athmane Madjoudj --- New spec, the build did not include .py file (only .so): Spec URL: https://athmane.fedorapeople.org/pkgs/python-pyuv.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/python-pyuv-1.2.0-3.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #7 from Athmane Madjoudj --- New build: Spec URL: https://athmane.fedorapeople.org/pkgs/python-pyuv.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/python-pyuv-1.2.0-4.fc23.src.rpm %changelog * Tue Feb 09 2016 Athmane Madjoudj 1.2.0-4 - Fix reqs since pyuv uses uv_tcp_init_ex (new in 1.7.0) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #8 from Upstream Release Monitoring --- athmane's scratch build of python-pyuv-1.2.0-4.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12918404 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996
William Moreno changed:
What|Removed |Added
CC||williamjmore...@gmail.com
Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
Flags||fedora-review?
--- Comment #9 from William Moreno ---
I am not sure about this packaging, but need a lot of work.
You are not going to epel6 so you do not have this in the top of your spec:
%if 0%{?rhel} && 0%{?rhel} <= 6
%{!?__python2: %global __python2 /usr/bin/python2}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif
So we have python3 in epel7:
http://mirror.us.leaseweb.net/epel/7/x86_64/p/python34-3.4.3-4.el7.x86_64.rpm
And if this is this library do not need nothing out of the python standar
library you can build for python3 in epel7.
You are not providing a python2-subpackage.
You are not using the python-provides macro.
You have build requieres python-sphinx but you are no build any documentation
in the spec, also do not provide a -doc subpackage.
You not requires but python3-sphinx and python-sphinx.
Please look at this package spec:
http://pkgs.fedoraproject.org/cgit/rpms/python-pg8000.git/tree/python-pg8000.spec?h=master
It is up to date with current packaging guidelines and support both python3 and
python2 in Fedora 24 and 25 and also Epel7, it will not compile in Fedora23 but
you can test in koji to build in rawhide and epel7.
To get the source rpm in your F23 host just run:
rpmbuild -bs /home/user/rpmbuild/SPECS/python-pyuv.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #10 from William Moreno --- Also note: if test try to download something this mean in most cases than you have missing BuildRequires and if those requires are not packaged yet you will need to package those requires too. And in most cases a BuildRequires is a Requires too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #11 from Athmane Madjoudj --- Thanks for reviewing. I started packaging pyuv before I was aware of the new Python guidelines. please find the updated SPEC and SRPM: https://athmane.fedorapeople.org/pkgs/python-pyuv.spec https://athmane.fedorapeople.org/pkgs/python-pyuv-1.2.0-5.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996
--- Comment #12 from William Moreno ---
Package Review
==
1.
[!]: Package contains no bundled libraries without FPC exception.
There is a complete libuv bundled in pyuv-1.2.0/deps/libuv/
2.
[!]: %check is present and all tests pass.
Most of the time with python packages try to get some pkgs from pypi in check
there are missing build requires (and maybe missing requires) please doble
check if dowloaded packages are already in Fedora repos, if so, include then as
buildrequires, if not you must package then firt.
3.
There is a doc directory than you can compile to html with python-sphinx and
include in a doc subpackage.
4.
Can these files go to a -devel supackage.
Unversioned so-files
python2-pyuv: /usr/lib64/python2.7/site-packages/pyuv/_cpyuv.so
python3-pyuv: /usr/lib64/python3.4/site-packages/pyuv/_cpyuv.cpython-34m.so
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bi
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #13 from Athmane Madjoudj --- (In reply to William Moreno from comment #12) > Package Review > == > > 1. > [!]: Package contains no bundled libraries without FPC exception. > There is a complete libuv bundled in pyuv-1.2.0/deps/libuv/ > Removed, it was not used during the build anyway (system-wide libuv forced before build steps) > 2. > [!]: %check is present and all tests pass. > Most of the time with python packages try to get some pkgs from pypi in > check there are missing build requires (and maybe missing requires) please > doble check if dowloaded packages are already in Fedora repos, if so, > include then as buildrequires, if not you must package then firt. > Fixed > 3. > There is a doc directory than you can compile to html with python-sphinx and > include in a doc subpackage. > Fixed > 4. > Can these files go to a -devel supackage. > Unversioned so-files > > python2-pyuv: /usr/lib64/python2.7/site-packages/pyuv/_cpyuv.so > python3-pyuv: /usr/lib64/python3.4/site-packages/pyuv/_cpyuv.cpython-34m.so > so-files are part of the module itself, if moved 'import pyuv' with fail. Please find updated SPEC/SRPM: SPEC: https://athmane.fedorapeople.org/pkgs/python-pyuv.spec SRPM: https://athmane.fedorapeople.org/pkgs/python-pyuv-1.2.0-6.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 William Moreno changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14 from William Moreno --- Package aproved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #15 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pyuv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 --- Comment #16 from Fedora Update System --- python-pyuv-1.2.0-7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-23e017fba4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- python-pyuv-1.2.0-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-23e017fba4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1305996 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-03-14 18:48:04 --- Comment #18 from Fedora Update System --- python-pyuv-1.2.0-7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
