[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-04-05 09:53:39 |2016-06-30 17:27:38



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #13 from Fedora Update System  ---
disruptor-thrift-server-0.3.8-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #12 from Fedora Update System  ---
disruptor-thrift-server-0.3.8-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a3b3b776b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #11 from Fedora Update System  ---
disruptor-thrift-server-0.3.8-2.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a3b3b776b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Tomas Repik  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG),|
   |1324020 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1324020
[Bug 1324020] Review Request: cassandra - OpenSource database Apache
Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #10 from Fedora Update System  ---
disruptor-thrift-server-0.3.8-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #9 from Fedora Update System  ---
disruptor-thrift-server-0.3.8-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-05 09:53:39



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Tomas Repik  changed:

   What|Removed |Added

 Blocks||1324020




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
[Bug 1324020] Review Request: cassandrsa - OpenSource database Apache
Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
disruptor-thrift-server-0.3.8-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca64d3e63d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #7 from Fedora Update System  ---
disruptor-thrift-server-0.3.8-2.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca64d3e63d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/disruptor-thrift-server

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #5 from Tomas Repik  ---
Here is a link to the tests issue on upstream:
https://github.com/xedin/disruptor_thrift_server/issues/13

Thanks for the review, appreciate it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from gil cattaneo  ---
(In reply to Tomas Repik from comment #3)
> When I try to run tests I get this error:
> Could not create ServerSocket on address 
> at
> org.apache.thrift.transport.TNonblockingServerSocket.
> (TNonblockingServerSocket.java:89)
> at
> org.apache.thrift.transport.TNonblockingServerSocket.
> (TNonblockingServerSocket.java:72)
> at com.thinkaurelius.thrift.AbstractDisruptorTest.prepareTest
> (AbstractDisruptorTest.java:66)
> at com.thinkaurelius.thrift.AbstractDisruptorTest.prepareTest
> (AbstractDisruptorTest.java:61)
> at com.thinkaurelius.thrift.OffHeapMultiConnectionTest.prepareTest
> (OffHeapMultiConnectionTest.java:30)
> 
> Any idea why? or how to fix it?

No sorry, maybe some incompatibility with some system libraries* used by this
project. Please, report to upstream.

*  used  required

disruptor: 3.3.2 3.0.1
slf4j-api: 1.6.1 1.7.12+
slf4j-log4j12: 1.7.2 1.7.12+
jna:   3.2.7 4.1.0
junit: 4.8.1 4.12

Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #3 from Tomas Repik  ---
When I try to run tests I get this error:
Could not create ServerSocket on address 
at
org.apache.thrift.transport.TNonblockingServerSocket.(TNonblockingServerSocket.java:89)
at
org.apache.thrift.transport.TNonblockingServerSocket.(TNonblockingServerSocket.java:72)
at com.thinkaurelius.thrift.AbstractDisruptorTest.prepareTest
(AbstractDisruptorTest.java:66)
at com.thinkaurelius.thrift.AbstractDisruptorTest.prepareTest
(AbstractDisruptorTest.java:61)
at com.thinkaurelius.thrift.OffHeapMultiConnectionTest.prepareTest
(OffHeapMultiConnectionTest.java:30)

Any idea why? or how to fix it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Tomas Repik  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 6 files
 have unknown license. Detailed output of licensecheck in
 /home/gil/1306575-disruptor-thrift-server/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include 

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #2 from gil cattaneo  ---
I has escaped those who sponsored you, you can tell me who was sponsoring you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575

Tomas Repik  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR),
   ||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review