[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #14 from Andrea  ---
thanks Adrien!
Fab i have just requested the repo for dynafed, when done i will do the builds
and release it to the testing repos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #13 from Fabrizio Furano  ---
Hey, champagne ! Thank you Adrien !

Does this mean that it's in epel-testing now or that we have to push it ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228

Adrien Devresse  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(ade...@gmail.com) |



--- Comment #12 from Adrien Devresse  ---
Hi,


Looks good to me.

Package Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228

Fabrizio Furano  changed:

   What|Removed |Added

  Flags||needinfo?(ade...@gmail.com)



--- Comment #11 from Fabrizio Furano  ---
Hi,

 should be fixed now, could you please let me know ?

Spec URL:

http://svn.cern.ch/guest/lcgdm/ugr/tags/dynafed_1_2_1/packaging/rpm/specs/dynafed.spec

SRPMS:

http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgdm/repos/release-candidate/el6/x86_64/dynafed-1.2.1-2.20160518.1540rc.el6.src.rpm

Thank you
Fabrizio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #10 from Fabrizio Furano  ---
Hi Adrien,

 thank you very much again for the help.

 What does this mean ? Do you have a suggestion ?

>FAIL: If the source package does not include license text(s) as a separate 
>file from upstream, the packager SHOULD query upstream to include it. [25]

Tnx
fbx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #9 from Adrien Devresse  ---
Hi Andrea,

Thx for the update:

Build rawhide :

http://koji.fedoraproject.org/koji/taskinfo?taskID=13922533

PASSED

build epel7 :

http://koji.fedoraproject.org/koji/taskinfo?taskID=13922570 

PASSED

build epel6 :

http://koji.fedoraproject.org/koji/taskinfo?taskID=13922678

PASSED

build fedora 24

http://koji.fedoraproject.org/koji/taskinfo?taskID=13922953

PASSED

MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]

dynafed.src: E: description-line-too-long C The Dynafed project provides a
dynamic, scalable HTTP resource federation mechanism for distributed storage
systems.
dynafed.src: E: description-line-too-long C The default deployment style is
accessible by any HTTP/Webdav compatible client. The core components can be
used to design frontends based on other protocols.
dynafed.src: W: no-version-in-last-changelog
dynafed.src:37: W: mixed-use-of-spaces-and-tabs (spaces: line 37, tab: line 17)
dynafed.src: W: invalid-url Source0:
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/dynafed/dynafed-1.2.0.tar.gz
HTTP Error 404: Not Found

dynafed.x86_64: E: description-line-too-long C The Dynafed project provides a
dynamic, scalable HTTP resource federation mechanism for distributed storage
systems.
dynafed.x86_64: E: description-line-too-long C The default deployment style is
accessible by any HTTP/Webdav compatible client. The core components can be
used to design frontends based on other protocols.
dynafed.x86_64: W: no-version-in-last-changelog
dynafed.x86_64: W: unstripped-binary-or-object
/usr/lib64/libugrconnector.so.1.2.0
dynafed.x86_64: W: shared-lib-calls-exit /usr/lib64/libugrconnector.so.1.2.0
exit@GLIBC_2.2.5
dynafed.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/ugr-server
dynafed.x86_64: E: zero-length /usr/share/doc/dynafed-1.2.0/RELEASE-NOTES
dynafed.x86_64: E: non-executable-script /etc/ugr/conf.d/ugrauth_example.py 644
/usr/bin/python
dynafed.x86_64: W: one-line-command-in-%postun /sbin/ldconfig

dynafed-debuginfo.x86_64: W: no-version-in-last-changelog
dynafed-dmlite-frontend.x86_64: W: summary-not-capitalized C dmlite plugin for
dynafed
dynafed-dmlite-frontend.x86_64: W: no-version-in-last-changelog
dynafed-dmlite-frontend.x86_64: W: unstripped-binary-or-object
/usr/lib64/ugr/libugrdmlite.so
dynafed-dmlite-frontend.x86_64: W: no-documentation
d
ynafed-dmlite-plugin.x86_64: W: summary-not-capitalized C dmlite plugin for
dynafed
dynafed-dmlite-plugin.x86_64: W: no-version-in-last-changelog
dynafed-dmlite-plugin.x86_64: W: no-documentation

dynafed-http-plugin.x86_64: W: no-version-in-last-changelog
dynafed-http-plugin.x86_64: W: no-documentation
dynafed-lfc-plugin.x86_64: W: no-version-in-last-changelog
dynafed-lfc-plugin.x86_64: W: no-documentation

dynafed-private-devel.x86_64: W: no-dependency-on
dynafed-private/dynafed-private-libs/libdynafed-private
dynafed-private-devel.x86_64: W: no-version-in-last-changelog
dynafed-private-devel.x86_64: W: only-non-binary-in-usr-lib
dynafed-private-devel.x86_64: W: no-documentation
8 packages and 0 specfiles checked; 7 errors, 23 warnings.



OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.

   -> Apache 2.0

OK: The License field in the package spec file must match the actual license.
[3]
N/A: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %license.[4]
OK: The spec file must be written in American English. [5]
OK: The spec file for the package MUST be legible. [6]

FAIL: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as it is
used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.


http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/dynafed/dynafed-1.2.0.tar.gz
-> No File

OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]

  -> compile for all


N/A: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228

Adrien Devresse  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #8 from Andrea  ---
Hi Adrien,
Fabrizio tagged a new version fixing the problems you found on your initial
review:

Spec URL:

http://svn.cern.ch/guest/lcgdm/ugr/tags/dynafed_1_2_0c/packaging/rpm/specs/dynafed.spec

SRPMS:

http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgdm/repos/release-candidate/el6/x86_64/dynafed-1.2.0-1.20160428.1520rc.el6.src.rpm

cheers
Andrea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #7 from Fabrizio Furano  ---
Hi Adrien,

 python is used for the authorization. Good point about py26 and epel5. I
remove the requirement...

f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228

Adrien Devresse  changed:

   What|Removed |Added

  Flags|needinfo?(ade...@gmail.com) |



--- Comment #6 from Adrien Devresse  ---
Hi Fab,

You have to see, it's not clear to me why python is put as a required
dependency. I don't remember any particular need of python in the UGR build
system.

>  Support for EL5 is not bad if it comes for free, so I would do nothing there.

I don't think it even build for EL5. EPEL-5 do not have python 2.6 by default
and is with GCC 4.1. It is better to drop the support if not strictly needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228

Fabrizio Furano  changed:

   What|Removed |Added

 CC||fur...@cern.ch
  Flags||needinfo?(ade...@gmail.com)



--- Comment #5 from Fabrizio Furano  ---
Hi Adrien,

 thank you very much for the review :-) I am applying the fixes.

 About python, is it safe to remove the minimum needed version ? Isn't this a
small protection against mad package alchemists ?

 Support for EL5 is not bad if it comes for free, so I would do nothing there.

f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #4 from Adrien Devresse  ---
Hi Andrea,


little informal review :

- Please remove the Obsolete, they should be avoided for new packages if not
strictly required.

- BuildRequires:  lfc-libs >= 1.8.8 
   -> lfc-devel should normally already install lfc-libs

-> same for python


-> package need to support SystemD for EPEL7 / rawhide

   This means 

  -> no rsyslog and lograte dependency for these platforms


  -> Following this guidelines
https://fedoraproject.org/wiki/Packaging:Systemd about restart conditions and
scriptlets


-> Do you really want to support EL5 ? If not, the header concerning boost is
not needed.



Adrien

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228

Adrien Devresse  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ade...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #3 from Andrea  ---
new upstream version:

Spec URL:
http://svn.cern.ch/guest/lcgdm/ugr/tags/dynafed_1_2_0/packaging/rpm/specs/dynafed.spec

SRPM URL:
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgdm/repos/release-candidate/el6/x86_64/dynafed-1.2.0-1.el6.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228

Andrea  changed:

   What|Removed |Added

 CC||fabrizio.fur...@cern.ch



--- Comment #2 from Andrea  ---
new upstream version

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307228] Review Request: dynafed- The Dynamic Federations system allows to expose via HTTP and WebDAV a very fast dynamic name space

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307228



--- Comment #1 from Andrea  ---
better Spec URL:
http://svn.cern.ch/guest/lcgdm/ugr/tags/dynafed_1_1_0/packaging/rpm/specs/dynafed.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review