[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #16 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-26 20:37:16



--- Comment #15 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #14 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd208a3f8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-41326fc2f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #12 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd208a3f8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #11 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-41326fc2f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

greg.helli...@gmail.com changed:

   What|Removed |Added

  Flags|needinfo?(greg.hellings@gma |
   |il.com) |



--- Comment #10 from greg.helli...@gmail.com ---
Let me get onto this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

Matthias Runge  changed:

   What|Removed |Added

 CC||mru...@redhat.com



--- Comment #9 from Matthias Runge  ---
Would you be able to import the package now?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

Matthias Runge  changed:

   What|Removed |Added

 CC||greg.helli...@gmail.com
  Flags||needinfo?(greg.hellings@gma
   ||il.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-async_sinatra

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Jerry James  ---
Sorry for the delay.  This looks great.  All issues have been resolved, so this
package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

greg.helli...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |rubygem-async_sinatra - A   |rubygem-async_sinatra - A
   |Sinatra plugin to provide   |Sinatra plugin for running
   |convenience whilst  |on async webservers
   |performing asynchronous |
   |responses inside of the |
   |Sinatra framework running   |
   |under async webservers  |



--- Comment #6 from greg.helli...@gmail.com ---
(In reply to Jerry James from comment #5)
> (In reply to greg.hellings from comment #4)
> > This appears to be the same problem as the other two reviews.
> 
> Yes, I wish I knew what is going on there.
> 
> > This was generated from the gem file. I've abbreviated it more 
> > appropriately.
> 
> That Summary is better, but now rpmlint complains:
> 
> rubygem-async_sinatra.noarch: W: summary-ended-with-dot C A Sinatra plugin
> for r
> unning on async webservers.
> 
> To make rpmlint happy, can we take the dot off the end?  Also, you will need
> to change the name of this bug to match the new summary prior to asking for
> package creation.

This is done.

> 
> > This text is provided by upstream. Is British/American spelling differences
> > an issue? I can alter it if American is expected.
> 
> See the 2nd paragraph of
> https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

Updated.

> 
> > This is likely unnecessary, but the same as the other review. It is
> > informative for conveying information related to packaging the gem, but not
> > necessary important.
> 
> Okay, I will leave it up to you.

Removing this file, in order to simplify the whole process. Also should resolve
the issue with the dependencies.

There were additional files (in the examples set) that were also pulling in the
/usr/bin/env requirement. I've cleaned those up and the dependency is now
removed.

> 
> > There's no reason it shouldn't be executable, if we're leaving it in.
> 
> I'm going by the 3rd paragraph of
> https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> 
> "Files marked as documentation must not cause the package to pull in more
> dependencies than it would without the documentation. One simple way to
> ensure this in most cases is to remove all executable permissions from files
> in %_pkgdocdir."
> 
> In this case, a documentation file is adding a dependency on /usr/bin/env.
> 
> > I've moved the README.rdoc up to the main package and tagged it with
> > %license. But where is the processed CHANGELOG.rdoc? I'm happy to remove it
> > if you think it should be, but I've frequently seen those included as %doc
> > files.
> 
> The HTML version is in
> /usr/share/gems/doc/async_sinatra-1.2.1/rdoc/CHANGELOG_rdoc.html.  If you
> think the source version is also useful, I'm fine with that; just asking the
> question.

I've also removed this file, since there should be no need to include the
source file when a build result is available instead.

New files at
https://fedorapeople.org/~greghellings/rubygem-async_sinatra/rubygem-async_sinatra.spec
https://fedorapeople.org/~greghellings/rubygem-async_sinatra/rubygem-async_sinatra-1.2.1-3.fc24.src.rpm

--Greg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review