[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #21 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #20 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #19 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-06-18 00:24:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #18 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-19fabfc432

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #17 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-91e8c1cf59

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0e39325534

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #14 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-19fabfc432

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #15 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0e39325534

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #13 from Fedora Update System  ---
glibc-arm-linux-gnu-2.23-4.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-91e8c1cf59

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #12 from Kevin Fenzi  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/glibc-arm-linux-gnu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Dominik 'Rathann' Mierzejewski  ---
Great! Everything looks fine now, package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Tom "spot" Callaway  changed:

   What|Removed |Added

  Flags|needinfo?(tcallawa@redhat.c |
   |om) |



--- Comment #10 from Tom "spot" Callaway  ---
Sorry. Mixture of being busy and being sick.

New SRPM: https://spot.fedorapeople.org/glibc-arm-linux-gnu-2.23-4.fc24.src.rpm
New SPEC: https://spot.fedorapeople.org/glibc-arm-linux-gnu.spec

Headers are only needed on Fedora 23 or older, I asked the kernel package to
grow the cross-headers package so we wouldn't need to bundle in the future. 

Updated licensing, dropped giant changelogs (not needed), used smp_mflags
consistently (even if it might be pointless on an make install), owned target
dir.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
  Flags||needinfo?(tcallawa@redhat.c
   ||om)



--- Comment #9 from Dominik 'Rathann' Mierzejewski  ---
Ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #8 from Dominik 'Rathann' Mierzejewski  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

  I think this is due to:
  %doc glibc-%{version}/BUGS glibc-%{version}/C* glibc-%{version}/README

  I suggest using:
  %doc glibc-%{version}/BUGS glibc-%{version}/CONFORMANCE
  %doc glibc-%{version}/ChangeLog* glibc-%{version}/README
  %license glibc-%{version}/COPYING*

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 9533440 bytes in 38 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

  That's 9M out of ~60M of installed size. I'm not sure including all the
  ChangeLogs is worth the space. I'd gzip them at least.

- Licensecheck found more licenses inside. Please adjust the License: tag or
  explain why it's not required.

- /usr/arm-linux-gnu seems to be unowned

- Why are you using make -j1 in %install?

- Requires: kernel-cross-headers are only for F24+, are they not required on
  F23?

- It's not documented how arm-kernel-headers-4.3.5-300.tar.xz is created

= MUST items =

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause) ISC LGPL (v2.1 or later)", "LGPL (v2 or
 later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated", "MIT/X11 (BSD like)", "BSD", "BSD (3 clause) ISC", "*No
 copyright* LGPL (v2.1 or later)", "LGPL (v2.1 or later) (with
 incorrect FSF address)", "*No copyright* Public domain", "BSD (3
 clause)", "LGPL", "ISC", "LGPL (v2.1 or later)", "GPL (v3)", "GPL
 (v2)", "BSD (3 clause) LGPL (v2.1 or later)". 4729 files have unknown
 license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/arm-linux-gnu
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/arm-linux-gnu
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not 

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #7 from Tom "spot" Callaway  ---
Thanks for the patch!

Rawhide Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14173755
New SRPM: https://spot.fedorapeople.org/glibc-arm-linux-gnu-2.23-3.fc24.src.rpm
New SPEC: https://spot.fedorapeople.org/glibc-arm-linux-gnu.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #6 from Dominik 'Rathann' Mierzejewski  ---
Created attachment 1159546
  --> https://bugzilla.redhat.com/attachment.cgi?id=1159546=edit
patch to fix compilation with gcc-6.1.1

It builds with this patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #4 from Tom "spot" Callaway  ---
Fixed this by cleaning up the %files entry. I suspect that this is due to glibc
generating these files when other components are present in the Build
environment, however, since we don't care about info/locale files, I've just
dropped them from the %files list.

Rawhide Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13813983
New SRPM: https://spot.fedorapeople.org/glibc-arm-linux-gnu-2.23-2.fc24.src.rpm
New SPEC: https://spot.fedorapeople.org/glibc-arm-linux-gnu.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
I tried in F23 buildroot and the result is the same. So this is not related to
the glibc langpacks thing. I don't see any translations files in the buildroot
at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963



--- Comment #2 from Jonathan Underwood  ---
Created attachment 1137141
  --> https://bugzilla.redhat.com/attachment.cgi?id=1137141=edit
Build log of failed build on rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Jonathan Underwood  changed:

   What|Removed |Added

 CC||jonathan.underw...@gmail.co
   ||m



--- Comment #1 from Jonathan Underwood  ---
Unfortunately, while starting a review, I found this doesn't build on rawhide:

+ /usr/lib/rpm/find-lang.sh
/builddir/build/BUILDROOT/glibc-arm-linux-gnu-2.23-1.fc25.x86_64 libc
No translations found for libc in
/builddir/build/BUILDROOT/glibc-arm-linux-gnu-2.23-1.fc25.x86_64
error: Bad exit status from /var/tmp/rpm-tmp.orb7iQ (%install)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.orb7iQ (%install)
Child return code was: 1


Probably fallout from the glibc langpack re-jigging.

If you can fix that, I'll pick up the review next week - am about to hit the
road for a few days. I'll leave the bug untaken for now, in case you fixi it
and someone else is just aching to review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Tom "spot" Callaway  changed:

   What|Removed |Added

 Blocks||1270405




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1270405
[Bug 1270405] Review Request: native_client - Google Native Client
Toolchain
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review