[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Raphael Groner  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-04-24 07:10:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Raphael Groner  changed:

   What|Removed |Added

  Alias|open-nat|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828



--- Comment #8 from Kevin Fenzi  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/open-nat

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #7 from Raphael Groner  ---
Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Antti Järvinen  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Antti Järvinen  ---
All right then, all the "must" items are fulfilled. 

What we would need is some additional support for rpmlint about mono packages,
obviously it does not serve us well. 

--
Antti Järvinen

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828



--- Comment #5 from Raphael Groner  ---
> open-nat.src:62: E: hardcoded-library-path in %{buildroot}/usr/lib

That's a false positive.
https://fedoraproject.org/wiki/Packaging:Mono#gacutil_in_a_spec_file
https://fedoraproject.org/wiki/Packaging:Mono#rpmlint_and_mono_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828



--- Comment #4 from Antti Järvinen  ---
All right, 

I see that the "must" items previously mentioned are done so I'm almost ok with
this review. One new thing could be fixed still, namely the

open-nat.src:62: E: hardcoded-library-path in %{buildroot}/usr/lib

rpmlint error from source rpm, see 
https://fedoraproject.org/wiki/Common_Rpmlint_issues#hardcoded-library-path
for details. The other rpmlint error from binary rpm that is "no binary" you
most likely can't fix due to wrong binary format (non-ELF on ELF-system).

--
Antti

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828



--- Comment #3 from Raphael Groner  ---
Hello Antti,

thanks for your interest in this review.

Most of your questions have nothing to do with the package review, propably
they should go to upstream.

> [-]: %check is present and all tests pass.

%check is not missing, please look into the spec file. The test suite is not of
much use for an automatic test, cause it just prints some individual output.

Spec URL: https://raphgro.fedorapeople.org/review/openra/open-nat.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/openra/open-nat-2.0.11-2.20160413gitf288f8d.fc23.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13719455

* Tue Apr 19 2016 Raphael Groner <> - 2.0.11-2.20160128gita5c834d
- add license tag
- fix folders ownership
- bump to new github snapshot
- disable nuget
- improve execution of tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Antti Järvinen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|antti.jarvi...@katiska.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Antti Järvinen  changed:

   What|Removed |Added

 CC||antti.jarvi...@katiska.org



--- Comment #2 from Antti Järvinen  ---
Hello Raphael,

and thank you for submitting open-nat for review. I'm not in packagers group so
I can't submit your package forward but I hope my comments are useful for
someone who can. I have reviewed your package with automated tool, looking at
code, and running tests. Please find my comments below, included in checklist.
All "must items" should be easy to fix. Outside the checklist I have this kind
of question: as interfacing an existing library (native linux, .so -library)
from c# is possible, would it make sense to have a wrapper around miniupnpc
library to bring its functionality into world of mono and c#? While open-nat
looks like a sane library to me, it still presents duplicated functionality..?

Of rpmlint warnings I'd raise the "no documentation" thing -> some kind of
manpage or README-file or something would be a nice thing, because this thing
is a library. 

--
Antti Järvinen


-> review checklist follows
= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 9 files have
 unknown license. Detailed output of licensecheck in /tmp/1313828-open-
 nat/1313828-open-nat/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
 -> Otherwise ok, but instead of having %doc LICENSE it should be
%license LICENSE
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/mono/open-nat
-> something like
 %dir %{_monogacdir}/%{libname}
 in %files-secion might be in order
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/mono/open-nat
 -> see comment at previous item. 
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
 -> note, there is exclucive mono architectures but I think that is unavoidable
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 102400 bytes in 16 files.
[!]: Package complies to the Packaging Guidelines
 -> ok, but with issues mentioned here
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are 

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Raphael Groner  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1166897



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828



--- Comment #1 from Upstream Release Monitoring 
 ---
raphgro's scratch build of open-nat-2.0.11-1.20160128gita5c834d.fc23.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=13200073

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Raphael Groner  changed:

   What|Removed |Added

  Alias||open-nat



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1313828] Review Request: open-nat - Library to allow port forwarding in NAT devices that support UPNP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313828

Raphael Groner  changed:

   What|Removed |Added

 Blocks||1159091 (openra)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1159091
[Bug 1159091] Review Request: openra - Libre/Free Real Time Strategy
project [+Tracker to unbundle all dependencies]
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review