[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-28 23:55:13



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #26 from Fedora Update System  ---
kdepim4-4.14.10-24.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #25 from Fedora Update System  ---
kdepim4-4.14.10-24.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4df8065ced

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #24 from Fedora Update System  ---
kdepim4-4.14.10-24.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4df8065ced

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #23 from Kevin Fenzi  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/kdepim4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #22 from Rex Dieter  ---
Thanks for the thorough reviews!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(williamjmorenor@g |
   |mail.com)   |



--- Comment #21 from William Moreno  ---
I am fine with this packaging. Aproved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #20 from Rex Dieter  ---
1.  update-desktop-desktop is invoked:

...
%posttrans -n knode
gtk-update-icon-cache %{_kde4_iconsdir}/hicolor &> /dev/null ||:
update-desktop-database -q &> /dev/null ||:

%postun -n knode
if [ $1 -eq 0 ] ; then
gtk-update-icon-cache %{_kde4_iconsdir}/hicolor &> /dev/null ||:
update-desktop-database -q &> /dev/null ||:
fi


2. - Can move those files to a devel subpackage?
[!]: Development (unversioned) .so files in -devel subpackage, if present.

No, they are all runtime plugins.


3.  - Current packagin guidelines recomends to include a appdata.xml

Yeah, upstream doesn't provide one, I could work on one eventually, but this
shouldn't be a blocker either


Is there anything else I may have missed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

William Moreno  changed:

   What|Removed |Added

  Flags|needinfo?(williamjmorenor@g |
   |mail.com)   |



--- Comment #19 from William Moreno  ---
Issues:
===

- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in knode, ktimetracker
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database

- Can move those files to a devel subpackage?
[!]: Development (unversioned) .so files in -devel subpackage, if present.
Unversioned so-files

knode: /usr/lib64/kde4/kcm_knode.so
knode: /usr/lib64/kde4/knodepart.so
knode-libs:
/usr/lib64/kde4/plugins/accessible/messagevieweraccessiblewidgetfactory.so
knode-libs: /usr/lib64/kde4/plugins/designer/kdepimwidgets.so
knode-libs: /usr/lib64/kde4/plugins/designer/mailcommonwidgets.so
knode-libs: /usr/lib64/kde4/plugins/designer/pimcommonwidgets.so
knode-libs:
/usr/lib64/kde4/plugins/grantlee/0.5/grantlee_messageheaderfilters.so
ktimetracker: /usr/lib64/kde4/kcm_ktimetracker.so
ktimetracker: /usr/lib64/kde4/ktimetrackerpart.so

- Current packagin guidelines recomends to include a appdata.xml fiel fro
grafical interface

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.

[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =
Generic:
[x]: Rpmlint is run on debuginfo package(s).
 Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
---
Checking: knode-4.14.10-23.fc23.x86_64.rpm
  knode-libs-4.14.10-23.fc23.x86_64.rpm
  ktimetracker-4.14.10-23.fc23.x86_64.rpm
  kdepim4-debuginfo-4.14.10-23.fc23.x86_64.rpm
  kdepim4-4.14.10-23.fc23.src.rpm
knode.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/knode.svgz
knode.x86_64: W: no-manual-page-for-binary knode
knode-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libmailcommon.so.4.14.18
exit@GLIBC_2.2.5
knode-libs.x86_64: W: no-documentation
knode-libs.x86_64: W: no-manual-page-for-binary kincidenceeditor
ktimetracker.x86_64: W: no-manual-page-for-binary ktimetracker
ktimetracker.x86_64: W: no-manual-page-for-binary karm
kdepim4.src:53: W: macro-in-comment %{version}
kdepim4.src:53: W: 

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #18 from Rex Dieter  ---
ping reviewer for feedback on latest submission, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #17 from Rex Dieter  ---
1.  moved knode-libs icons to main pkg, BuildRequires exceptions are no longer
present in guidelines, update-desktop-database scriptlets already included
(%postun and %posttrans)

2. dbus dirs owned by dbus, knode-libs now owns
%{_kde4_libdir}/kde4/plugins/accessible/

3. Should be better to exclude this file:
knode.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/knode.svgz

This is fairly common for kde applications.

4. This package ships many subpackages and I am curious about than there is not
any devel subpackage.

many?  There's only 3: knode, knode-libs, ktimetracker.  There's no -devel
because it doesn't ship anything development related (no header files for use
elsewhere)

5. Subpackages do not have a license text in the rpm: fixed

6.  Some of this files can be moved to a common subpackage?  Could consider
that, but I'd rather not introduce the greater packaging complexity (the
savings here isn't compelling enough).

7. Upstream link to sources is not working: fixed


Spec URL: https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4-4.14.10-23.fc24.src.rpm


%changelog
* Sat Apr 16 2016 Rex Dieter  - 4.14.10-23
- knode: move icons in -libs to main pkg
- knode-libs: own %%{_kde4_libdir}/kde4/plugins/accessible/
- add %%license files
- update URL, Source URL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

William Moreno  changed:

   What|Removed |Added

  Flags|needinfo?(williamjmorenor@g |
   |mail.com)   |



--- Comment #16 from William Moreno  ---
Package Review
==

Issues:
===

1. Fedora review found:
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in knode, knode-libs, ktimetracker
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: sed
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1474560 bytes in 48 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in knode, ktimetracker
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database



2. Directory ownerhip issues:
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/lib64/kde4/plugins/accessible, /usr/share/dbus-1,
 /usr/share/dbus-1/interfaces

[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/kde4/apps/knode/pics(kdepim-common, knode),
 /usr/share/kde4/apps/libmessageviewer(kmail),
 /usr/lib64/kde4/plugins/grantlee/0.5(kmail, grantlee),
 /usr/share/kde4/apps/kdepimwidgets(kdepim-common),
 /usr/share/kde4/apps/messageviewer/themes/example(kmail),
 /usr/lib64/kde4/plugins/grantlee(kmail),
 /usr/share/kde4/apps/messageviewer(kmail),
 /usr/share/kde4/apps/kdepimwidgets/pics(kdepim-common),
 /usr/share/kde4/apps/messageviewer/themes/example_fancy(kmail),
 /usr/share/kde4/apps/knode(kdepim-common, knode),
 /usr/share/kde4/apps/libkleopatra/pics(kleopatra-libs),
 /usr/share/kde4/apps/messageviewer/about(kmail),
 /usr/share/kde4/apps/messageviewer/themes(kmail),
 /usr/share/kde4/apps/libmessageviewer/pics(kmail),
 /usr/share/kde4/apps/libkleopatra(kleopatra-libs)



3. Should be better to exclude this file:
knode.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/knode.svgz



4. This package ships many subpackages and I am currios about than there is not
any devel subpackage.

[!]: Development (unversioned) .so files in -devel subpackage, if present.
[!]: Development files must be in a -devel package

Unversioned so-files

knode: /usr/lib64/kde4/kcm_knode.so
knode: /usr/lib64/kde4/knodepart.so
knode-libs:
/usr/lib64/kde4/plugins/accessible/messagevieweraccessiblewidgetfactory.so
knode-libs: /usr/lib64/kde4/plugins/designer/kdepimwidgets.so
knode-libs: /usr/lib64/kde4/plugins/designer/mailcommonwidgets.so
knode-libs: /usr/lib64/kde4/plugins/designer/pimcommonwidgets.so
knode-libs:
/usr/lib64/kde4/plugins/grantlee/0.5/grantlee_messageheaderfilters.so
ktimetracker: /usr/lib64/kde4/kcm_ktimetracker.so
ktimetracker: /usr/lib64/kde4/ktimetrackerpart.so


5. Subpackages do not have a license text in the rpm.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[!]: License file installed when any subpackage combination is installed.


6- Some of this files can be moved to a common subpackage?
[!]: Large data in /usr/share should live in a noarch subpackage if package
 is arched.
 Note: Arch-ed rpms have a total of 2181120 bytes in /usr/share


7. Upstream link to sources is not working:
[!]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source0:

http://download.kde.org/stable/applications/4.14.10/src/kdepim-4.14.10.tar.xz
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags


8. There are a lot of these warnings:
unused-direct-shlib-dependency

= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #15 from Rex Dieter  ---
and FYI, reference to Copr I made for initial testing:
https://copr.fedorainfracloud.org/coprs/rdieter/kdepim4/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #14 from Rex Dieter  ---
reviewer ping :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Raphael Groner  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1307200



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #13 from Rex Dieter  ---
and I thought I offered sufficient answers to your questions in comment #7 and
comment #8 . If that's not acceptable to you, then that's fine.  We can agree
to disagree on that (and find a different reviewer).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Raphael Groner  changed:

   What|Removed |Added

 CC|projects...@smart.ms|



--- Comment #12 from Raphael Groner  ---
You obviously miss my point in comment #6, I think the explanations there are
clear enough. I can't continue this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #11 from Rex Dieter  ---
To put another way, I fail to see how this approach runs afoul of current
guidelines and best-practice.  Perhaps can you be more specific?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #10 from Rex Dieter  ---
Feel free to contact FPC if you want clarification.

It's pretty simple and clear *to me* this (current) approach is the ideal way
to handle it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #9 from Raphael Groner  ---
I fail to see how this can go in conjunction with our (general) guidelines,
look into the links of comment #6. Maybe we need a FPC ticket here to get fully
clear.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #8 from Rex Dieter  ---
I guess I can expand on the Conflicts topic, since many other kdepim4-library
related subpkgs that knode depends on are no longer provided, I moved that
content into the knode-libs subpkg.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #7 from Rex Dieter  ---
knode-libs : for multilib, since it contains multilib'd content (shared
libraries), avoids the main/whole package getting multilib'd.  It's common
practice.

Conflicts: helps upgrade path and gives depsolvers hints to avoid known file
conflicts

Since knode and ktimetracker come from the same source tarball, making separate
packages for each makes less sense (to me)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #6 from Raphael Groner  ---
This is obviously a request for a compatibility package.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#MultiplePackages

Not clear for what the subpackage knode-libs is needed. Can you merge that into
knode itself? Both packages depend on each other.
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Please also explain why Conflicts is used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Conflicts

My suggestion is to instead use separately one knode4 and one ktimetracker4
package each with their own spec files. Handle them as renamed packages with
appropriate Provides and Obsoletes.
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #5 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4-4.14.10-22.fc24.src.rpm

%changelog
* Sat Mar 19 2016 Rex Dieter  - 4.14.10-22
- omit grantleeeditor (to avoid conflicts)

* Sat Mar 19 2016 Rex Dieter  - 4.14.10-21
- adjust Conflicts, drop unused -common subpkg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Rex Dieter  changed:

   What|Removed |Added

 Blocks||1314494




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1314494
[Bug 1314494] knode has unmet dependencies during dnf system-upgrade to f24
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #4 from Raphael Groner  ---
For a review swap, could you take mdp (bug #1246790) or dreamchess-tools (bug
#1305390)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #3 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4-4.14.10-20.fc23.src.rpm
Description: 
KDE4 PIM (Personal Information Manager) applications, including:
* knode: newsreader
* ktimetracker: Time and task management

Fedora Account System Username: rdieter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #2 from Raphael Groner  ---
You forgot to provide description and confused with the link to the SRPM.
Please fix, though f-r tool should not claim.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Rex Dieter  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)
  Alias||kdepim4



--- Comment #1 from Rex Dieter  ---
Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=13230720


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review