[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #30 from Fedora Update System  ---
python-librosa-0.4.2-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-04 14:54:09



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #29 from Fedora Update System  ---
python-librosa-0.4.2-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-13db7afc5d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #28 from Fedora Update System  ---
python-librosa-0.4.2-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-edea31c6fc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #27 from Fedora Update System  ---
python-librosa-0.4.2-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-edea31c6fc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #26 from Fedora Update System  ---
python-librosa-0.4.2-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-13db7afc5d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Miro Hrončok  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |fedora-review+



--- Comment #25 from Miro Hrončok  ---
Package is APPROVED. I've just added you to the packager group, continue with
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #24 from Miro Hrončok  ---
Looks good. Will wait for the build in Copr to finish and run rpmlint on the
result juts to be sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #23 from Dominika Krejčí  ---
Final version.

SPEC:
https://raw.githubusercontent.com/Krejdom/librosa-specfile/master/python-librosa.spec

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dkrejci/librosa/fedora-rawhide-x86_64/00175017-python-librosa/python-librosa-0.4.2-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #22 from Dominika Krejčí  ---
Licensese removed.

SPEC:
https://raw.githubusercontent.com/Krejdom/librosa-specfile/master/python-librosa.spec

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dkrejci/librosa/fedora-rawhide-x86_64/00174033-python-librosa/python-librosa-0.4.2-1.fc25.src.rpm

Copr link:
https://copr.fedorainfracloud.org/coprs/dkrejci/librosa/build/174033/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #21 from Miro Hrončok  ---
Don't forget to remove the previously added licenses.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #20 from Dominika Krejčí  ---
Fonts and .buildinfo should be gone.

SPEC:
https://raw.githubusercontent.com/Krejdom/librosa-specfile/master/python-librosa.spec

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dkrejci/librosa/fedora-rawhide-x86_64/00173981-python-librosa/python-librosa-0.4.2-1.fc25.src.rpm

Copr link:
https://copr.fedorainfracloud.org/coprs/dkrejci/librosa/build/173981/ (I've
forgot to exclude build for fedora-rawhide-ppc64le, please ignore that fail.
O:))

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #19 from Miro Hrončok  ---
I think it's ok. Also delete .buildinfo.

Once done, I'll recheck all other issues, but other than that, it seems OK.
Didn't try to build it yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #18 from Dominika Krejčí  ---
Is it ok just delete fonts after the build of the documentation?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #17 from T. Orsava  ---
Besides that, everything else checks out?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #16 from Miro Hrončok  ---
It would be better to remove the bundled fonts, not to add their license to the
metadata.

See
https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_in_other_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #15 from Dominika Krejčí  ---
Hi, this should work.

I fixed licences of ogg file and fonts, used macro for version, removed hidden
file, created subpackage for docs and corrected names of Python2 packages
(joblib added).


Spec URL:
https://raw.githubusercontent.com/Krejdom/librosa-specfile/master/python-librosa.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/dkrejci/librosa/fedora-rawhide-x86_64/00172584-python-librosa/python-librosa-0.4.2-1.fc25.src.rpm

Copr link:
https://copr.fedorainfracloud.org/coprs/dkrejci/librosa/build/172584/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #14 from Miro Hrončok  ---
And of course, if you need help, feel free to ping me on IRC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #13 from Miro Hrončok  ---
Here comes the formal review. Once you fix the issues, please indicate in your
comment what you
have fixed so I can see if you forget something, or if the fix didn't work as
expected.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- The package installs ogg file with another license
  Note: See
/usr/lib/pythonX.Y/site-packages/librosa/util/example_data/Kevin_MacLeod_-_Vibe_Ace.ogg
  The metadata clearly says:
  http://freemusicarchive.org/music/Kevin_MacLeod/Jazz_Sampler/Vibe_Ace
  Copyright: Creative Commons Attribution:
http://creativecommons.org/licenses/by/3.0/

  This requires you to put ""ISC and CC-BY"" in the license field.

- The version number in Source0 is hardcoded, please use %{version} instead

- Fonts are bundled into the documentation. Those are also probably not ISC
licensed.
 /usr/share/doc/pythonX-librosa/html/_static/fonts/*

- Hidden file in docs, see rpmlint output bellow.

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 66641920 bytes in 1024 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

  I suggest to create python-librosa-doc with the HTML docs and use Suggest: to
bring it with
  both packages (2 and 3), see
https://fedoraproject.org/wiki/Packaging:WeakDependencies

- The docs build still screams about joblib, could you add it as BR, as
suggested before?
  ImportError: No module named 'joblib'

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Package complies to the Packaging Guidelines
 Note: Skipping this, because there are other issues
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #12 from Dominika Krejčí  ---
Spec URL:
https://raw.githubusercontent.com/Krejdom/librosa-specfile/master/python-librosa.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/dkrejci/librosa/fedora-rawhide-x86_64/00170671-python-librosa/python-librosa-0.4.2-1.fc25.src.rpm

Copr URL: https://copr.fedorainfracloud.org/coprs/dkrejci/librosa/build/170671/

What about this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Miro Hrončok  changed:

   What|Removed |Added

Summary|Review Request: librosa - a |Review Request:
   |python package for music|python-librosa - a python
   |and audio analysis  |package for music and audio
   ||analysis



--- Comment #6 from Miro Hrončok  ---
So my first concerns are (as Tomáš and Antonio already pointed out):

1) Upstream clearly supports both Pythons, see
https://pypi.python.org/pypi/librosa (categories section). In that case, as
this is a Python library, you should package both versions as subpackages of
python-librosa, see
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file about
an idea how to do it.

2) The shebang manipulation should be done in %prep section, because you are
preparing the sources. As Tomáš pointed out, you also need to do it before
%py3_build - doing it in %prep accomplishes that.

3) There is some documentation in the GitHub repository, you *should* get it in
a separate Source and rebuilt it and package it in %doc. It is also a good idea
to contact upstream about a possibility to include the doc and test in the
source tarball, maybe post a pullrequest with such change. I would say this is
definitly not a *must* thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #7 from Miro Hrončok  ---
You also require some packages as BuildRequires, but you don't use them when
not creating the docs and running the tests:

BuildRequires:  python3-numpydoc
BuildRequires:  python3-seaborn
BuildRequires:  python3-sphinx_rtd_theme

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Dominika Krejčí  changed:

   What|Removed |Added

  Flags|needinfo?(dkre...@redhat.co |
   |m)  |



--- Comment #8 from Dominika Krejčí  ---
Thanks for feedback!

Here is a new SPEC:
https://raw.githubusercontent.com/Krejdom/librosa-specfile/master/python-librosa.spec

and link to Copr:
https://copr.fedorainfracloud.org/coprs/dkrejci/librosa/build/169159/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #9 from Miro Hrončok  ---
%define debug_package %{nil}

This is useless as the package is noarch.


When you say Python in summary/description, please capitalize the P, also it is
a good idea to use Python 2 or Python 3 in the summaries of subpackages.


You install to %{_mandir}/man1/librosa.1* - did you chack the manual page, what
is it about? Man pages in man1 usually refer to executables in /usr/bin (user
commands), while this package brings no executable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #10 from Miro Hrončok  ---
Plesa always provide both spec and srpm in the same form as in the bug
description, otherwise fedora-review is unhappy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186



--- Comment #11 from Miro Hrončok  ---
When I build the docs, I see a lot of errors about joblib, maybe python3-joblib
should be added to BR?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review