[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||erlang-stringprep-1.0.3-3.f
   ||c25
 Resolution|--- |RAWHIDE
Last Closed||2016-04-11 14:46:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772

Randy Barlow  changed:

   What|Removed |Added

   Assignee|jer...@jcline.org   |rbar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772

Jeremy Cline  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Jeremy Cline  ---
It looks like upstream forgot to remove the GPLv2 header from stringprep.cpp.
It would be nice to file issue with upstream.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or
 generated". 6 files have unknown license. Detailed output of
 licensecheck in /home/vagrant/fedora-reviews/1316772-erlang-
 stringprep/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and 

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772

Jeremy Cline  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jer...@jcline.org
   Assignee|nob...@fedoraproject.org|jer...@jcline.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772



--- Comment #5 from Randy Barlow  ---
Hello Peter! I have added the debuginfo package:

Spec URL: https://rbarlow.fedorapeople.org/erlang-stringprep.spec
SRPM URL:
https://rbarlow.fedorapeople.org/erlang-stringprep-1.0.3-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772



--- Comment #4 from Peter Lemenkov  ---
Sorry, but I missed another one thing. You should remove "%global debug_package
%{nil}" because this package contains so-library and therefore should have
debuginfo sub-package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772



--- Comment #3 from Randy Barlow  ---
Hello Peter! I have made the requested changes in release 2 of the package.
Thanks for the tips!

Spec URL: https://rbarlow.fedorapeople.org/erlang-stringprep.spec
SRPM URL:
https://rbarlow.fedorapeople.org/erlang-stringprep-1.0.3-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772

Peter Lemenkov  changed:

   What|Removed |Added

 CC||lemen...@gmail.com



--- Comment #2 from Peter Lemenkov  ---
Needs cleaning up.

* Please add dependency on a NIF version (we can't do it automatically yet).
E.g. add "%{?__erlang_nif_version:Requires: %{__erlang_nif_version}}". See this
spec-file for the example -
http://pkgs.fedoraproject.org/cgit/rpms/erlang-basho_metrics.git/tree/erlang-basho_metrics.spec#n23

* Please, use macro %{rebar_eunit}.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772

Randy Barlow  changed:

   What|Removed |Added

 Blocks||1312874




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1312874
[Bug 1312874] erlang-p1_stringprep-1.0.3 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316772] Review Request: erlang-stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316772

Randy Barlow  changed:

   What|Removed |Added

 Blocks||1312517



--- Comment #1 from Randy Barlow  ---
This is a rename of the erlang-p1_stringprep package, to correspond with the
upstream renaming.

https://admin.fedoraproject.org/pkgdb/package/rpms/erlang-p1_stringprep/


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1312517
[Bug 1312517] ejabberd-16.02 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review