https://bugzilla.redhat.com/show_bug.cgi?id=1317345
Peter Lemenkov changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||lemen...@gmail.com
Assignee|nob...@fedoraproject.org|lemen...@gmail.com
Flags||fedora-review+
--- Comment #1 from Peter Lemenkov ---
REVIEW:
[+] rpmlint is silent (or produces only messages which can be safely ignored.
[+] The package is named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format
%{name}.spec.
[+] The package meets the Erlang Packaging Guidelines.
[+] The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
[+] The License field in the package spec file matches the actual license
(Apache License 2.0)
[+] The file, containing the text of the license(s) for the package, is
included in %doc and marked as %license.
[+] The spec file is written in American English.
[+] The spec file for the package is legible.
[+] The sources used to build the package matches the upstream source, as
provided in the spec URL.
Auriga ~/rpmbuild/SOURCES: sha256sum
9524d0309a88b7c62ae93da0b632b185de3ba9db.tar.gz*
b5af83ceb7b6e984487ab9170cd1c0764c3a320e8461321413d81f6d5fc42647
9524d0309a88b7c62ae93da0b632b185de3ba9db.tar.gz
b5af83ceb7b6e984487ab9170cd1c0764c3a320e8461321413d81f6d5fc42647
9524d0309a88b7c62ae93da0b632b185de3ba9db.tar.gz.1
Auriga ~/rpmbuild/SOURCES:
[+] The package successfully compiles and builds into binary rpms.
[+] All build dependencies are listed in BuildRequires.
[0] No need to handle locales.
[0] The package does not contain any shared library files.
[+] Packages does not bundle copies of system libraries.
[+] The package isn't designed to be relocatable.
[+] The package owns all directories that it creates.
[+] The package does not list a file more than once in the spec file's %files
listings.
[+] Permissions on files are set properly.
[+] The package consistently uses macros.
[+] The package contains code, or permissible content.
[0] No large documentation files.
[+] Anything, the package includes as %doc, does not affect the runtime of the
application.
[0] No static libraries.
[0] No -devel sub-package.
[+] The package does not contain any .la libtool archives.
[0] Not a GUI application.
[+] The package does not own files or directories already owned by other
packages.
[+] All filenames in rpm packages are valid UTF-8.
APPROVED.
PS a minor proposal. I dont see anything in Ejaberd which actually uses luerl
internal headers (*.hrl files). Normally ones which shipped within ./src
directory shoudln't be packaged - only those which stored in ./include should
be.
So if you just unsure what to do with these *.hrl files, then I advice you not
to package them. Feel free to ignore this advice since shipping them doesn't
hurt anyone.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
