[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Jan Včelák  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed|2016-05-05 08:33:51 |2016-05-23 07:32:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455



--- Comment #10 from Fedora Update System  ---
knot-resolver-1.0.0-0.3.4f463d7.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455



--- Comment #9 from Fedora Update System  ---
knot-resolver-1.0.0-0.3.4f463d7.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455



--- Comment #8 from Fedora Update System  ---
knot-resolver-1.0.0-0.3.4f463d7.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-efe8c69614

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #7 from Fedora Update System  ---
knot-resolver-1.0.0-0.3.4f463d7.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-436db6426f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Jan Včelák  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-05-05 08:33:51



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455



--- Comment #6 from Fedora Update System  ---
knot-resolver-1.0.0-0.3.4f463d7.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-436db6426f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455



--- Comment #5 from Fedora Update System  ---
knot-resolver-1.0.0-0.3.4f463d7.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-efe8c69614

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/knot-resolver

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Tomas Hozza  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(tho...@redhat.com |
   |)   |



--- Comment #3 from Tomas Hozza  ---
(In reply to Jan Včelák from comment #2)
> Thank you. Updated.
> 
> Spec URL:
> https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot-
> resolver.spec
> SRPM URL:
> https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot-
> resolver-1.0.0-0.2.79a8440.fc23.src.rpm
> 
> 
> (In reply to Tomas Hozza from comment #1)
> > - Package does not contain duplicates in %files.
> >   Note: warning: File listed twice: /var/lib/kresd/root.keys
> >   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
> 
> Fixed.
>  
> > - Packages should try to preserve timestamps of original installed
> >   files.
> 
> Fixed.
>
> > - Files outside of /usr SHOULD be owned by root:root
> >   (https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)
> 
> I've changed UID to root where possible. And kept GID to kresd where
> necessary. Files inside /var/lib are state information and have to be
> writable by the daemon.
> 
> > - Fully versioned dependency in subpackages if applicable.
> >   Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in knot-
> >   resolver-devel
> 
> Fixed.
> 
> > - Once you resolve issues with building the documentation, please package is
> >   as well, because currently there is no man page for the daemon.
> 
> The documentation building can't be fixed easily. The RTD theme cannot be
> loaded by Python 2 Sphinx on Fedora, and Breathe is incompatible with Python
> 3.
> 
> I've updated the package to current git master because some of the building
> issues were resolved. The manual page is now installed. And unit tests
> results are temporarily ignored (one failure is present and should be fixed
> in the gold release).

Thank you for resolving the issues.

The package is APPROVED for Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Jan Včelák  changed:

   What|Removed |Added

  Flags|needinfo?(jv+fedora@fcelda. |needinfo?(tho...@redhat.com
   |cz) |)



--- Comment #2 from Jan Včelák  ---
Thank you. Updated.

Spec URL:
https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot-resolver.spec
SRPM URL:
https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot-resolver-1.0.0-0.2.79a8440.fc23.src.rpm


(In reply to Tomas Hozza from comment #1)
> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice: /var/lib/kresd/root.keys
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

Fixed.

> - Packages should try to preserve timestamps of original installed
>   files.

Fixed.

> - Files outside of /usr SHOULD be owned by root:root
>   (https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)

I've changed UID to root where possible. And kept GID to kresd where necessary.
Files inside /var/lib are state information and have to be writable by the
daemon.

> - Fully versioned dependency in subpackages if applicable.
>   Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in knot-
>   resolver-devel

Fixed.

> - Once you resolve issues with building the documentation, please package is
>   as well, because currently there is no man page for the daemon.

The documentation building can't be fixed easily. The RTD theme cannot be
loaded by Python 2 Sphinx on Fedora, and Breathe is incompatible with Python 3.

I've updated the package to current git master because some of the building
issues were resolved. The manual page is now installed. And unit tests results
are temporarily ignored (one failure is present and should be fixed in the gold
release).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Tomas Hozza  changed:

   What|Removed |Added

 CC||jv+fed...@fcelda.cz
  Flags||needinfo?(jv+fedora@fcelda.
   ||cz)



--- Comment #1 from Tomas Hozza  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /var/lib/kresd/root.keys
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

  - I think this is because %files section contains line:
  %attr(755,kresd,kresd) %{_sharedstatedir}/kresd
  but should instead contain
  %attr(755,kresd,kresd) %dir %{_sharedstatedir}/kresd


- Packages should try to preserve timestamps of original installed
  files.

  - Consider using "-p" option when calling install command


- Files outside of /usr SHOULD be owned by root:root
  (https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)

  - Please explain why is UID and GID of files and dirs in /etc and /var/lib/
  set to kresd. Usually other DNS daemons have files installed in these
locations
  with UID root and GID specific to that daemon. Please consider changing the
  UID of files and directories to root.


- Fully versioned dependency in subpackages if applicable.
  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in knot-
  resolver-devel

  - %{?isa} is used instead of %{?_isa}. Please fix this.


- Once you resolve issues with building the documentation, please package is
  as well, because currently there is no man page for the daemon.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
 - This is OK, since these are just modules not in ld path!
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or
 generated", "*No copyright* MIT/X11 (BSD like)". 66 files have unknown
 license. Detailed output of licensecheck in /home/thozza/tmp/1321455
 -knot-resolver/licensecheck.txt
 - This is OK, since these are pieces of code with less strict license
 as GPLv3. Most of them are from CCAN repository.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
 - Not using -Wp, but it is justified.
[x]: Package contains no bundled libraries without FPC exception.
 - Only small snippets from CCAN are included, these are not and can not
 be packaged as separate software in Fedora. Direct use of the code is
expected.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
 - %{alphatag} macro could be used also in Release, since it is used
 in Source0
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build 

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Tomas Hozza  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|tho...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review