[Bug 1323871] Review Request: phonon-qt5-gstreamer - Gstreamer phonon-qt5 backend

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323871

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from Rex Dieter  ---
SPEC Url:
https://rdieter.fedorapeople.org/rpms/phonon-qt5/phonon-qt5-backend-gstreamer.spec

SRPM Url:
https://rdieter.fedorapeople.org/rpms/phonon-qt5/phonon-qt5-backend-gstreamer-4.8.2-2.fc24.src.rpm


%changelog
* Wed Apr 06 2016 Rex Dieter  - 4.8.2-2
- rename phonon-backend-gstreamer => phonon-qt5-backend-gstreamer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323871] Review Request: phonon-qt5-gstreamer - Gstreamer phonon-qt5 backend

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323871



--- Comment #2 from William Moreno  ---
Package Review
==

1- Package installs properly.
   Note: Installation errors (see attachment)
   See: https://fedoraproject.org/wiki/Packaging:Guidelines
   [!]: Rpmlint is run on all installed packages.
   I know this is intended to be a epel only package

2- Spec file name must match the spec package %{name}, in the format
   %{name}.spec.
   There is a package phonon-backend-gstreamer in Fedora, if this is a epel
only package there will be no conflic but remane the package to se same name
please.
   https://admin.fedoraproject.org/pkgdb/package/rpms/phonon-backend-gstreamer/
   [!]: Package does not generate any conflict.
   [!]: Spec file according to URL is the same as in SRPM.
   phonon-backend-gstreamer.src: E: invalid-spec-name

= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check 

[Bug 1323871] Review Request: phonon-qt5-gstreamer - Gstreamer phonon-qt5 backend

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323871

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323871] Review Request: phonon-qt5-gstreamer - Gstreamer phonon-qt5 backend

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323871



--- Comment #1 from Rex Dieter  ---
Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=13557028

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323871] Review Request: phonon-qt5-gstreamer - Gstreamer phonon-qt5 backend

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323871

Rex Dieter  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews),
   ||928937 (qt-reviews)
 Depends On||1320725 (phonon-qt5)
  Alias||phonon-qt5-gstreamer




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1320725
[Bug 1320725] Review Request: phonon-qt5 - Multimedia framework api (Qt 5
version)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org