[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #17 from Fedora Update System --- keepassx2-2.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #16 from Fedora Update System --- keepassx2-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-06-24 17:16:53 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #15 from Fedora Update System --- keepassx2-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ffae356c46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- keepassx2-2.0.2-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-885487040d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #13 from Fedora Update System --- keepassx2-2.0.2-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-885487040d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #12 from Jon Ciesla --- Not building on el6, working on it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #11 from Fedora Update System --- keepassx2-2.0.2-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ffae356c46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 Mukundan Ragavan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Mukundan Ragavan --- I don't have any further problems. Thanks for submitting the review. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #9 from Jon Ciesla --- Sorry, got busy. I've added desktop-file-validate and fixed the dupes. SRPM: https://fedorapeople.org/~limb/review/keepassx2/keepassx2-2.0.2-2.fc25.src.rpm SPEC: https://fedorapeople.org/~limb/review/keepassx2/keepassx2.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #8 from Mukundan Ragavan --- ping ... Any issues here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875
--- Comment #7 from Mukundan Ragavan ---
Just these two issues as mentioned earlier -
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
---> This can be ignored. Local issue.
- Package does not contain duplicates in %files.
Note: warning: File listed twice:
/usr/share/keepassx2/translations/keepassx_cs.qm
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
---> I think this is because of %{_datadir}/keepassx2 and correct usage of
%find_lang macro.
The %files section could be more descriptive to avoid these clashes.
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
---> Yes, this does seem to be missing (not present in post or posttrans).
Please fix this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #6 from Mukundan Ragavan --- (In reply to srakitnican from comment #5) > If I understood correctly, fedora would get 2.0 by default from now on, and > no 0.4 version. I am ok with that. That's my understanding as well. I will review this with epel-7 and post again. The minor issues that cropped up should be the same in epel as well but I'll check anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #5 from srakitnican --- If I understood correctly, fedora would get 2.0 by default from now on, and no 0.4 version. I am ok with that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #4 from Jon Ciesla --- Sorry, see: https://fedorahosted.org/fesco/ticket/1569 This will likely end up being EPEL-only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 --- Comment #3 from Mukundan Ragavan --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875
--- Comment #2 from Mukundan Ragavan ---
Sorry for the delay. Mostly minor issues. Can be fixed easily.
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
---> This can be ignored. Local issue.
- Package does not contain duplicates in %files.
Note: warning: File listed twice:
/usr/share/keepassx2/translations/keepassx_cs.qm
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
---> I think this is because of %{_datadir}/keepassx2 and correct usage of
%find_lang macro.
The %files section could be more descriptive to avoid these clashes.
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
---> Yes, this does seem to be missing (not present in post or posttrans).
Please fix this.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or v3)", "LGPL (v2.1 or v3)", "LGPL (v2.1)", "Unknown
or generated". 13 files have unknown license. Detailed output of
licensecheck in
/home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1326875-keepassx2/licensecheck.txt
---> Nothing seems bad.
[x]: License file installed when any subpackage combination is installed.
[?]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/keepassx2
---> This is perhaps easily fixed.
This - %{_libdir}/keepassx2/libkeepassx*.so - could be changed to
%{_libdir}/keepassx2/*
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/keepassx2,
/usr/share/mime, /usr/share/mimelnk/application, /usr/share/mimelnk,
/usr/share/mime/packages
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor/16x16/mimetypes(hicolor-icon-theme,
keepassx), /usr/share/icons/hicolor/16x16/actions(hicolor-icon-theme,
keepassx), /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme,
fedora-logos, keepassx), /usr/share/icons/hicolor/24x24/apps(hicolor-
icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/24x24
(hicolor-icon-theme, fedora-logos, keepassx),
/usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme, keepassx),
/usr/share/icons/hicolor/128x128/mimetypes(hicolor-icon-theme,
keepassx), /usr/share/icons/hicolor/64x64(hicolor-icon-theme,
keepassx), /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme,
fedora-logos, keepassx), /usr/share/icons/hicolor/64x64/mimetypes
(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/16x16
(hicolor-icon-theme, fedora-logos, keepassx),
/usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos,
keepassx, nedit), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-
theme, fedora-logos, keepassx), /usr/share/icons/hicolor/22x22/actions
(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/128x128
(hicolor-icon-theme, keepassx),
/usr/share/icons/hicolor/22x22/mimetypes(hicolor-icon-theme,
keepassx), /usr/share/icons/hicolor/32x32(hicolor-icon-theme, fedora-
logos, keepassx), /usr/share/icons/hicolor/256x256(hicolor-icon-theme,
fedora-logos, keepassx), /usr/share/icons/hicolor/16x16/apps(hicolor-
icon-theme, fedora-logos, keepassx),
/usr/share/icons/hicolor/64x64/apps(hicolor-icon-theme, keepassx),
/usr/share/icons/hicolor/22x22(hicolor-icon-theme, fedora-logos,
keepassx), /usr/share/icons/hicolor/22x22/status(hicolor-icon-theme,
keepassx), /usr/share/icons/hicolor/48x48(hicolor-icon-theme, fedora-
logos, keepassx, nedit), /usr/share/icons/hicolor/32x32/mimetypes
(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/scalable
(hicolor-icon-theme, fedora-logos, keepassx)
---> This can also be easily fixed, probably.
Change %{_datadir}/icons/hicolor/* ---> %{_datadir}/icons/hicolor/*/*/*
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed fo
[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1326875 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? --- Comment #1 from Mukundan Ragavan --- I will take this up for review since I use this everyday. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
