[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041 --- Comment #9 from MartinKG --- I will retire musicqueue from git, because the developer of musicqueue has stopped development and the developer of guayadeque has resumed development after a year of abstinence. :-( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041 MartinKG changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2016-05-06 11:56:11 --- Comment #8 from MartinKG --- package has been built successfully on fc24 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041 --- Comment #7 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/musicqueue -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041 --- Comment #6 from MartinKG --- @Antonio Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041 Antonio Trande changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Antonio Trande --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041
--- Comment #4 from MartinKG ---
(In reply to Antonio Trande from comment #3)
>
> = Issues =
>
> - appdata file is still not ready: note ,
> tags.
> https://fedoraproject.org/wiki/Packaging:AppData
>
done
> - Obsoletes: guayadeque <= 0.3.7-14
> Provides: guayadeque = %{version}-%{release}
>
> This package does not provide 'guayadeque'.
done
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/musicqueue.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/musicqueue-0.4.6-2.gitd2d8824.fc24.src.rpm
%changelog
* Tue May 03 2016 Martin Gansser -
0.4.6-2.gitd2d8824
- corrected license tag in %%{name}.appdata.xml file
- dropped Provides tag
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041
--- Comment #3 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= Issues =
- appdata file is still not ready: note , tags.
https://fedoraproject.org/wiki/Packaging:AppData
- Obsoletes: guayadeque <= 0.3.7-14
Provides: guayadeque = %{version}-%{release}
This package does not provide 'guayadeque'.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "GPL (v3 or
later)", "Unknown or generated". 219 files have unknown license.
Detailed output of licensecheck in
/home/sagitter/FedoraReview/1328041-musicqueue/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in musicqueue
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: F
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041
--- Comment #2 from MartinKG ---
(In reply to Antonio Trande from comment #1)
>
> = Issues =
>
> - Compile involves code released under BSD license (src/hmac) and
> LGPLv2+ (src/ApeTag.cpp src/ApeTag.h src/TagInfo.cpp src/TagInfo.h).
done
> - Default compiler flags are not honored with 'c++', only with 'cc'.
> See build log.
>
done
> - appdata file is not edited according to the Fedora guidelines and points to
> screenshot from different operating systems.
> See https://fedoraproject.org/wiki/Packaging:AppData
>
added patch, if this is ok, i will forward the patch to upstream.
> - Your package does not install icons into one of the subdirectories in
> %{_datadir}/icons/; scriptlets are useless.
> https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:
> ScriptletSnippets#Icon_Cache
>
done
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/musicqueue.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/musicqueue-0.4.6-1.gitd2d8824.fc24.src.rpm
%changelog
* Tue May 03 2016 Martin Gansser -
0.4.6-1.gitd2d8824
- updat to 0.4.6
- added license BSD and LGPLv2+ to license tag
- added -DCMAKE_C_FLAGS="%%{optflags}"
- added %%{name}-appdata.patch
- dropped scriptlets for installing %%{_datadir}/icons/
- spec file cleanup
rpmlint:
Checking: musicqueue-0.4.6-1.gitd2d8824.fc25.x86_64.rpm
musicqueue-debuginfo-0.4.6-1.gitd2d8824.fc25.x86_64.rpm
musicqueue-0.4.6-1.gitd2d8824.fc25.src.rpm
musicqueue.x86_64: W: spelling-error Summary(en_US) orgainizer -> organizer,
organize
musicqueue.x86_64: W: spelling-error %description -l en_US orgainizer ->
organizer, organize
musicqueue.x86_64: W: spelling-error %description -l en_US revison -> revision
musicqueue.x86_64: W: spelling-error %description -l en_US podcasts -> podcast,
pod casts, pod-casts
musicqueue.x86_64: W: no-manual-page-for-binary musicqueue
musicqueue.src: W: spelling-error Summary(en_US) orgainizer -> organizer,
organize
musicqueue.src: W: spelling-error %description -l en_US orgainizer ->
organizer, organize
musicqueue.src: W: spelling-error %description -l en_US revison -> revision
musicqueue.src: W: spelling-error %description -l en_US podcasts -> podcast,
pod casts, pod-casts
musicqueue.src:29: W: unversioned-explicit-provides bundled(md5-polstra)
3 packages and 0 specfiles checked; 0 errors, 10 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041
--- Comment #1 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= Issues =
- Compile involves code released under BSD license (src/hmac) and
LGPLv2+ (src/ApeTag.cpp src/ApeTag.h src/TagInfo.cpp src/TagInfo.h).
- Default compiler flags are not honored with 'c++', only with 'cc'.
See build log.
- appdata file is not edited according to the Fedora guidelines and points to
screenshot from different operating systems.
See https://fedoraproject.org/wiki/Packaging:AppData
- Your package does not install icons into one of the subdirectories in
%{_datadir}/icons/; scriptlets are useless.
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD
like)", "*No copyright* Public domain", "BSD (3 clause)", "LGPL (v2.1
or later)". 217 files have unknown license. Detailed output of
licensecheck in
/home/sagitter/FedoraReview/1328041-musicqueue/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in musicqueue
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File name
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1328041] Review Request: musicqueue - Music orgainizer and player based on a fork of Guayadeque
https://bugzilla.redhat.com/show_bug.cgi?id=1328041 MartinKG changed: What|Removed |Added URL||https://gitlab.com/digifuzz ||y/musicqueue Alias||musicqueue -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
