[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2020-05-19 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Fabian Affolter  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||m...@fabian-affolter.ch
 Resolution|--- |RAWHIDE
Last Closed||2020-05-19 10:42:15




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-26 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #30 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pysword

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #29 from Robert-André Mauchin  ---
Ok, package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #28 from TR Bentley  ---
https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm
https://trb143.fedorapeople.org/python-pysword.spec

Next attempt.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #27 from Robert-André Mauchin  ---
-n %{srcname}-%{version} indicates the directory to change to before -b 1
extract the second sources, thus it needs to be the same as the previous
directory in order to be extracted in the correct directory. It doesn't have to
do with the zip file structure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #26 from TR Bentley  ---
%autosetup -N -T -D -b 1 -n %{srcname}-%{version}

This is correct as this tar.gz only contains the test files which Koji is
unable to download.  These are not version controlled.
If this is the case I would need to modify the zip file each time I run as
these files are not in the upstream git repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #25 from Robert-André Mauchin  ---
You need to add commit to the second autosetup, otherwise it won't extract to
the right directory:

%autosetup -n %{srcname}-%{version}-%{commit}
%autosetup -N -T -D -b 1 -n %{srcname}-%{version}-%{commit}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #24 from TR Bentley  ---
Ah got it now, I think

https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm

https://trb143.fedorapeople.org/python-pysword.spec

I build the tar from git clone, not the archive download which is why we had
the missing commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-24 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #23 from Robert-André Mauchin  ---
When I download
https://gitlab.com/tgc-dk/%{srcname}/repository/archive.tar.gz?ref=%{version}#/%{srcname}-%{version}.tar.gz,
the root folder of the archive I get is named %{srcname}-%{version}-%{commit},
not %{srcname}-%{version}.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-24 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #22 from TR Bentley  ---
https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm

https://trb143.fedorapeople.org/python-pysword.spec

Rebuilt from scratch using fedpkg.

Unable to find any reference  to {commit}

if this is still wrong what commands are you using to test so I can test my
self.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #21 from Robert-André Mauchin  ---
You didn't fix this:


 - Build error:

+ cd pysword-0.2.5
BUILDSTDERR: /var/tmp/rpm-tmp.if9CI4: line 40: cd: pysword-0.2.5: No such file
or directory

   Seems the directory in the archive is suffixed by the commit hash:

%prep
%autosetup -n %{srcname}-%{version}-%{commit}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #20 from TR Bentley  ---
https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm
https://trb143.fedorapeople.org/python-pysword.spec

Tried to fix the issues identified above.
Not sure the test file is correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #19 from Robert-André Mauchin  ---
You don't need \ at the end of the line if you use %{expand:

 - Build error:

+ cd pysword-0.2.4
BUILDSTDERR: /var/tmp/rpm-tmp.if9CI4: line 40: cd: pysword-0.2.4: No such file
or directory

   Seems the directory is suffixed by the commit hash:

%prep
%autosetup -n %{srcname}-%{version}-%{commit}


 - Date is incorrect in %changelog:

* Sun Mar 17 2018 

   Should be: Sat Mar 17

 - Tests fail

BUILDSTDERR:
==
BUILDSTDERR: ERROR: test_load_bsv_zip (tests.test_files.TestModules)
BUILDSTDERR:
--
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/test_files.py",
line 78, in test_load_bsv_zip
BUILDSTDERR: found_modules = modules.parse_modules()
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/pysword/modules.py",
line 83, in parse_modules
BUILDSTDERR: zipped_module = zipfile.ZipFile(self._sword_path)
BUILDSTDERR:   File "/usr/lib64/python3.6/zipfile.py", line 1090, in __init__
BUILDSTDERR: self.fp = io.open(file, filemode)
BUILDSTDERR: FileNotFoundError: [Errno 2] No such file or directory:
'/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/resources/bsv.zip'
BUILDSTDERR:
==
BUILDSTDERR: ERROR: test_load_chipinyin_zip (tests.test_files.TestModules)
BUILDSTDERR:
--
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/test_files.py",
line 60, in test_load_chipinyin_zip
BUILDSTDERR: found_modules = modules.parse_modules()
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/pysword/modules.py",
line 83, in parse_modules
BUILDSTDERR: zipped_module = zipfile.ZipFile(self._sword_path)
BUILDSTDERR:   File "/usr/lib64/python3.6/zipfile.py", line 1090, in __init__
BUILDSTDERR: self.fp = io.open(file, filemode)
BUILDSTDERR: FileNotFoundError: [Errno 2] No such file or directory:
'/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/resources/chipinyin.zip'
BUILDSTDERR:
==
BUILDSTDERR: ERROR: test_load_finpr_zip (tests.test_files.TestModules)
BUILDSTDERR:
--
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/test_files.py",
line 42, in test_load_finpr_zip
BUILDSTDERR: found_modules = modules.parse_modules()
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/pysword/modules.py",
line 83, in parse_modules
BUILDSTDERR: zipped_module = zipfile.ZipFile(self._sword_path)
BUILDSTDERR:   File "/usr/lib64/python3.6/zipfile.py", line 1090, in __init__
BUILDSTDERR: self.fp = io.open(file, filemode)
BUILDSTDERR: FileNotFoundError: [Errno 2] No such file or directory:
'/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/resources/FinPR.zip'
BUILDSTDERR:
==
BUILDSTDERR: ERROR: test_parse_modules_folder
(tests.test_swordModules.TestSwordModules)
BUILDSTDERR:
--
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/test_swordModules.py",
line 41, in test_parse_modules_folder
BUILDSTDERR: mods_metadata = modules.parse_modules()
BUILDSTDERR:   File
"/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/pysword/modules.py",
line 89, in parse_modules
BUILDSTDERR: for f in os.listdir(conf_folder):
BUILDSTDERR: FileNotFoundError: [Errno 2] No such file or directory:
'/builddir/build/BUILD/pysword-0.2.4-46d3425a888c0667e726f6e0c7e2031daef81251/tests/resources/mods.d'
BUILDSTDERR:
==
BUILDSTDERR: ERROR: test_parse_modules_zip
(tests.test_swordModules.TestSwordModules)
BUILDSTDERR:

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #18 from TR Bentley  ---
https://trb143.fedorapeople.org/python-pysword-0.2.4-1.fc27.src.rpm

https://trb143.fedorapeople.org/python-pysword.spec

Should have fixed the desc issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #17 from Robert-André Mauchin  ---
%description -n python3-%{srcname}
%{desc}

desc must be defined beforehand, otherwise this macro is empty. For example, in
the header you define it:

%global desc %{expand:
A native Python reader of the SWORD Project Bible Modules.
Reads SWORD bible files (not commentaries etc.)
Detection of locally installed Swrod bible modules.
Supports all known SWORD module formats (ztext, ztext4, rawtext, rawtext4)
Read from zipped modules, like those available from
http://www.crosswire.org/sword/modules/ModDisp.jsp?modType=Bibles
Cleans the extracted text of OSIS, GBF or ThML tags.
Supports both python 2 and 3 (tested with 2.7 and 3.5).}

   Then you reuse it twice:


%description
%{desc}

%package -n python3-%{srcname}
Summary:%{sum}
%{?python_provide:%python_provide python3-%{srcname}}

%description -n python3-%{srcname}
%{desc}


I'm busy right now, I'll look at it this evening or tonight, looks good
otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #16 from TR Bentley  ---
Revised based on the previous comments.

https://trb143.fedorapeople.org/python-pysword-0.2.4-1.fc27.src.rpm

https://trb143.fedorapeople.org/python-pysword.spec

Thanks for the pointers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-12 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #15 from Robert-André Mauchin  ---
(In reply to TR Bentley from comment #13)
> I only want a python3 version.
> Do you have an example of a spec file as I am very confused as this is based
> on other packages I have found.

As Itamar said or look at
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file Just
don't add the python2 subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-11 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Itamar Reis Peixoto  changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br



--- Comment #14 from Itamar Reis Peixoto  ---
(In reply to TR Bentley from comment #13)
> I only want a python3 version.

I recommend you to move %description to %global desc x \  \ 

and use

%description
%{desc}

%package -n python3-pysword
Summary: %{sum}



%description -n python3-pysword
%{desc}

%files -n python3-pysword

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-11 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #13 from TR Bentley  ---
I only want a python3 version.
Do you have an example of a spec file as I am very confused as this is based on
other packages I have found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-11 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #12 from Robert-André Mauchin  ---
You should provide Python 2 and Python 3 versions. If you only provide Python 3
you should still make a Python 3 subpackage to the main one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-03-11 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #11 from TR Bentley  ---
https://trb143.fedorapeople.org/python-pysword.spec

https://trb143.fedorapeople.org/python-pysword-0.2.4-1.fc27.src.rpm

New 0.2.4 release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-02-13 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #10 from TR Bentley  ---
https://trb143.fedorapeople.org/python-pysword-0.2.3-1.fc27.src.rpm

https://trb143.fedorapeople.org/python-pysword.spec

Sorry wrong files uploaded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-02-13 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #9 from Robert-André Mauchin  ---
%{__python3} setup.py build → %py3_build
%{__python3} setup.py install --skip-build -O1 --root %{buildroot} →
%py3_install


Also you should provide packages for both python2 and python3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2018-02-13 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #8 from TR Bentley  ---
Another set of updates 

https://trb143.fedorapeople.org/python-pysword.spec

https://trb143.fedorapeople.org/python-pysword-0.2.3-0.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2017-10-04 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #7 from Robert-André Mauchin  ---
Hello,

 - Group: and Buildroot: are not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - %clean is not needed either. Nor is rm -rf %{buildroot} in %install.

 - This is wrong:

%global srcname python-pysword

  It should be:

%global srcname pysword

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2017-02-22 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

kaiwang  changed:

   What|Removed |Added

 CC||kaiw...@redhat.com



--- Comment #6 from kaiwang  ---
*This is un-official review of the package.*

`rpmlint -iv *.rpm` gives two errors

..
python-pysword.noarch: I: checking-url https://gitlab.com/tgc-dk/pysword
(timeout 10 seconds)
python-pysword.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/pysword/canon-parser.py /usr/bin/env python3

python-pysword.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/pysword/canon-parser.py 644 /usr/bin/env
python3
..

python-pysword.src: W: invalid-url Source0:
https://gitlab.com/tgc-dk/python-pysword/repository/archive.tar.gz?ref=0.2.3#/python-pysword-0.2.3.tar.gz
HTTP Error 401: Unauthorized
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1) change shebang '/usr/bin/env python3' to '/usr/bin/python3'
2) You may should add 'chmod a+x canon-parser.py' after %setup command.
3) the 'Source0' tag has authentication problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2017-01-07 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #5 from TR Bentley  ---
Update files as per review comments a uploaded a revised version.

https://trb143.fedorapeople.org/python-pysword-0.2.3-0.fc25.src.rpm
https://trb143.fedorapeople.org/python-pysword.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2017-01-06 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Filip Szymański  changed:

   What|Removed |Added

 CC||fszyman...@onet.pl



--- Comment #4 from Filip Szymański  ---
1) Rename the spec file to python-pysword.spec

2) You only need these two globals:

%global srcname pysword
%global commit 50a1b1a526e5d6511555c458df754498aaa3185f

3) Tags:

Version: 0.2.3
Source0:
https://gitlab.com/tgc-dk/%{srcname}/repository/archive.tar.gz?ref=%{version}#/%{srcname}-%{version}.tar.gz

4) Description expands upon summary.

5) Instead of `sum` macro use `summary`:

%package -n python3-%{srcname}
Summary:%{summary}
%{?python_provide:%python_provide python3-%{srcname}}

6) Prepare section:

%prep
%autosetup -n %{srcname}-%{version}-%{commit}

7) Missing doc and license file:

%files -n python3-%{srcname}
%license LICENSE
%doc README.rst
%{python3_sitelib}/*

8) Email address should be in `<>`.

See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2016-12-22 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #3 from TR Bentley  ---
Looking at the packaging again I can see errors.
The inital question is the upstream package is called pysword and that is how
it is built.  Should I package it as pysword or python3-pysword.

To move to python3-pysword I would need to rebuild a copy of the upstream
packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2016-11-13 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Drop %gittag0, just specify the version in Version.

You have python-pysword (the main src package), and python3-pysword (the only
binary package). So there should be just on summary. Put it in Summary, drop
%sum, and use Summary: %summary later on.

%description makes no sense.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

2016-11-13 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-pysword - Read Sword |python-pysword - Python
   |files from Python   |bindings to read Sword
   ||bible files directly



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org