[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

Tomas Repik  changed:

   What|Removed |Added

 Blocks|1324020 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
[Bug 1324020] Review Request: cassandra - OpenSource database Apache
Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #13 from Fedora Update System  ---
primitive-1.2.2-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-07 07:48:39



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
primitive-1.2.2-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-12700be6f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #11 from Fedora Update System  ---
primitive-1.2.2-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-12700be6f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/primitive

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #9 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/primitive-java/v2/primitive.spec
SRPM URL:
https://trepik.fedorapeople.org/primitive-java/v2/primitive-1.2.2-2.fc23.src.rpm

* Wed Apr 27 2016 Tomas Repik  - 1.2.2-2
- new patch for license headers

Thanks for the review! Adding this just to be clear, and documented.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from gil cattaneo  ---
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #7 from Tomas Repik  ---
(In reply to gil cattaneo from comment #6)
> Correct license
> > -License:   GPLv2 with exceptions

Yes you're right I got confused by the plus in: "All source files are licensed
under GPLv2+CE" in the LICENSE.txt file [1]

Here is once again the diff:

--- SPECS/old/primitive.spec2016-04-21 15:10:15.0 +0200
+++ SPECS/primitive.spec2016-04-26 12:10:57.854293972 +0200
@@ -2,13 +2,18 @@
 Version:   1.2.2
 Release:   2%{?dist}
 Summary:   Utility methods for Java's primitive types
+# DualPivotQuicksorts.java.ft is also Copyright 2009, 2015, Oracle and/or its 
+# affiliates.
+# TimSorts.java.ft is also Copyright 2009, 2013, Oracle and/or its affiliates,
+# and Copyright 2009 Google Inc.
+# GNU General Public License v2.0 or later, with Classpath exception
 License:   GPLv2 with exceptions
-URL:   https://github.com/mintern-java/primitive/
-Source0:  
https://github.com/mintern-java/primitive/archive/%{version}.tar.gz
+URL:   https://github.com/mintern-java/%{name}/
+Source0:  
https://github.com/mintern-java/%{name}/archive/%{version}.tar.gz
 # https://bugzilla.redhat.com/show_bug.cgi?id=1212672
 Source1:   fmpp.sh
 # https://github.com/mintern-java/primitive/issues/5
-Patch0:   
https://github.com/mintern-java/primitive/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch
+Patch0:   
https://github.com/mintern-java/%{name}/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch


[1] https://raw.githubusercontent.com/mintern-java/primitive/master/LICENSE.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #6 from gil cattaneo  ---
(In reply to Tomas Repik from comment #5)
> Is there anything else besides the license?
> 
> --- SPECS/old/primitive.spec  2016-04-21 15:10:15.0 +0200

Correct license
> -License:   GPLv2 with exceptions

Wrong license
> +License:   GPLv2+

> 
> BTW here is koji: 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=13793714

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #5 from Tomas Repik  ---
Is there anything else besides the license?

--- SPECS/old/primitive.spec2016-04-21 15:10:15.0 +0200
+++ SPECS/primitive.spec2016-04-25 10:53:13.436371607 +0200
@@ -2,13 +2,14 @@
 Version:   1.2.2
 Release:   2%{?dist}
 Summary:   Utility methods for Java's primitive types
-License:   GPLv2 with exceptions
-URL:   https://github.com/mintern-java/primitive/
-Source0:  
https://github.com/mintern-java/primitive/archive/%{version}.tar.gz
+# GNU General Public License v2.0 or later, with Classpath exception
+License:   GPLv2+
+URL:   https://github.com/mintern-java/%{name}/
+Source0:  
https://github.com/mintern-java/%{name}/archive/%{version}.tar.gz
 # https://bugzilla.redhat.com/show_bug.cgi?id=1212672
 Source1:   fmpp.sh
 # https://github.com/mintern-java/primitive/issues/5
-Patch0:   
https://github.com/mintern-java/primitive/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch
+Patch0:   
https://github.com/mintern-java/%{name}/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch

 BuildRequires: maven-local

BTW here is koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=13793714

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #4 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL". Detailed output of licensecheck in
 /home/gil/1329201-primitive/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
 Note: Using prebuilt rpms.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[!]: Reviewer should test that the package 

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #3 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/primitive-java/v1/primitive.spec
SRPM URL:
https://trepik.fedorapeople.org/primitive-java/v1/primitive-1.2.2-2.fc23.src.rpm

* Thu Apr 21 2016 Tomas Repik  - 1.2.2-2
- new patch for license headers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #2 from gil cattaneo  ---
can you take these for me?
https://bugzilla.redhat.com/show_bug.cgi?id=1328062
https://bugzilla.redhat.com/show_bug.cgi?id=1328063

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
Please, use:
https://github.com/mintern-java/primitive/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201

Tomas Repik  changed:

   What|Removed |Added

 Blocks||1324020, 652183
   ||(FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1324020
[Bug 1324020] Review Request: cassandra - OpenSource database Apache
Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org