[Bug 1329807] Review Request: raqm - Complex Textlayout Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329807



--- Comment #4 from Mosaab Alzoubi  ---
Spec URL: http://pastebin.com/raw/AXqVRH7a
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-rawhide-x86_64/00180750-libraqm/libraqm-0.1.0-3.fc25.src.rpm

Yes libraqm's better, no applications in main package (pure lib)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329807] Review Request: raqm - Complex Textlayout Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329807



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
-devel must require specific version: raqm%{?_isa} = %{version}-%{release}

Wouldn't it be better to call this package libraqm? Upstream uses both
"libraqm" and "raqm" in various places. That's the package name in arch linux,
and consistency with other distributions is useful for users. Also it's a
library, so "lib" prefix is helpful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329807] Review Request: raqm - Complex Textlayout Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329807



--- Comment #2 from Mosaab Alzoubi  ---
Spec URL: http://pastebin.com/raw/q8Ycfukd
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-23-x86_64/00180558-raqm/raqm-0.1.0-2.fc23.src.rpm

Everything's OK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329807] Review Request: raqm - Complex Textlayout Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329807

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
raqm.src: E: description-line-too-long C Library that encapsulates the logic
for complex text layout and provide a convenient API.

Also "provides" not "provide".

raqm-devel.x86_64: W: no-dependency-on raqm/raqm-libs/libraqm

raqm-devel.x86_64: E: non-devel-file-in-devel-package
/usr/lib64/libraqm.so.0.0.0
raqm-devel.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libraqm.so.0.0.0
raqm-devel.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libraqm.so.0.0.0
→ .so should be in -devel, .so.* in the main package.

%license should be used for the license file.

No %check? Upstream README says that there are unit tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329807] Review Request: raqm - Complex Textlayout Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329807

Mosaab Alzoubi  changed:

   What|Removed |Added

 Blocks||1329817




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329817
[Bug 1329817] Enable complex textlayout on ImageMagick
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org