https://bugzilla.redhat.com/show_bug.cgi?id=1330330
Michael Scherer changed:
What|Removed |Added
CC||m...@zarb.org
QA Contact|extras...@fedoraproject.org |m...@zarb.org
--- Comment #1 from Michael Scherer ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- why is there a git config call in %check ?
- unowned directories, see review
- package is wrongly named (see
https://fedoraproject.org/wiki/PackagingDrafts/Go#Package_Names for a example)
- see rpmlint for spelling errors
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "MIT/X11 (BSD like)", "Unknown or generated",
"BSD (2 clause)". 48 files have unknown license. Detailed output of
licensecheck in /home/misc/checkout/git/FedoraReview/1330330-golang-
tools-godep/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com/kr,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com/pmezard,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com/pmezard
/go-difflib,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org/x/tools,
/usr/share/gocode/src/github.com/tools/godep/Godeps,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org/x/tools/go,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org/x
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com/kr,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org/x/tools,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com,
/usr/share/gocode/src/github.com/tools/godep/Godeps,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org/x/tools/go,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/golang.org/x,
/usr/share/gocode, /usr/share/gocode/src/github.com,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com/pmezard,
/usr/share/gocode/src,
/usr/share/gocode/src/github.com/tools/godep/Godeps/_workspace/src/github.com/pmezard
/go-difflib
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/tools(godep-devel),
/usr/share/gocode/src/github.com/tools/godep(godep-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[!]: Package c
