[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Sascha Spreitzer  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-06-21 13:31:24



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/numix-icon-theme

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #11 from Sascha Spreitzer  ---
Updated spec at spec url

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #10 from Simone Caronni  ---
Sorry, just noticed, "filesystem" is missing as requirement as specified in
comment #3. Just add it after committing in the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Simone Caronni  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Simone Caronni  ---
All requests have been satisfied, package approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #8 from Sascha Spreitzer  ---
Updates based on sponsor guidance

Spec URL:
https://raw.githubusercontent.com/sspreitzer/numix-specs/development/numix-icon-theme.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/3074/14473074/numix-icon-theme-0.1.0-10.git101307f.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Simone Caronni  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Simone Caronni  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #7 from Simone Caronni  ---
Sponsoring user, no longer requiring a sponsor:

https://fedorahosted.org/packager-sponsors/ticket/275

Thanks to everyone involved.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #6 from Simone Caronni  ---
You can also replace some more "numix-icon-theme" with "%{name}" in the Source
directives, but this is up to you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #5 from Simone Caronni  ---
> numix-icon-theme.src: E: description-line-too-long C It is heavily inspired 
> by,
> and based upon parts of the Elementary, Humanity and Gnome icon themes

Please use new lines before/at 80 columns (...and complete the sentence with a
dot :D ).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #4 from Simone Caronni  ---
> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: Cannot find gnome-mime-text-x-copying.svg in rpm(s)
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

This message can be ignored, rpmlint is considering the SVG file as a license
file (due to the word copying).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #3 from Simone Caronni  ---
> - Dist tag is present.

Please use "%{?dist}" in place of "%{dist}" in the Release field.

> - gtk-update-icon-cache is invoked in %postun and %posttrans if package
>   contains icons.
>   Note: icons in numix-icon-theme

The icon cache generation is missing, please look at the following link:

https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache

Apply the examples exactly as they are, simply repeating the snippets for the
themes installed (Numix adn Numix-Light) in place of "hicolor".

> [!]: Changelog in prescribed format.
> numix-icon-theme.noarch: W: incoherent-version-in-changelog 0.1.0-8 
> ['0.1.0-8.git101307f.fc23', '0.1.0-8.git101307f']

You should have exactly the same name-version-release tags in the changelog as
the package that you are generating. That is, in this case: 0.1.0-8.git101307f

Please note that actually (next time) when you update the spec file with
"rpmdev-bumpspec" it will actually put the correct tag in the changelog as
required.

> [!]: Requires correct, justified where necessary.

The directory %{_datadir}/icons is not owned by your package, please add
"filesystem" as requirement. It's always installed, but better be safe than
sorry.

$ rpm -qf /usr/share/icons/
filesystem-3.2-37.fc24.x86_64



Also, if you're not planning to support RHEL 6 please remove the "Group:" tag
(not required but not mandatory to be removed).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #1 from Simone Caronni  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Dist tag is present.
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in numix-icon-theme
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: Cannot find gnome-mime-text-x-copying.svg in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 2 files have unknown license. Detailed
 output of licensecheck in /home/slaanesh/reviews/1330858-numix-icon-
 theme/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, 

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #2 from Simone Caronni  ---
Rpmlint
---
Checking: numix-icon-theme-0.1.0-8.git101307f.fc23.noarch.rpm
  numix-icon-theme-0.1.0-8.git101307f.fc23.src.rpm
numix-icon-theme.noarch: E: description-line-too-long C It is heavily inspired
by, and based upon parts of the Elementary, Humanity and Gnome icon themes
numix-icon-theme.noarch: W: incoherent-version-in-changelog 0.1.0-8
['0.1.0-8.git101307f.fc23', '0.1.0-8.git101307f']
numix-icon-theme.src: E: description-line-too-long C It is heavily inspired by,
and based upon parts of the Elementary, Humanity and Gnome icon themes
numix-icon-theme.src: W: no-%build-section
2 packages and 0 specfiles checked; 2 errors, 2 warnings.




Rpmlint (installed packages)

sh: /usr/bin/python: No such file or directory
numix-icon-theme.noarch: E: description-line-too-long C It is heavily inspired
by, and based upon parts of the Elementary, Humanity and Gnome icon themes
numix-icon-theme.noarch: W: incoherent-version-in-changelog 0.1.0-8
['0.1.0-8.git101307f.fc23', '0.1.0-8.git101307f']
1 packages and 0 specfiles checked; 1 errors, 1 warnings.



Requires

numix-icon-theme (rpmlib, GLIBC filtered):
gnome-icon-theme
hicolor-icon-theme



Provides

numix-icon-theme:
numix-icon-theme



Source checksums

https://github.com/numixproject/numix-icon-theme/archive/101307fba4bc10793d8a5a0afe3af48e5bd195ca.tar.gz#/numix-icon-theme-101307f.tar.gz
:
  CHECKSUM(SHA256) this package :
22cb378c060482f1812ca177a42936b4b499b5befb8c8921b1cbe02c861c773c
  CHECKSUM(SHA256) upstream package :
22cb378c060482f1812ca177a42936b4b499b5befb8c8921b1cbe02c861c773c


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1330858
Buildroot used: fedora-23-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Simone Caronni  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Sascha Spreitzer  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Sascha Spreitzer  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|negativ...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org