[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Sascha Spreitzer  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-06-21 13:32:11



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/numix-icon-theme-circle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861



--- Comment #8 from Sascha Spreitzer  ---
Updated spec at spec url

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Simone Caronni  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Simone Caronni  ---
Just noticed, "filesystem" is missing as requirement as specified in comment
#3. Just add it after committing in the repository. All other requests have
been satisfied, package approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861



--- Comment #6 from Sascha Spreitzer  ---
Updates based on sponsor guidance

Spec URL:
https://raw.githubusercontent.com/sspreitzer/numix-specs/development/numix-icon-theme-circle.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/3099/14473099/numix-icon-theme-circle-0.1.0-8.git475d649.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Simone Caronni  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Simone Caronni  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #5 from Simone Caronni  ---
Sponsoring user, no longer requiring a sponsor:

https://fedorahosted.org/packager-sponsors/ticket/275

Thanks to everyone involved.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861



--- Comment #4 from Simone Caronni  ---
Also, if you're not planning to support RHEL 6 please remove the "Group:" tag
(not required but not mandatory to be removed).

You can also replace some more "numix-icon-theme-circle" with "%{name}" in the
Source directives, but this is up to you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861



--- Comment #3 from Simone Caronni  ---
> - Dist tag is present.

Please use "%{?dist}" in place of "%{dist}" in the Release field.

> - gtk-update-icon-cache is invoked in %postun and %posttrans if package
>   contains icons.
>   Note: icons in numix-icon-theme-circle

The icon cache generation is missing, please look at the following link:

https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache

Apply the examples exactly as they are, simply repeating the snippets for the
themes installed (Numix-Circle adn Numix-Circle-Light) in place of "hicolor".

> [!]: Changelog in prescribed format.
> numix-icon-theme-circle.noarch: W: incoherent-version-in-changelog 0.1.0-7 
> ['0.1.0-7.git475d649.fc23', '0.1.0-7.git475d649']

You should have exactly the same name-version-release tags in the changelog as
the package that you are generating. That is, in this case: 0.1.0-7.git475d649

Please note that actually (next time) when you update the spec file with
"rpmdev-bumpspec" it will actually put the correct tag in the changelog as
required.

> [!]: Requires correct, justified where necessary.

The directory %{_datadir}/icons is not owned by your package, please add
"filesystem" as requirement. It's always installed, but better be safe than
sorry.

$ rpm -qf /usr/share/icons/
filesystem-3.2-37.fc24.x86_64

> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file license is marked as %doc instead of %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

> [!]: Spec file according to URL is the same as in SRPM.
>  Note: Spec file as given by url is not the same as in SRPM (see
>  attached diff).
>  See: (this test has no URL)

> Diff spec file in url and in SRPM
> -
> --- 
> /home/slaanesh/reviews/1330861-numix-icon-theme-circle/srpm/numix-icon-theme-circle.spec
>   2016-05-02 14:45:04.338709562 +0200
> +++ 
> /home/slaanesh/reviews/1330861-numix-icon-theme-circle/srpm-unpacked/numix-icon-theme-circle.spec
>  2016-04-19 21:23:03.0 +0200
> @@ -14,5 +14,4 @@
>  
>  BuildArch:   noarch
> -Requires:numix-icon-theme
>  
>  %description
> @@ -31,13 +30,9 @@
>  
>  %files
> -%license license
> -%doc readme.md
> +%doc license readme.md
>  %{_datadir}/icons/Numix-Circle
>  %{_datadir}/icons/Numix-Circle-Light
>  
>  %changelog
> -* Wed Apr 20 2016 Sascha Spreitzer  - 0.1.0-8
> -- license tag for license file, diffable lines
> -
>  * Tue Apr 19 2016 Sascha Spreitzer  - 0.1.0-7
>  - split spec file

This is due to the fact that you uploaded an udpated SPEC file without updating
the SRPM as well. When posting the new URLs for fixing the above comments,
please use 2 new lines ub a separate comment:

Spec URL:
SRPM URL:

fedora-review uses the latest entries it finds in each bugzilla review bug.

> numix-icon-theme-circle.noarch: E: description-line-too-long C It is heavily 
> inspired by, and based upon parts of the Elementary, Humanity and Gnome icon 
> themes

Please use new lines before/at 80 columns (...and complete the sentence with a
dot :D ).

> numix-icon-theme-circle.noarch: E: script-without-shebang 
> /usr/share/icons/Numix-Circle/48x48/apps/gerbv.svg
> [..etc..]

Please make sure all files in /usr/share are not executable. In this case they
should all be permission 644.

> numix-icon-theme-circle.noarch: W: dangling-relative-symlink 
> /usr/share/icons/Numix-Circle-Light/16x16/panel ../../Numix-Light/16/panel

These are all errors relative to the fact that the symlink points to a package
of numix-icon-theme. This is fine, but you need to add the requirements in the
package:

Requires: numix-icon-theme

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861



--- Comment #2 from Simone Caronni  ---
Rpmlint
---
Checking: numix-icon-theme-circle-0.1.0-7.git475d649.fc23.noarch.rpm
  numix-icon-theme-circle-0.1.0-7.git475d649.fc23.src.rpm
numix-icon-theme-circle.noarch: E: description-line-too-long C It is heavily
inspired by, and based upon parts of the Elementary, Humanity and Gnome icon
themes
numix-icon-theme-circle.noarch: W: incoherent-version-in-changelog 0.1.0-7
['0.1.0-7.git475d649.fc23', '0.1.0-7.git475d649']
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle-Light/24x24/panel ../../Numix-Light/24/panel
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/receitanet-ajuda.svg
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle-Light/22x22/panel ../../Numix-Light/22/panel
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/receitanet.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/gerbv.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/klayout.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/qtsixa.svg
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle-Light/16x16/panel ../../Numix-Light/16/panel
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/gv.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/jstest-gtk.svg
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle/16x16/panel ../../Numix/16/panel
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle/22x22/panel ../../Numix/22/panel
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/NoMachine-icon.svg
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle/24x24/panel ../../Numix/24/panel
numix-icon-theme-circle.src: E: description-line-too-long C It is heavily
inspired by, and based upon parts of the Elementary, Humanity and Gnome icon
themes
numix-icon-theme-circle.src: W: no-%build-section
2 packages and 0 specfiles checked; 10 errors, 8 warnings.




Rpmlint (installed packages)

sh: /usr/bin/python: No such file or directory
numix-icon-theme-circle.noarch: E: description-line-too-long C It is heavily
inspired by, and based upon parts of the Elementary, Humanity and Gnome icon
themes
numix-icon-theme-circle.noarch: W: incoherent-version-in-changelog 0.1.0-7
['0.1.0-7.git475d649.fc23', '0.1.0-7.git475d649']
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/klayout.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/receitanet.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/jstest-gtk.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/receitanet-ajuda.svg
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle-Light/16x16/panel ../../Numix-Light/16/panel
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle/16x16/panel ../../Numix/16/panel
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle-Light/24x24/panel ../../Numix-Light/24/panel
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/gv.svg
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/NoMachine-icon.svg
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle/24x24/panel ../../Numix/24/panel
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/qtsixa.svg
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle-Light/22x22/panel ../../Numix-Light/22/panel
numix-icon-theme-circle.noarch: W: dangling-relative-symlink
/usr/share/icons/Numix-Circle/22x22/panel ../../Numix/22/panel
numix-icon-theme-circle.noarch: E: script-without-shebang
/usr/share/icons/Numix-Circle/48x48/apps/gerbv.svg
1 packages and 0 specfiles checked; 9 errors, 7 warnings.



Diff spec file in url and in SRPM
-
---
/home/slaanesh/reviews/1330861-numix-icon-theme-circle/srpm/numix-icon-theme-circle.spec
   2016-05-02 14:45:04.338709562 +0200
+++
/home/slaanesh/reviews/1330861-numix-icon-theme-circle/srpm-unpacked/numix-icon-theme-circle.spec
   2016-04-19 21:23:03.0 +0200
@@ -14,5 +14,4 

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861



--- Comment #1 from Simone Caronni  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Dist tag is present.
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in numix-icon-theme-circle
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 2 files have unknown license. Detailed
 output of licensecheck in /home/slaanesh/reviews/1330861-numix-icon-
 theme-circle/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x] Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, 

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Simone Caronni  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Sascha Spreitzer  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Sascha Spreitzer  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|negativ...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org