[Bug 1331361] Review Request: perl-Email-Template - Send "multipart/ alternative" (text & html) email from a Template

2016-05-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1331361

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-05-17 12:28:15



--- Comment #4 from Emmanuel Seyman  ---
Mashed in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331361] Review Request: perl-Email-Template - Send "multipart/alternative" (text & html) email from a Template

2016-05-09 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1331361



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Email-Template

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331361] Review Request: perl-Email-Template - Send "multipart/alternative" (text & html) email from a Template

2016-05-09 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1331361



--- Comment #2 from Emmanuel Seyman  ---
(In reply to Petr Pisar from comment #1)
> 
> TODO: I recommend to spell "email" as "e-mail".

Done.

> TODO: Build-require `perl-generators' to autogenerate Perl dependencies for
> the binary package. This feature will not be available by default in the
> future.

Done.

> TODO: Constrain `perl(MIME::Lite)' with version as in the BuildRequires.

Done.

Spec
URL:http://people.parinux.org/~seyman/fedora/perl-Email-Template/perl-Email-Template.spec
SRPM
URL:http://people.parinux.org/~seyman/fedora/perl-Email-Template/perl-Email-Template-0.02-2.fc23.src.rpm

> Resolution: Package APPROVED.

Package requested in pkgdb. Thanks for the review, Petr.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331361] Review Request: perl-Email-Template - Send "multipart/alternative" (text & html) email from a Template

2016-05-09 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1331361

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL And Source0 address are usable. Ok.
Source archive is original (SHA-256: 
f1a68fe08c36e37c2c454239ea1f3ee3131bc36161ae43080c6aeccd5d379d3e). Ok.
Summary verified from lib/Email/Template.pm. Ok.
Description verified from lib/Email/Template.pm. Ok.

TODO: I recommend to spell "email" as "e-mail".

License verified from lib/Email/Template.pm and README. Ok.
Patch is good. Ok.

TODO: Build-require `perl-generators' to autogenerate Perl dependencies for the
binary package. This feature will not be available by default in the future.

Test::Pod and Test::Pod::Coverage are optional for tests. Ok.

All tests pass. Ok.

$ rpmlint perl-Email-Template.spec
../SRPMS/perl-Email-Template-0.02-1.fc25.src.rpm
../RPMS/noarch/perl-Email-Template-0.02-1.fc25.noarch.rpm 
perl-Email-Template.src: W: spelling-error Summary(en_US) multipart ->
multiparty, multiplier
perl-Email-Template.src: W: spelling-error Summary(en_US) html -> HTML, ht ml,
ht-ml
perl-Email-Template.src: W: spelling-error %description -l en_US multipart ->
multiparty, multiplier
perl-Email-Template.src: W: spelling-error %description -l en_US html -> HTML,
ht ml, ht-ml
perl-Email-Template.noarch: W: spelling-error Summary(en_US) multipart ->
multiparty, multiplier
perl-Email-Template.noarch: W: spelling-error Summary(en_US) html -> HTML, ht
ml, ht-ml
perl-Email-Template.noarch: W: spelling-error %description -l en_US multipart
-> multiparty, multiplier
perl-Email-Template.noarch: W: spelling-error %description -l en_US html ->
HTML, ht ml, ht-ml
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Email-Template-0.02-1.fc25.noarch.rpm  
  drwxr-xr-x2 root 
  root0 May  9 14:34 /usr/share/doc/perl-Email-Template
-rw-r--r--1 rootroot  230 Mar 18  2012
/usr/share/doc/perl-Email-Template/Changes
-rw-r--r--1 rootroot 1273 Dec 11  2008
/usr/share/doc/perl-Email-Template/README
-rw-r--r--1 rootroot 3117 May  9 14:34
/usr/share/man/man3/Email::Template.3pm.gz
drwxr-xr-x2 rootroot0 May  9 14:34
/usr/share/perl5/vendor_perl/Email
-rw-r--r--1 rootroot 6639 Mar 18  2012
/usr/share/perl5/vendor_perl/Email/Template.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Email-Template-0.02-1.fc25.noarch.rpm | sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.22.2)
  1 perl(Carp)
  1 perl(Encode)
  1 perl(HTML::FormatText::WithLinks::AndTables)
  1 perl(MIME::Lite)
  1 perl(strict)
  1 perl(Template)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Constrain `perl(MIME::Lite)' with version as in the BuildRequires.

$ rpm -q --provides -p
../RPMS/noarch/perl-Email-Template-0.02-1.fc25.noarch.rpm | sort -f | uniq -c
  1 perl(Email::Template) = 0.02
  1 perl-Email-Template = 0.02-1.fc25
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Email-Template-0.02-1.fc25.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F25
(http://koji.fedoraproject.org/koji/taskinfo?taskID=13979501). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing the `TODO' items before building this package.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331361] Review Request: perl-Email-Template - Send "multipart/alternative" (text & html) email from a Template

2016-05-09 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1331361

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org