[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923

Itamar Reis Peixoto  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||ita...@ispbrasil.com.br
 Resolution|--- |WONTFIX
Last Closed||2020-06-16 00:45:58



--- Comment #7 from Itamar Reis Peixoto  ---
please update this ticket if you need this package reviewed


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923

Paul Dufresne  changed:

   What|Removed |Added

 CC||dufres...@zoho.com



--- Comment #6 from Paul Dufresne  ---
The files to be reviewed don't exist anymore, and the user have no files
anymore on github, or elsewhere I can find.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923



--- Comment #5 from Reto Gantenbein  ---
As this updated still didn't make it into the stable repositories so far, I
provided a COPR repository with a drop-in replacement of a newer Jinja2 for
people to use:

https://copr.fedorainfracloud.org/coprs/ganto/python-jinja2-26/

So far I avoided to change the package name to the '-27' suffix as this would
require a change to the Ansible package too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923



--- Comment #4 from Dominik 'Rathann' Mierzejewski  ---
Not necessarily. You just need to find a reviewer and a sponsor (this can be
the same person, but it doesn't have to). Try asking on epel-devel mailing list
or on the #epel channel on IRC (freenode).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923



--- Comment #3 from Tomohiro Ichikawa  ---
This ticket is left untouched.
This package is unwanted?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923



--- Comment #2 from Tomohiro ICHIKAWA  ---
Jinja2 is used by "Ansible". and Jinja-2.7 have many useful function to write
Ansible Playbooks. e.g. map filter, select filter and more.

Now, in EL7, Jinja2 version is 2.7, but it is 2.6 in EL6 (=> python-jinja2-26
in EPEL6).

This mean that runnable playbooks on EL7 may NOT be able to run on EL6.

Therefore, I thought that I want to provide Jinja-2.7 via EPEL6.
If it is realized, ansible users can make runnable playbooks on both EL6 and
EL7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923

Tomohiro ICHIKAWA  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923



--- Comment #1 from Tomohiro ICHIKAWA  ---
I have fixed the spec file in accordance with the guidelines.

Spec URL:
https://github.com/toromoti/rpm-python-jinja2-27/raw/master/SPECS/python-jinja2-27.spec
SRPM URL:
https://github.com/toromoti/rpm-python-jinja2-27/raw/master/SRPMS/python-jinja2-27-2.7.2-1.el6.src.rpm

### Here is the result of rpmlint:

$ rpmlint -i /vagrant/python-jinja2-27-2.7.2-1.el6.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

### koji build is ok:

$ koji build --scratch el6-candidate
/vagrant/python-jinja2-27-2.7.2-1.el6.src.rpm 
Uploading srpm: /vagrant/python-jinja2-27-2.7.2-1.el6.src.rpm
[] 100% 00:00:00 254.16 KiB 308.07 KiB/sec
Created task: 13872027
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13872027
Watching tasks (this may be safely interrupted)...
13872027 build (el6-candidate, python-jinja2-27-2.7.2-1.el6.src.rpm): free
13872027 build (el6-candidate, python-jinja2-27-2.7.2-1.el6.src.rpm): free ->
open (arm01-builder12.arm.fedoraproject.org)
  13872029 buildArch (python-jinja2-27-2.7.2-1.el6.src.rpm, noarch): open
(buildvm-25.phx2.fedoraproject.org)
  13872029 buildArch (python-jinja2-27-2.7.2-1.el6.src.rpm, noarch): open
(buildvm-25.phx2.fedoraproject.org) -> closed
  0 free  1 open  1 done  0 failed
13872027 build (el6-candidate, python-jinja2-27-2.7.2-1.el6.src.rpm): open
(arm01-builder12.arm.fedoraproject.org) -> closed
  0 free  0 open  2 done  0 failed

13872027 build (el6-candidate, python-jinja2-27-2.7.2-1.el6.src.rpm) completed
successfully

### result of fedora-review:

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1075200 bytes in 78 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "GPL (v2 or later)", "Unknown or generated".
 69 files have unknown license. Detailed output of licensecheck in
 /home/vagrant/python-jinja2-27/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python2.6/site-packages,
 /usr/lib/python2.6
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python2.6,
 /usr/lib/python2.6/site-packages
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package 

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923

Tomohiro ICHIKAWA  changed:

   What|Removed |Added

  Component|Package Review  |Package Review
   Hardware|All |noarch
Version|rawhide |el6
Product|Fedora  |Fedora EPEL



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331923] Review Request: python-jinja2-27 - EPEL6 only jinja-2.7 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331923

Tomohiro ICHIKAWA  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)
  Flags||fedora-review?




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org