[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 Miroslav Suchý changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #25 from Fedora Update System --- phototonic-1.7.20-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #24 from Fedora Update System --- phototonic-1.7.20-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #23 from Fedora Update System --- phototonic-1.7.20-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-06-04 22:51:09 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #22 from Fedora Update System --- phototonic-1.7.20-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #21 from Fedora Update System --- phototonic-1.7.20-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-97acfb51b4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #20 from Fedora Update System --- phototonic-1.7.20-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9021abfe13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #19 from Fedora Update System --- phototonic-1.7.20-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-acafcbf543 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- phototonic-1.7.20-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-07f631907e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #17 from Fedora Update System --- phototonic-1.7.20-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-07f631907e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #15 from Fedora Update System --- phototonic-1.7.20-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-acafcbf543 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #16 from Fedora Update System --- phototonic-1.7.20-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-97acfb51b4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #14 from Fedora Update System --- phototonic-1.7.20-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9021abfe13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #13 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/phototonic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #12 from Mukundan Ragavan --- I have now sponsored you into the packagers group. You should be able to use the fedorapeople space now (https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org) if you so desire. If you do not mind, you can add me as a co-maintainer for this package. Please feel free me to shoot me an email if you need some help. Welcome to Fedora and to the packagers group! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 Mukundan Ragavan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Mukundan Ragavan --- (In reply to Michael Cullen from comment #10) > I only see one issue - the desktop database one. The other thing on the > issues list actually goes against the guidance in > https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B > > did I miss one? That's right. There was only one (apparently, I cannot count! :)). gcc-c++ is not an issue as I have mentioned. From my comment - " - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ---> This is fine. " > > > Spec URL: https://cullen-online.com/rpm-review/phototonic.spec > SRPM URL: > https://cullen-online.com/rpm-review/phototonic-1.7.20-2.fc24.src.rpm I see that everything is fixed. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #10 from Michael Cullen --- I only see one issue - the desktop database one. The other thing on the issues list actually goes against the guidance in https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B did I miss one? Spec URL: https://cullen-online.com/rpm-review/phototonic.spec SRPM URL: https://cullen-online.com/rpm-review/phototonic-1.7.20-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #9 from Mukundan Ragavan --- rpmlint messages are ok. No issues there. Only two minor issues. Please go through the review in the above comment. Once those are resolved, I will approve the package and sponsor you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344
--- Comment #8 from Mukundan Ragavan ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
---> This is fine.
- update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in phototonic
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
---> Please fix this.
You can add update-desktop-database under %post and %postun or %posttrans.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated". 8 files have
unknown license. Detailed output of licensecheck in
/home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1332344-phototonic/licensecheck.txt
---> The "unknown" fields are arch and debian build scripts. Not an issue here.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16,
/usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48,
/usr/share/icons/hicolor/48x48/apps
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in phototonic
---> gtk-update-icon-cache present in the spec file.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 71680 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in t
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #7 from Mukundan Ragavan --- Thank you Michael. I will be out of town tomorrow. Once I am back, I will post a review. Thank you for your patience and quick uploads! :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #6 from Michael Cullen --- Looks like copr git URLs are broken - probably after today's maintainance. I'll try plan B then. Spec URL: https://cullen-online.com/phototonic.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mich181189/phototonic/fedora-24-x86_64/00183358-phototonic/phototonic-1.7.20-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #5 from Mukundan Ragavan --- When you add the links, please add both spec and srpm in the same comment. Also, thanks for doing the koji build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #4 from Mukundan Ragavan --- hmmm ... spec url is broken. Can you please fix the link? Make sure it's linked to "raw" version (not html) so that I can run fedora-review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #3 from Michael Cullen --- Updated version now upstream have tagged a release properly: Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mich181189/phototonic/phototonic.git/plain/phototonic.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mich181189/phototonic/fedora-24-x86_64/00183358-phototonic/phototonic-1.7.20-1.fc24.src.rpm scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13925343 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #2 from Michael Cullen --- I've also commented on https://bugzilla.redhat.com/show_bug.cgi?id=1332999 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 --- Comment #1 from Michael Cullen --- Gah sorry just seen that spec file is the HTML-ified version. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mich181189/phototonic/phototonic.git/plain/phototonic.spec should be more correct. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332344] Review Request: phototonic - Image viewer and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1332344 Michael Cullen changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
