[Bug 1332999] Review Request: python-xunitparser - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 Miroslav Suchý changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 Tim Flink changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2016-05-24 15:40:53 --- Comment #9 from Tim Flink --- (In reply to John Dulaney from comment #8) > As an aside, you may want to ping ignatenkobrain on IRC (Freenode) and see > about becoming a co-maintainer, as he also submitted a review for this > package, and his was granted. That's already been taken care of. Not sure why this hasn't been closed as duplicate yet. Closing, please re-open if I misunderstood something *** This bug has been marked as a duplicate of bug 1333525 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 John Dulaney changed: What|Removed |Added CC||jdula...@fedoraproject.org --- Comment #8 from John Dulaney --- As an aside, you may want to ping ignatenkobrain on IRC (Freenode) and see about becoming a co-maintainer, as he also submitted a review for this package, and his was granted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 Tim Flink changed: What|Removed |Added CC||tfl...@redhat.com --- Comment #7 from Tim Flink --- Has the duplication between this and #1333525 been figured out? It looks like slightly more progress has been made on that review but it's yet to be completed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 Thomas Spura changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #6 from Thomas Spura --- In bug #1333525 it is mentioned that the python3 failures have been reported to upstream. There isn't anything about the status of the fixes, though. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 --- Comment #5 from Lukas Brabec --- I updated the files: Spec URL: https://lbrabec.fedorapeople.org/python-xunitparser.spec SRPM URL: https://lbrabec.fedorapeople.org/python-xunitparser-1.3.3-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999
Michael Cullen changed:
What|Removed |Added
CC||mich...@cullen-online.com
--- Comment #4 from Michael Cullen ---
*Unofficial comments - I too am waiting for a sponsor *
Minor, mostly personal choice point first: you don't need the "sum" global -
just include the summary in the header as usual and then use %{summary} where
you need it. Though having said that, the python sample spec file does it your
way. I just like keeping extra macros to a minimum.
The Group tag is not needed [1]
Ideally the description would be a little bit more than just the summary
rpmlint is clean, which is good
license looks fine
[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 --- Comment #3 from Lukas Brabec --- I initially included python3 but I found that `python3 setup.py test` fails in several testcases. I decided not to include python3 until the testsuite passes without failures or errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 Stanislav Ochotnicky changed: What|Removed |Added CC||socho...@redhat.com --- Comment #2 from Stanislav Ochotnicky --- The package looks good to me generally - pretty small/clean. Why no Python 3 though? It seems to build fine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332999] Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1332999 Lukas Brabec changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #1 from Lukas Brabec --- This is my first package, so I need sponsor. We need this package for Taskotron [1], to parse XML output of pytest and unittest. [1] https://taskotron.fedoraproject.org/ Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
