[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #15 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-xunitparse -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #14 from Tim Flink --- (In reply to philip.worrall from comment #11) > (In reply to Tim Flink from comment #7) > > Has the duplication with bug #1332999 been figured out? > > I think the issue was that the previous reporter still needed to go through > sponsorship but this package was/is needed now for some of the ongoing QA > stuff. The issue has been sorted out AFAIK. I talked with Lukas and Igor today and I think the plan is to mark #1332999 report as a duplicate of this one. I'm a little annoyed with how this was handled but it's kind of a side-effect of the process we have. I mostly want see this packaged because we do need it for a QA tool. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 John Dulaney changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #13 from John Dulaney --- Okay, in that case, I'll go ahead and say approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #12 from philip.worr...@googlemail.com --- (In reply to Tim Flink from comment #9) > (In reply to Igor Gnatenko from comment #8) > > > > > * Fails to build in mock fc23 because python2-setuptools is not available, > > > if you care about this package working on older versions of fedora then > > > you > > > could add a macro to test for fc23 and depend on this package instead. > > /me don't care about fc23 > > Are you at least open to patches from those of us who do want it to work on > f23? Sorry i just double checked and it does build on fc23 as is. See link to copr build https://copr.fedorainfracloud.org/coprs/worralph/pending/package/python-xunitparser/ i think my mock was using the fc22 config which doesnt have python2-setuptools. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #11 from philip.worr...@googlemail.com --- (In reply to Tim Flink from comment #7) > Has the duplication with bug #1332999 been figured out? I think the issue was that the previous reporter still needed to go through sponsorship but this package was/is needed now for some of the ongoing QA stuff. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #10 from John Dulaney --- rpmlint is clean, review looks good. I would prefer it if the URL was the full url, but that's just a personal thing. Also, if you could, go ahead and apply the supplied patches. Either the tests need to work correctly or be disabled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #9 from Tim Flink --- (In reply to Igor Gnatenko from comment #8) > > * Fails to build in mock fc23 because python2-setuptools is not available, > > if you care about this package working on older versions of fedora then you > > could add a macro to test for fc23 and depend on this package instead. > /me don't care about fc23 Are you at least open to patches from those of us who do want it to work on f23? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525
--- Comment #8 from Igor Gnatenko ---
(In reply to philip.worrall from comment #2)
> * Yes the python3 testsuite fails for this package, i get FAILED
> (failures=6, errors=17) out of 42 tests.
> * Maybe you could put the date you reported the testsuite bug upstream in
> the comments.
You attached patch, will apply in import time, thanks. Will also put date.
> * In the source url you can use the %{modname} macro again in the url.
will do in import time
> * Fails to build in mock fc23 because python2-setuptools is not available,
> if you care about this package working on older versions of fedora then you
> could add a macro to test for fc23 and depend on this package instead.
/me don't care about fc23
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 Tim Flink changed: What|Removed |Added CC||tfl...@redhat.com --- Comment #7 from Tim Flink --- Has the duplication with bug #1332999 been figured out? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 John Dulaney changed: What|Removed |Added Status|NEW |ASSIGNED CC||jdula...@fedoraproject.org Assignee|nob...@fedoraproject.org|jdula...@fedoraproject.org Flags||fedora-review? --- Comment #6 from John Dulaney --- I'll grab this for a formal review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525
--- Comment #5 from philip.worr...@googlemail.com ---
A minor comment, You can use the global _docdir_fmt %{name} variable at the top
of the spec to install the documentation just once.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #4 from philip.worr...@googlemail.com --- Python 3.4 changed the testsuite behaviour such that each call to run removed references to tests in the suite. This breaks the xunitparser test suite on python >=3.4 because it relies on the old behaviour. This patch restores the previous behaviour as recommended by https://docs.python.org/3.4/library/unittest.html#unittest.TestSuite when the old behaviour is relied upon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #3 from philip.worr...@googlemail.com --- Created attachment 1158330 --> https://bugzilla.redhat.com/attachment.cgi?id=1158330&action=edit repair testsuite python >= 3.4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525
philip.worr...@googlemail.com changed:
What|Removed |Added
CC||philip.worrall@googlemail.c
||om
--- Comment #2 from philip.worr...@googlemail.com ---
I am NOT a fedora packager but I am happy to carry out an informal review.
* (sanity check) After installing I can import both modules from the
interactive console.
* Package is the latest version upstream
* Yes the python3 testsuite fails for this package, i get FAILED (failures=6,
errors=17) out of 42 tests.
* Maybe you could put the date you reported the testsuite bug upstream in the
comments.
* In the source url you can use the %{modname} macro again in the url.
* Fails to build in mock fc23 because python2-setuptools is not available, if
you care about this package working on older versions of fedora then you could
add a macro to test for fc23 and depend on this package instead.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have
unknown license. Detailed output of licensecheck in /home/worralph
/fedora-review/python-xunitparser/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]:
[Bug 1333525] Review Request: python-xunitparse - Read JUnit/XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 Thomas Spura changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #1 from Thomas Spura --- It seems this is a duplicate of bug #1332999. Could you help getting that package approved and ask for co-maintainership there? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
