[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 Sergio Monteiro Basto changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||ser...@serjux.com Resolution|--- |CURRENTRELEASE Last Closed||2016-07-03 14:00:40 --- Comment #17 from Sergio Monteiro Basto --- https://bodhi.fedoraproject.org/updates/FEDORA-2016-0e1d10a348 https://bodhi.fedoraproject.org/updates/FEDORA-2016-4ce3af54eb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 MartinKG changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #16 from MartinKG --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059
--- Comment #15 from MartinKG ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 4792320 bytes in 1260 files.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "MIT/X11 (BSD like)", "zlib/libpng",
"BSL", "GPL (v2 or later) (with incorrect FSF address)", "ISC". 1304
files have unknown license. Detailed output of licensecheck in
/home/martin/rpmbuild/SPECS/openclonk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in openclonk
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in openclonk
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{vers
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #14 from MartinKG --- (In reply to Antonio Trande from comment #13) > > We can maintain it together, but it should be retired by RPM Fusion. filled bug report on rpmfusion: https://bugzilla.rpmfusion.org/show_bug.cgi?id=4052 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #13 from Antonio Trande --- Spec URL: https://sagitter.fedorapeople.org/openclonk/openclonk.spec SRPM URL: https://sagitter.fedorapeople.org/openclonk/openclonk-7.0-3.fc23.src.rpm - Made sub-package for documentation > The license status was not clear at this time, now it is time that it is > taken up by Fedora. We can maintain it together, but it should be retired by RPM Fusion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #12 from MartinKG --- The license status was not clear at this time.(In reply to Antonio Trande from comment #11) > (In reply to MartinKG from comment #10) > > could you please create a devel-docs subpkg like the rpmfusion package ? > > https://github.com/rpmfusion/openclonk/blob/master/openclonk.spec > > I did not know it was on RPMFusion. > It is release under "ISC and CC-BY-SA", i see; why it's not on Fedora ? The license status was not clear at this time, now it is time that it is taken up by Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #11 from Antonio Trande --- (In reply to MartinKG from comment #10) > could you please create a devel-docs subpkg like the rpmfusion package ? > https://github.com/rpmfusion/openclonk/blob/master/openclonk.spec I did not know it was on RPMFusion. It is release under "ISC and CC-BY-SA", i see; why it's not on Fedora ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #10 from MartinKG --- could you please create a devel-docs subpkg like the rpmfusion package ? https://github.com/rpmfusion/openclonk/blob/master/openclonk.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #9 from Antonio Trande --- Yes, sorry; my bad. Spec URL: https://sagitter.fedorapeople.org/openclonk/openclonk.spec SRPM URL: https://sagitter.fedorapeople.org/openclonk/openclonk-7.0-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #8 from MartinKG --- https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database wiki points me to this: Use this when a desktop entry has a 'MimeType key. %post /usr/bin/update-desktop-database &> /dev/null || : %postun /usr/bin/update-desktop-database &> /dev/null || : -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059
--- Comment #7 from Antonio Trande ---
(In reply to MartinKG from comment #6)
> Issues:
> ===
> - update-desktop-database is invoked in %post and %postun if package
> contains desktop file(s) with a MimeType: entry.
> Note: desktop file(s) with MimeType entry in openclonk
> See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
> database
Are there.
%post
/bin/touch --no-create %{_datadir}/mime/packages &>/dev/null || :
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun
if [ $1 -eq 0 ] ; then
/usr/bin/update-mime-database %{_datadir}/mime &> /dev/null || :
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi
%posttrans
/usr/bin/update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || :
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 MartinKG changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mgans...@alice.de Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #6 from MartinKG --- Issues: === - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in openclonk See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 Antonio Trande changed: What|Removed |Added Whiteboard|NotReady| --- Comment #5 from Antonio Trande --- Spec URL: https://sagitter.fedorapeople.org/openclonk/openclonk.spec SRPM URL: https://sagitter.fedorapeople.org/openclonk/openclonk-7.0-2.fc23.src.rpm - Unbundle getopt - Strip all .png files - Make an appdata file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 Antonio Trande changed: What|Removed |Added Whiteboard||NotReady --- Comment #4 from Antonio Trande --- (In reply to MartinKG from comment #3) > (In reply to Antonio Trande from comment #2) > > In reply to https://bugzilla.redhat.com/show_bug.cgi?id=1186503#c14: > > > > Where are getopt files on Fedora? > > # rpm -qf /usr/include/getopt.h > glibc-headers-2.22-11.fc23.x86_64 repoquery did not found it ... Okay, I'm going to fix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 --- Comment #3 from MartinKG --- (In reply to Antonio Trande from comment #2) > In reply to https://bugzilla.redhat.com/show_bug.cgi?id=1186503#c14: > > Where are getopt files on Fedora? # rpm -qf /usr/include/getopt.h glibc-headers-2.22-11.fc23.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 Antonio Trande changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #2 from Antonio Trande --- In reply to https://bugzilla.redhat.com/show_bug.cgi?id=1186503#c14: > > and Clonk Game Content License > > http://www.clonk.de/developer.php?lng=en > > Creative Commons Attribution-NonCommercial (CC BY-NC) > > http://creativecommons.org/licenses/by-nc/4.0/ > > > > which License tag should i use now ? > > As far as I can evaluate, the license tag has to be "ISC and CC-BY-NC". but > have a look at the tables in the licensing guidelines: > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses_3 > The Creative Commons Attribution-NonCommercial License is mentioned there as > a "bad license" (maybe due to inacceptable restrictions). So I'm afraid this > package is only releasable in RPMfusion. http://wiki.openclonk.org/w/FAQ#What_is_the_license_for_OpenClonk.3F CC-BY-SA is a good license for Fedora. > $ licensecheck -r * | grep BSD > thirdparty/getopt/getopt_long.c: BSD (3 clause) > thirdparty/getopt/getopt.c: BSD (3 clause) > > This refers to bundled stuff. We don't use this, we need to pull the getopt > development files from the build system. This also means you still have to > remove thirdparty/getopt, better the whole thirdparty directory to be on > safer side. Maybe a patch is needed to use the local getopt instead of the > bundled one. Where are getopt files on Fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334059] Review Request: openclonk - Multiplayer action, tactics and skill game
https://bugzilla.redhat.com/show_bug.cgi?id=1334059 Antonio Trande changed: What|Removed |Added CC||mgans...@alice.de --- Comment #1 from Antonio Trande --- *** Bug 1186503 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
