[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #13 from Fedora Update System  ---
crawl-0.18.1-5.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-06-20 18:24:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #12 from Fedora Update System  ---
crawl-0.18.1-5.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #11 from Fedora Update System  ---
crawl-0.18.1-5.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-abd83ba897

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
crawl-0.18.1-5.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-124c422ef0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #8 from Fedora Update System  ---
crawl-0.18.1-5.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-abd83ba897

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #9 from Fedora Update System  ---
crawl-0.18.1-5.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-124c422ef0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/crawl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743

Ben Rosser  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Ben Rosser  ---
I see; well, as the test suite cannot be run, the package is APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v3
 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (2
 clause)", "BSD (3 clause) GPL (v2 or later)", "*No copyright* MIT/X11
 (BSD like)". 1507 files have unknown license. Detailed output of
 licensecheck in
 /home/bjr/Programming/fedora/1342743-crawl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/32x32/apps,
 /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32,
 /usr/share/icons/hicolor, /usr/share/icons/hicolor/512x512
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in crawl-common-data
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 890880 bytes in 32 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Avoid 

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #5 from Antonio Trande  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00341180-crawl/crawl-0.18.1-5.fc25.src.rpm

- Remove unused/bundled files
- License clarification
- Compile debugging files and make Crawl tests

Note.

'crawl -test' looks not playable at build time because the DATADIR directory is
set for run-time use only.
Also, I reported a presumed bug:
https://crawl.develz.org/mantis/view.php?id=10499

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #4 from Raphael Groner  ---
Besides running the unit tests after a package build, defing one of DEBUG,
DEBUG_DIAGNOSTICS or DEBUG_TEST may help with further abrt reports, too. Please
consider to do so, though I can't tell what's best for abrt, propably DEBUG is
sufficient.

> [!]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v3
> or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (2
> clause)", "BSD (3 clause) GPL (v2 or later)", "*No copyright* MIT/X11
> (BSD like)". 1507 files have unknown license. 

The combined license and the amount of unlicensed files let suspect bundled
libraries. You MUST add a license breakdown as comment, what individual file is
licensed how.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #3 from Antonio Trande  ---
(In reply to Ben Rosser from comment #2)
> Sorry for the delay in getting to this one.
> 
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> ===
> 
> - There are unit tests available, is it feasible to run them? See here:
> https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/testing.txt
> It may not be, though, because it seems you need to compile with some
> debugging options set.

It's for debugging only.

> 
> - According to licensecheck, there are also sources under the MIT license...
> some of these aren't used (e.g. MSVC/include/dirent.h), but json.cc and
> worley.cc seem to get built. So you should add "and MIT" to the license
> field.
> 
> crawl-0.18.1/crawl-ref/crawl-tiles/MSVC/include/dirent.h
> crawl-0.18.1/crawl-ref/crawl-tiles/json.cc
> crawl-0.18.1/crawl-ref/crawl-tiles/json.h
> crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery.
> cookie.js
> crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery.
> tablesorter.js
> crawl-0.18.1/crawl-ref/crawl-tiles/worley.cc
> crawl-0.18.1/crawl-ref/crawl-tiles/worley.h
> crawl-0.18.1/crawl-ref/source/MSVC/include/dirent.h
> crawl-0.18.1/crawl-ref/source/json.cc
> crawl-0.18.1/crawl-ref/source/json.h
> crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery.cookie.
> js
> crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery.
> tablesorter.js
> crawl-0.18.1/crawl-ref/source/worley.cc
> crawl-0.18.1/crawl-ref/source/worley.h

Okay, fixed.

> 
> fedora-review automatically generated the following issues, but they appear
> to both be spurious, so I would ignore them:
> 
> - All build dependencies are listed in BuildRequires, except for any that
>   are listed in the exceptions section of Packaging Guidelines.
>   Note: These BR are not needed: gcc-c++
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
> 
> (my comment: this isn't actually an issue, the guidelines have been reworded
> relatively recently to *not* say that you should assume a compiler is
> installed. So this isn't something I'd worry about).
> 
> - gtk-update-icon-cache is invoked in %postun and %posttrans if package
>   contains icons.
>   Note: icons in crawl-common-data
>   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
> 
> (my comment: they... are, I don't know what fedora-review is talking about
> here).
> 

'gtk-update-icon-cache' must be invoked for crawl-common-data sub-package that
provides all icons.
Fixed.

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00338976-crawl/crawl-0.18.1-4.fc25.src.rpm

- Include MIT license
- Fix scriptlets for icons

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743

Ben Rosser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rosser@gmail.com
   Assignee|nob...@fedoraproject.org|rosser@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743



--- Comment #1 from Antonio Trande  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00329388-crawl/crawl-0.18.1-3.fc25.src.rpm

- Add an appdata file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org