[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 --- Comment #10 from Fedora Update System --- libtaskotron-0.4.13-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 --- Comment #9 from Fedora Update System --- libtaskotron-0.4.13-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-07-09 19:54:32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 --- Comment #8 from Fedora Update System --- libtaskotron-0.4.13-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a3ca68110e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- libtaskotron-0.4.13-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-848283f988 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 --- Comment #6 from Fedora Update System --- libtaskotron-0.4.13-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-848283f988 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 --- Comment #5 from Fedora Update System --- libtaskotron-0.4.13-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a3ca68110e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libtaskotron -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 Adam Miller changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Adam Miller --- Apologies for the delay on this, all previous requests to be resolved have been. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249
--- Comment #2 from Martin Krizek ---
Thanks for the review, Adam!
Updated version:
Spec URL: https://mkrizek.fedorapeople.org/specs/libtaskotron.spec
SRPM URL:
https://mkrizek.fedorapeople.org/srpms/libtaskotron-0.4.13-3.fc23.src.rpm
One thing I didn't change though is that I didn't add noreplace for
%{_sysconfdir}/taskotron/yumrepoinfo.conf. We want this particular file to be
updated with the recent version. Let me know if that's ok, thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249
--- Comment #1 from Adam Miller ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (unversioned/unknown version)", "GPL (v3 or later)",
"Unknown or generated". 82 files have unknown license. Detailed output
of licensecheck in
/home/admiller/reviews/1344249-libtaskotron/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-packages/libtaskotron
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/libtaskotron
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/taskotron/namespaces.yaml %config
/etc/taskotron/yumrepoinfo.conf
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
http://qadevel.fedoraproject.org/releases/libtaskotron/libtaskotron-0.4.13.tar.gz
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully
[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library
https://bugzilla.redhat.com/show_bug.cgi?id=1344249 Adam Miller changed: What|Removed |Added CC||admil...@redhat.com Assignee|nob...@fedoraproject.org|admil...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
