[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-10-11 11:43:02 |2016-10-24 19:51:04



--- Comment #17 from Fedora Update System  ---
execdb-0.0.7-5.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #16 from Fedora Update System  ---
execdb-0.0.7-5.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2a012e4d1a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #15 from Fedora Update System  ---
execdb-0.0.7-4.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-11 11:43:02



--- Comment #14 from Fedora Update System  ---
execdb-0.0.7-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #13 from Fedora Update System  ---
execdb-0.0.7-5.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2a012e4d1a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #12 from Fedora Update System  ---
execdb-0.0.7-4.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c5a81466d7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #11 from Fedora Update System  ---
execdb-0.0.7-4.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd1d819866

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #10 from Fedora Update System  ---
execdb-0.0.7-4.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-707a2f48ed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/execdb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Jerry James  ---
Okay, I still think you're going to wish you had named this python-execdb, but
that's on you now.  This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #7 from Martin Krizek  ---
Thanks!

Updated version follows:
Spec URL: https://mkrizek.fedorapeople.org/specs/execdb.spec
SRPM URL: https://mkrizek.fedorapeople.org/srpms/execdb-0.0.7-4.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #6 from Jerry James  ---
Issues
==
1. The lines in %description are 90 characters long, which can cause them to be
   truncated on the right when shown in one of the GUI package tools.  I limit
   those lines to 72 characters in my packages, which seems to work okay.  See
   the rpmlint description-line-too-long warnings below.

2. Why are execdb.conf, exedb.wsgi, and settings.py.example included in %doc
   when they are also installed elsewhere?  Also, why is settings.py.example
   installed in /etc?  Shouldn't that only be in %doc?  (See the rpmlint
   non-conffile-in-etc warning below.)

3. This is an application, not a python module, so the naming requirements for
   python may not apply ... but let's think about the future.  What happens
   when a python 3 port becomes desirable?  You'll want 2 parallel installable
   versions of this package for some time before the python 2 version can be
   jettisoned.  I think you should seriously consider naming this package
   python-execdb, so that future python2- and python3- variants will be easy.
   Also, see this material on how multiple python runtimes are managed:
   https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro.

4. Speaking of the future, when the migration from python 2 to python 3 starts
   in earnest, it will be safer for this package to specify python version in
   the BuildRequires/Requires where that is possible; i.e.,

   Requires: python2-six
   BuildRequires:  python2-setuptools

   alembic and flask don't seem to provide those names yet.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets 

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #5 from Jerry James  ---
I will take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #4 from Tim Flink  ---
It's a server in the sense that it's a WSGI application which is then used by
apache httpd (or something similar) to actually server the application.

I don't think that it needs a service file unless I'm mis-remembering the
package guidelines on this front.

I don't think that we've tested execdb with python3. One of the primary parts
of our stack is stuck on python2 until there's a python3 koji client available
and we seem to be sticking to python2 for everything.

The long and short of it is that if it is compatible with python3, that's not
something we (as in the upstream) are testing or planning to support at this
time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Is this is a server, does it need a service file?

Is it a server, or is it a module to be used by others?

Is it compatible with python3?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #2 from Martin Krizek  ---
Thanks, updated version follows:

Spec URL: https://mkrizek.fedorapeople.org/specs/execdb.spec
SRPM URL: https://mkrizek.fedorapeople.org/srpms/execdb-0.0.7-3.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Please provide a description. Your description is a good Summary, but too short
for a %description.

%py2_build

%py2_install

Those dots at the end look strange (cp conf/execdb.wsgi
%{buildroot}%{_datadir}/execdb/.).

Is this is a server, does it need a service file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org