[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Blocks||1181081 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1181081 [Bug 1181081] wildfly: Upgrade to 10.1.0.Final -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #16 from Fedora Update System --- aries-blueprint-api-1.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-08-10 13:29:55 |2016-08-27 06:40:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #15 from Fedora Update System --- aries-blueprint-api-1.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4cbc52b1b2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #14 from Fedora Update System --- aries-blueprint-api-1.0.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4cbc52b1b2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Blocks||1366017 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1366017 [Bug 1366017] Review Request: aries-blueprint-cm - Apache Aries Blueprint CM -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Status|NEW |CLOSED Fixed In Version||aries-blueprint-api-1.0.1-1 ||.fc25, ||aries-blueprint-api-1.0.1-1 ||.fc26 Resolution|--- |RAWHIDE Last Closed||2016-08-10 13:29:55 --- Comment #13 from gil cattaneo --- rawhide Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15204617 f25 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15204667 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #12 from gil cattaneo --- Sure. Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/7137 https://admin.fedoraproject.org/pkgdb/package/requests/7138 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 Jonny Heggheim changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Jonny Heggheim --- (In reply to gil cattaneo from comment #10) > aries-blueprint should be retired. please, continue the review Review approved. Please initiate retirement of aries-blueprint. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Blocks||1365144 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1365144 [Bug 1365144] Review Request: aries-blueprint-core - Apache Aries Blueprint Core -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #10 from gil cattaneo --- (In reply to Jonny Heggheim from comment #9) > What is the status, have you agreed on an upgrade path? aries-blueprint should be retired. please, continue the review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #9 from Jonny Heggheim --- What is the status, have you agreed on an upgrade path? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Flags|needinfo?(puntogil@libero.i | |t) | --- Comment #8 from gil cattaneo --- (In reply to Marek Goldmann from comment #7) > I think the idea here is to discontinue the aries-blueprint package in favor > of the new version (that is split in multiple packages). In that case some > overrides should be added. Gil - is that the intention? Yes, it is the only way i can see it. It would be complicated and perhaps impractical a meta package, which contains all the modules required -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 Marek Goldmann changed: What|Removed |Added CC||punto...@libero.it Flags|needinfo?(mgoldman@redhat.c |needinfo?(puntogil@libero.i |om) |t) --- Comment #7 from Marek Goldmann --- I think the idea here is to discontinue the aries-blueprint package in favor of the new version (that is split in multiple packages). In that case some overrides should be added. Gil - is that the intention? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 Jonny Heggheim changed: What|Removed |Added CC||mgold...@redhat.com Flags||needinfo?(mgoldman@redhat.c ||om) --- Comment #6 from Jonny Heggheim --- > aries-blueprint is only a wrapper and/or bundled code from different aries > (sub-)projects. In the 1.x series is packages ad single artifact see the content of http://central.maven.org/maven2/org/apache/aries/blueprint/org.apache.aries.blueprint/1.1.0/org.apache.aries.blueprint-1.1.0-source-release.zip Can you Marek Goldmann confirm that this package is not conflicting with aries-blueprint that you maintain? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #4 from gil cattaneo --- (In reply to Jonny Heggheim from comment #2) > > [!]: Package does not generate any conflict. > > Please clarify the relation between org.apache.aries.blueprint.api.jar > included in the aries-blueprint-0.3.1-12 and this package. It seems that it > is the same library that is packed. aries-blueprint is only a wrapper and/or bundled code from different aries (sub-)projects. In the 1.x series is packages ad single artifact see the content of http://central.maven.org/maven2/org/apache/aries/blueprint/org.apache.aries.blueprint/1.1.0/org.apache.aries.blueprint-1.1.0-source-release.zip -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #3 from Igor Gnatenko --- (In reply to Jonny Heggheim from comment #1) > This is a review *template*. Besides handling the [ ]-marked tests you are > also supposed to fix the template before pasting into bugzilla: > - Add issues you find to the list of issues on top. If there isn't such > a list, create one. > - Add your own remarks to the template checks. > - Add new lines marked [!] or [?] when you discover new things not > listed by fedora-review. > - Change or remove any text in the template which is plain wrong. In this > case you could also file a bug against fedora-review > - Remove the "[ ] Manual check required", you will not have any such lines > in what you paste. > - Remove attachments which you deem not really useful (the rpmlint > ones are mandatory, though) > - Remove this text Looks like you didn't complete this task ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 --- Comment #2 from Jonny Heggheim --- > [!]: Package does not generate any conflict. Please clarify the relation between org.apache.aries.blueprint.api.jar included in the aries-blueprint-0.3.1-12 and this package. It seems that it is the same library that is packed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973
--- Comment #1 from Jonny Heggheim ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
(v2.0)". 3 files have unknown license. Detailed output of licensecheck
in /tmp/1347973-aries-blueprint-api/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style pa
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 Jonny Heggheim changed: What|Removed |Added CC||heg...@gmail.com Blocks|652183 (FE-JAVASIG) | Assignee|nob...@fedoraproject.org|heg...@gmail.com Flags||fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Blocks||1347977 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1347977 [Bug 1347977] Review Request: - Apache Aries Blueprint Parser -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Blocks||1166655 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1166655 [Bug 1166655] aries-blueprint: Update to latest upstream version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347973] Review Request: aries-blueprint-api - Apache Aries Blueprint API
https://bugzilla.redhat.com/show_bug.cgi?id=1347973 gil cattaneo changed: What|Removed |Added Blocks||1276555 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276555 [Bug 1276555] cxf-3.1.4 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
