[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #14 from Fedora Update System--- python-represent-1.5.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-07-10 02:00:01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #13 from Fedora Update System--- python-represent-1.5.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #12 from Fedora Update System--- python-represent-1.5.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f648b80c05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- python-represent-1.5.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e750a8e708 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #10 from Fedora Update System--- python-represent-1.5.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f648b80c05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #9 from Fedora Update System--- python-represent-1.5.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e750a8e708 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Fedora Update Systemchanged: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #8 from Jon Ciesla--- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-represent -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Lumír Balharchanged: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Lumír Balhar --- Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Lumír Balharchanged: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #6 from Dominika Krejčí--- * using srcname macro in files * pytest > python2-pytest Spec URL: https://dkrejci.fedorapeople.org/python-represent/python-represent.spec SRPM URL: https://dkrejci.fedorapeople.org/python-represent/python-represent-1.5.1-1.fc23.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14604551 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #5 from Lumír Balhar--- You have hardcoded "represent" instead "%{srcname}" in %files section. Maybe python2-pytest could be better (more specific) than pytest in BuildRequires. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #4 from Dominika Krejčí--- Thank you for the review and other comments. I've made some changes: * modified source URL * added tests and it's BuildRequires * specified %{pythonX_sitelib} section in files Spec URL: https://dkrejci.fedorapeople.org/python-represent/python-represent.spec SRPM URL: https://dkrejci.fedorapeople.org/python-represent/python-represent-1.5.1-1.fc23.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=14591902 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #3 from Lumír Balhar--- (In reply to Miro Hrončok from comment #2) > (In reply to Lumír Balhar from comment #1) > > [-]: A package which is used by another package via an egg interface should > > provide egg info. > > Any reason why this is not [x]? Have you checked? Sorry for my mistake. It is just typo. I checked it and RPMs contain correct .egg-info dirs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 --- Comment #2 from Miro Hrončok--- (In reply to Lumír Balhar from comment #1) > [-]: A package which is used by another package via an egg interface should > provide egg info. Any reason why this is not [x]? Have you checked? Also, Dominika, I strongly suggest against this in %files: %{pythonX_sitelib}/* Now we have no idea what can all get installed with this package, more explicit list would make things more safe, something like this is always better: %{pythonX_sitelib}/%{srcname} %{pythonX_sitelib}/%{srcname}-%{version}-py?.?.egg-info -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Miro Hrončokchanged: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|lbal...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Lumír Balharchanged: What|Removed |Added CC||lbal...@redhat.com --- Comment #1 from Lumír Balhar --- Hello. Everything in your new package looks good to me except one thing - tests. Upstream contains working tests. Is there any reason for omitting tests in the package? Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/lbalhar/Review/1348207-python-represent/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause) MIT/X11 (BSD like)", "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /home/lbalhar/Review/1348207-python-represent/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-represent , python3-represent [x]: Package
[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively
https://bugzilla.redhat.com/show_bug.cgi?id=1348207 Dominika Krejčíchanged: What|Removed |Added Blocks||1317888 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1317888 [Bug 1317888] python-yourls: Provide a Python 3 subpackage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org