[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #19 from Fedora Update System  ---
python-backports-shutil_get_terminal_size-1.0.0-1.fc23 has been pushed to the
Fedora 23 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-07-10 01:59:16



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #18 from Fedora Update System  ---
python-backports-shutil_get_terminal_size-1.0.0-1.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #17 from Fedora Update System  ---
python-backports-shutil_get_terminal_size-1.0.0-1.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2efe949d18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
python-backports-shutil_get_terminal_size-1.0.0-1.fc23 has been pushed to the
Fedora 23 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-10a3578e5a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #14 from Fedora Update System  ---
python-backports-shutil_get_terminal_size-1.0.0-1.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2efe949d18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #15 from Fedora Update System  ---
python-backports-shutil_get_terminal_size-1.0.0-1.fc23 has been submitted as an
update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-10a3578e5a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #13 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-backports-shutil_get_terminal_size

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997

Miro Hrončok  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Miro Hrončok  ---
Package APPROVED.

Don't forget to mark it as dropped on http://fedora.portingdb.xyz/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #11 from Dominika Krejčí  ---
%check section changed to 'py.test-2'

Spec URL:
https://dkrejci.fedorapeople.org/python-backports-shutil_get_terminal_size/python-backports-shutil_get_terminal_size.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-backports-shutil_get_terminal_size/python-backports-shutil_get_terminal_size-1.0.0-1.fc23.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14635284

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #10 from Miro Hrončok  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= Issues =

[!]: %check is present and all tests pass.

%check does nothing:

+ /usr/bin/python2 setup.py test
running test
+ exit 0

See
https://github.com/chrippa/backports.shutil_get_terminal_size/blob/master/tox.ini

You shuld use py.test, not %{__python2} setup.py test.

Package NOT APPROVED (yet).


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be 

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #9 from Dominika Krejčí  ---
I've replaced the macro python_sitearch with python2_sitelib and now it seems
ok. I've also added the fedname macro to make it clearer.

Spec URL:
https://dkrejci.fedorapeople.org/python-backports-shutil_get_terminal_size/python-backports-shutil_get_terminal_size.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-backports-shutil_get_terminal_size/python-backports-shutil_get_terminal_size-1.0.0-1.fc23.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14634699

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #7 from Miro Hrončok  ---
The __init__ files are still there:

Transaction check error:
  file /usr/lib/python2.7/site-packages/backports/__init__.pyc conflicts
between attempted installs of
python2-backports-shutil_get_terminal_size-1.0.0-1.fc23.noarch and
python-backports-1.0-6.fc23.x86_64
  file /usr/lib/python2.7/site-packages/backports/__init__.pyo conflicts
between attempted installs of
python2-backports-shutil_get_terminal_size-1.0.0-1.fc23.noarch and
python-backports-1.0-6.fc23.x86_64

Maybe the tests pull it back in?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #8 from Miro Hrončok  ---
This in  %files will be the safest option to prevent such errors:

%{python2_sitelib}/backports/shutil_get_terminal_size

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #6 from Miro Hrončok  ---
You have to be careful now, because this is probably wrong (using %{srcname}):

%{?python_provide:%python_provide python2-%{srcname}}

I suggest you do:

%global srcname backports.shutil_get_terminal_size
%global fedname backports-shutil_get_terminal_size

And use %{fedname} where appropriate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #5 from Miro Hrončok  ---
In %files, drop:

%{python2_sitelib}/backports


And replace it with:

%{python2_sitelib}/backports/*

python-backports owns that directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #4 from Dominika Krejčí  ---
* renamed according to guidelines
* removed %{python2_sitelib}/backports/__init__.py* files

Spec URL:
https://dkrejci.fedorapeople.org/python-backports-shutil_get_terminal_size/python-backports-shutil_get_terminal_size.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-backports-shutil_get_terminal_size/python-backports-shutil_get_terminal_size-1.0.0-1.fc23.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14618055

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #3 from Miro Hrončok  ---
(In reply to Miro Hrončok from comment #2)
> See
> http://pkgs.fedoraproject.org/cgit/rpms/python-backports-lzma.git/tree/
> python-backports-lzma.spec for an example how to do all this.

Except the %files section which is not so good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #1 from Miro Hrončok  ---
When naming packages for Fedora, the maintainer must use the dash '-' as the
delimiter for name parts. The maintainer must NOT use an underscore '_', a plus
'+', or a period '.' as a delimiter. 

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997



--- Comment #2 from Miro Hrončok  ---
Also depend on python-backports and do not own the %{python2_sitelib}/backports
directory.

The files %{python2_sitelib}/backports/__init__.py* will conflict with
python-backports and should be removed.

See
http://pkgs.fedoraproject.org/cgit/rpms/python-backports-lzma.git/tree/python-backports-lzma.spec
for an example how to do all this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mhron...@redhat.com
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348997

Dominika Krejčí  changed:

   What|Removed |Added

 Blocks||1322491




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1322491
[Bug 1322491] pycolumnize: Provide a Python 3 subpackage
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org