[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380 David Tardon changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Assignee|ignate...@redhat.com|dtar...@redhat.com Last Closed||2016-09-08 09:58:29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380 --- Comment #8 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libzmf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380
--- Comment #7 from Igor Gnatenko ---
(In reply to Ralf Corsepius from comment #6)
> @Igor, all these macros do is to obscure what they actually do. This is
> featuritis and serves no technical purpose.
>
> Enforcing them is infantile bureaucracy.
will you force people to remember what is %{_make_output_sync} and all other
macro which could be added in future? Answering why we need macro for this -
EL6/EL7 GNU Make doesn't support "-O", but 4.0+ does.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380 --- Comment #6 from Ralf Corsepius --- @Igor, all these macros do is to obscure what they actually do. This is featuritis and serves no technical purpose. Enforcing them is infantile bureaucracy. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380
--- Comment #5 from Igor Gnatenko ---
#--
# Tested features of make
# Output syncronization for parallel make:
%_make_output_sync %(! %{__make} --version -O >/dev/null 2>&1 || echo -O)
#--
# The "make" analogue, hiding the _smp_mflags magic from specs
%make_build %{__make} %{_make_output_sync} %{?_smp_mflags}
Basically %make_build is not anymore same as make %{?_smp_mflags} and I will
work with FPC to enforce such macro.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380
Ralf Corsepius changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #4 from Ralf Corsepius ---
(In reply to Igor Gnatenko from comment #3)
> Looks like I completely forgot about this, sorry.
>
> > make %{?_smp_mflags}
> %make_build
>
> > make install DESTDIR=%{buildroot}
> %make_install
Igor, enforcing these macros is not helpful. They are not mandatory.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380
Igor Gnatenko changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags||fedora-review+
--- Comment #3 from Igor Gnatenko ---
Looks like I completely forgot about this, sorry.
> make %{?_smp_mflags}
%make_build
> make install DESTDIR=%{buildroot}
%make_install
* Missing BuildRequires: gcc-c++
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380 --- Comment #2 from David Tardon --- Spec URL: https://dtardon.fedorapeople.org/rpm/libzmf.spec SRPM URL: https://dtardon.fedorapeople.org/rpm/libzmf-0.0.1-1.fc24.src.rpm Copr builds: https://copr.fedorainfracloud.org/coprs/dtardon/pending-review/build/450316/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380 Igor Gnatenko changed: What|Removed |Added Alias||libzmf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats
https://bugzilla.redhat.com/show_bug.cgi?id=1349380 David Tardon changed: What|Removed |Added CC||dtar...@redhat.com --- Comment #1 from David Tardon --- Copr builds: https://copr.fedoraproject.org/coprs/dtardon/pending-review/build/361498/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
