[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #34 from Fedora Update System  ---
fmt-3.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #33 from Fedora Update System  ---
fmt-3.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #32 from Fedora Update System  ---
fmt-3.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #31 from Fedora Update System  ---
fmt-3.0.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-04 13:39:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #30 from Fedora Update System  ---
fmt-3.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-01c61f348c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #28 from Fedora Update System  ---
fmt-3.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7ef9eb36f2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #29 from Fedora Update System  ---
fmt-3.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-70fa132149

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #27 from Fedora Update System  ---
fmt-3.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f1360cf8eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #24 from Fedora Update System  ---
fmt-3.0.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-01c61f348c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #25 from Fedora Update System  ---
fmt-3.0.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7ef9eb36f2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #26 from Fedora Update System  ---
fmt-3.0.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f1360cf8eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #23 from Fedora Update System  ---
fmt-3.0.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-70fa132149

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #22 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/fmt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #21 from Antonio Trande  ---
Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 102
 files have unknown license. Detailed output of licensecheck in
 /home/sagitter/1350143-fmt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/cmake
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[?]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fmt-
 static , fmt-doc , fmt-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package 

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #20 from Dave Johansen  ---
(In reply to Antonio Trande from comment #19)
> > - Why a pre-release tag ? (0.1%{?dist})
> Is it a fmt pre-release?

I was just doing that to track the revisions of the .spec file during the
review. It's now 1.

> Can you post definitive SPEC/SRPM links?

Spec URL: https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec
SRPM URL:
https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt-3.0.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #19 from Antonio Trande  ---
> - Why a pre-release tag ? (0.1%{?dist})
Is it a fmt pre-release?

Can you post definitive SPEC/SRPM links?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #18 from Dave Johansen  ---
(In reply to Antonio Trande from comment #17)
> That of Orion is a good suggestion:
> 
> > Don't ship a -static package.  Put everything in -devel and provide 
> > fmt-static > there.
> 
> > I had problems on my local machine, but your build seemed to be fine, so 
> > I'm 
> > guessing that it's just an issue with my box and not something that should 
> > hold this up.
> 
> Scratch build on koji?

I merged in the changes/clean up from your previous scratch build and uploaded
the latest .spec file. Here's the EL7 scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15344241

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #17 from Antonio Trande  ---
That of Orion is a good suggestion:

> Don't ship a -static package.  Put everything in -devel and provide 
> fmt-static > there.

> I had problems on my local machine, but your build seemed to be fine, so I'm 
> guessing that it's just an issue with my box and not something that should 
> hold this up.

Scratch build on koji?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #16 from Dave Johansen  ---
(In reply to Antonio Trande from comment #15)
> (In reply to Dave Johansen from comment #14)
> > Is there anything we're waiting on for this? Or can we finish the review?
> 
> (In reply to Dave Johansen from comment #12)
> > (In reply to Antonio Trande from comment #11)
> > > In epel there is available the 3 version (cmake3).
> > 
> > I built with cmake3 and running into some problems there (
> > https://github.com/fmtlib/fmt/issues/370 ). Any recommendations?
> 
> Is it built on epel7?

I had problems on my local machine, but your build seemed to be fine, so I'm
guessing that it's just an issue with my box and not something that should hold
this up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #15 from Antonio Trande  ---
(In reply to Dave Johansen from comment #14)
> Is there anything we're waiting on for this? Or can we finish the review?

(In reply to Dave Johansen from comment #12)
> (In reply to Antonio Trande from comment #11)
> > In epel there is available the 3 version (cmake3).
> 
> I built with cmake3 and running into some problems there (
> https://github.com/fmtlib/fmt/issues/370 ). Any recommendations?

Is it built on epel7?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #14 from Dave Johansen  ---
Is there anything we're waiting on for this? Or can we finish the review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Antonio Trande  changed:

   What|Removed |Added

 Whiteboard|AwaitingSubmitter   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #13 from Antonio Trande  ---
I had no problem on epel7:

https://copr-be.cloud.fedoraproject.org/results/sagitter/petsc/epel-7-x86_64/00369519-fmt/

http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/petsc/fmt.git/tree/fmt.spec?id=e8f77e9969aa6664f366a173b4852ae3f298ca19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #12 from Dave Johansen  ---
(In reply to Antonio Trande from comment #11)
> In epel there is available the 3 version (cmake3).

I built with cmake3 and running into some problems there (
https://github.com/fmtlib/fmt/issues/370 ). Any recommendations?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #11 from Antonio Trande  ---
(In reply to Dave Johansen from comment #10)
> Also, cmake 2.8.12 is required but in EL 7 it's 2.8.11 in the repos. I
> submitted a bug to request that that be updated (
> https://bugzilla.redhat.com/show_bug.cgi?id=1366821 ), but I'm guessing it
> might take a while to resolve that.

In epel there is available the 3 version (cmake3).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #10 from Dave Johansen  ---
Also, cmake 2.8.12 is required but in EL 7 it's 2.8.11 in the repos. I
submitted a bug to request that that be updated (
https://bugzilla.redhat.com/show_bug.cgi?id=1366821 ), but I'm guessing it
might take a while to resolve that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #9 from Orion Poplawski  ---
Fails to build on EL7:

CMake Error: install(EXPORT "fmt-targets") given absolute DESTINATION
"/usr/share/cmake/fmt" but the export references an installation of target
"fmt" which has relative DESTINATION "lib64".

Don't ship a -static package.  Put everything in -devel and provide fmt-static
there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #8 from Dave Johansen  ---
(In reply to Antonio Trande from comment #7)
> > > > The updated .spec file with the fixes is at:
> > > > https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec
> > > 
> > > Please, include these header files
> > > 
> > > %exclude %{_includedir}/fmt/ostream.h
> > > %exclude %{_includedir}/fmt/posix.h
> > > %exclude %{_includedir}/fmt/time.h
> > >
> > > I need them for packaging other software.
> 
> > Are these useful without the .cc files?
> 
> I don't know.
> 
> > My initial thought would be that if I'm going to package the "header only" 
> > files that it should be in a separate package.
> 
> Okay.

I'm pretty sure that they're not, so I made a fmt-static package to package all
of the header only files. I posted on the packaging mailing list to make sure
that this is the right way to handle this (
https://lists.fedoraproject.org/archives/list/packag...@lists.fedoraproject.org/message/SD7SZFA5EOWFXAYJ2WPBDEI5BOTXN4N6/
).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #7 from Antonio Trande  ---
> > > The updated .spec file with the fixes is at:
> > > https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec
> > 
> > Please, include these header files
> > 
> > %exclude %{_includedir}/fmt/ostream.h
> > %exclude %{_includedir}/fmt/posix.h
> > %exclude %{_includedir}/fmt/time.h
> >
> > I need them for packaging other software.

> Are these useful without the .cc files?

I don't know.

> My initial thought would be that if I'm going to package the "header only" 
> files that it should be in a separate package.

Okay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #6 from Dave Johansen  ---
(In reply to Antonio Trande from comment #5)
> Hi Dave.
> 
> (In reply to Dave Johansen from comment #4)
> > Sorry for the delay. We moved and I haven't had time to work on this sort of
> > thing.
> > 
> 
> > > [!]: Patches link to upstream bugs/comments/lists or are otherwise
> > >  justified.
> >
> > Fixed.
> 
> I dont see any comment.

Sorry, the file wasn't uploaded before but it's there now.

> > > Generic:
> > > [!]: Avoid bundling fonts in non-fonts packages.
> > >  Note: Package contains font files
> > 
> > This came up during the original review of cppformat and the general
> > consensus was that it wasn't an issue:
> > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/
> > message/EKVX5GCQUFINUYBRGFD2JQHF2UXUBBVV/
> 
> There is a similar issue in this review:
> https://bugzilla.redhat.com/show_bug.cgi?id=1362265#c16

I'm using the pre-built documentation because it can't be built in Fedora right
now, so unfortunately I can't do that sort of fix.

> > > fmt.x86_64: W: tag-in-description C Provides:
> > > fmt.x86_64: W: tag-in-description C Obsoletes:
> > 
> > Is there something wrong with my Provides/Obsoletes?
> 
> Are under %description section; move them after the BuildRequires: line. 

Fixed.

> > The updated .spec file with the fixes is at:
> > https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec
> 
> Please, include these header files
> 
> %exclude %{_includedir}/fmt/ostream.h
> %exclude %{_includedir}/fmt/posix.h
> %exclude %{_includedir}/fmt/time.h
> 
> I need them for packaging other software.

Are these useful without the .cc files? My initial thought would be that if I'm
going to package the "header only" files that it should be in a separate
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #5 from Antonio Trande  ---
Hi Dave.

(In reply to Dave Johansen from comment #4)
> Sorry for the delay. We moved and I haven't had time to work on this sort of
> thing.
> 

> > [!]: Patches link to upstream bugs/comments/lists or are otherwise
> >  justified.
>
> Fixed.

I dont see any comment.

> 
> 
> > Generic:
> > [!]: Avoid bundling fonts in non-fonts packages.
> >  Note: Package contains font files
> 
> This came up during the original review of cppformat and the general
> consensus was that it wasn't an issue:
> https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/
> message/EKVX5GCQUFINUYBRGFD2JQHF2UXUBBVV/

There is a similar issue in this review:
https://bugzilla.redhat.com/show_bug.cgi?id=1362265#c16

> 
> > fmt.x86_64: W: tag-in-description C Provides:
> > fmt.x86_64: W: tag-in-description C Obsoletes:
> 
> Is there something wrong with my Provides/Obsoletes?

Are under %description section; move them after the BuildRequires: line. 

> 
> > fmt-devel.x86_64: W: only-non-binary-in-usr-lib
> 
> I don't understand what this is warning about.

It's a false positive.

> 
> The updated .spec file with the fixes is at:
> https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec

Please, include these header files

%exclude %{_includedir}/fmt/ostream.h
%exclude %{_includedir}/fmt/posix.h
%exclude %{_includedir}/fmt/time.h

I need them for packaging other software.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Dave Johansen  changed:

   What|Removed |Added

  Flags|needinfo?(davejohansen@gmai |
   |l.com)  |



--- Comment #4 from Dave Johansen  ---
Sorry for the delay. We moved and I haven't had time to work on this sort of
thing.

(In reply to Antonio Trande from comment #2)
> [!]: Package requires other packages for directories it uses.
>  Note: No known owner of /usr/share/cmake/fmt, /usr/include/fmt
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/cmake,
>  /usr/share/cmake/fmt, /usr/include/fmt

Fixed.

> [-]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.

This is actually a rename of cppformat but I believe that these are correct.

> Generic:
> [!]: Avoid bundling fonts in non-fonts packages.
>  Note: Package contains font files

This came up during the original review of cppformat and the general consensus
was that it wasn't an issue:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/EKVX5GCQUFINUYBRGFD2JQHF2UXUBBVV/

> [!]: Patches link to upstream bugs/comments/lists or are otherwise
>  justified.

Fixed.

> fmt.x86_64: W: tag-in-description C Provides:
> fmt.x86_64: W: tag-in-description C Obsoletes:

Is there something wrong with my Provides/Obsoletes?

> fmt.x86_64: W: incoherent-version-in-changelog 3.0.0-1 ['3.0.0-0.1.fc25',
> '3.0.0-0.1']

Fixed.

> fmt-devel.x86_64: W: only-non-binary-in-usr-lib

I don't understand what this is warning about.

The updated .spec file with the fixes is at:
https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Antonio Trande  changed:

   What|Removed |Added

 Whiteboard||AwaitingSubmitter



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Antonio Trande  changed:

   What|Removed |Added

 CC||davejohan...@gmail.com
  Flags||needinfo?(davejohansen@gmai
   ||l.com)



--- Comment #3 from Antonio Trande  ---
Can we go on? :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #2 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Package does not own /usr/share/cmake/fmt /usr/include/fmt

- Please, unbundle font in usr/share/doc/fmt-doc/html/_static/fonts

- Why a pre-release tag ? (0.1%{?dist})

- Please, leave comments about the patches.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 102
 files have unknown license. Detailed output of licensecheck in
 /home/sagitter/1350143-fmt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/cmake/fmt, /usr/include/fmt
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/cmake,
 /usr/share/cmake/fmt, /usr/include/fmt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fmt-doc
 

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
 Blocks||1334067
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1334067
[Bug 1334067] cppformat-3.0.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #1 from Dave Johansen  ---
Sorry, I meant bugzilla #1334067.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org