[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-07-18 14:28:24



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097



--- Comment #8 from Fedora Update System  ---
python-github3py-1.0.0-0.1a4.fc24, python-uritemplate-0.3.0-1.fc24 has been
pushed to the Fedora 24 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-github3py-1.0.0-0.1a4.fc24, python-uritemplate-0.3.0-1.fc24 has been
pushed to the Fedora 24 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d42fa6a33d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-uritemplate

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from William Moreno  ---
Looks Good for me, package aproved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097



--- Comment #3 from Igor Gnatenko  ---
Added conflicts.

Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-uritemplate.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-uritemplate-0.3.0-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097



--- Comment #2 from Igor Gnatenko  ---
I think if I will add Conflicts with that package it should be fine.. what do
you think? I don't want to rename sources as it will break other packages which
will be probably using this library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097



--- Comment #1 from William Moreno  ---
Package Review
==

Package looks good, there is only a directory ownership issue to fix.

[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.5/site-
 packages/uritemplate/__pycache__(python3-uri-templates),
 /usr/lib/python2.7/site-packages/uritemplate(python2-uri-templates),
 /usr/lib/python3.5/site-packages/uritemplate(python3-uri-templates)

= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. 
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =
Generic:
[x]: %check is present and all tests pass.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
 Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
---
Checking: python2-uritemplate-0.3.0-1.fc24.noarch.rpm
  python3-uritemplate-0.3.0-1.fc24.noarch.rpm
  python-uritemplate-0.3.0-1.fc24.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Requires

python3-uritemplate (rpmlib, GLIBC filtered):
python(abi)

python2-uritemplate (rpmlib, GLIBC 

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1351138




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1351138
[Bug 1351138] Review Request: python-github3py - Python wrapper for the
GitHub API
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||python-uritemplate



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org