[Bug 1352091] Review Request: enunciate - Build-time enhancement tool for Java-based Web services projects

2016-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1352091

Ding-Yi Chen  changed:

   What|Removed |Added

Summary|Review Request: |Review Request: enunciate -
   |enunciate-core-rt - |Build-time enhancement tool
   |Enunciate core classes that |for Java-based Web services
   |are needed at runtime   |projects



--- Comment #5 from Ding-Yi Chen  ---
The main package changed to enunciate, it provides following sub packages:
  javadoc
  core-rt
  jersey-rt

 otherwise the spec has updated according to comment #2 and #3


Spec URL: https://dchen.fedorapeople.org/files/rpms/enunciate.spec
SRPM URL:
https://dchen.fedorapeople.org/files/rpms/enunciate-1.31-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1352091] Review Request: enunciate - Build-time enhancement tool for Java-based Web services projects

2016-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1352091

gil cattaneo  changed:

   What|Removed |Added

  Flags|needinfo?(puntogil@libero.i |
   |t)  |



--- Comment #6 from gil cattaneo  ---
(In reply to Ding-Yi Chen from comment #4)
> Thanks gil,
> 
> Come to think of it, since I also need enunciate-core and
> enunciate-jersey-rt, should I make the enunciate as main package instead,
> and provide enunciate-core-rt, enunciate-core, enunciate-jeresy-rt as
> sub-packages?

yes, is ok for me. but is available a new version:
https://github.com/stoicflame/enunciate/releases/tag/v2.5.0
you should add a comment, in the spec file, as to why you want to import this
old version

maybe you could remove:
%mvn_package ":enunciate-parent" enunciate
and change or remove the main package in

%files -f .mfiles-%{name}-parent
%license license.txt notice.txt



%files core-rt -f .mfiles-%{name}-core-rt
%doc README.md
%license license.txt notice.txt

or

%files parent -f .mfiles-%{name}-parent
%license license.txt notice.txt

...

i dont understand this:

# remove enunciate-core-annotations, because it is in other package 
rm -f %{buildroot}/%{_javadir}/enunciate/enunciate-core-annotations.jar
rm -f
%{buildroot}/%{_datadir}/maven-metadata/enunciate-enunciate-core-annotations.xml
rm -f
%{buildroot}/%{_datadir}/maven-poms/enunciate/enunciate-core-annotations.pom

you should disable this module, and use the other package

and for last you should add missing build-requires:
mvn(com.sun.jersey:jersey-server:1)
mvn(com.sun.jersey:jersey-servlet:1)
mvn(com.sun.jersey.contribs:jersey-spring:1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1352091] Review Request: enunciate - Build-time enhancement tool for Java-based Web services projects

2016-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1352091



--- Comment #7 from gil cattaneo  ---
Other question, You asked to enunciate-core-annotations package maintainer to
import the missing modules and / or upgrade the package?

https://apps.fedoraproject.org/packages/enunciate-core-annotations

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1352091] Review Request: enunciate - Build-time enhancement tool for Java-based Web services projects

2016-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1352091

Ding-Yi Chen  changed:

   What|Removed |Added

  Flags||needinfo?(puntogil@libero.i
   ||t)



--- Comment #8 from Ding-Yi Chen  ---
(In reply to gil cattaneo from comment #7)
> Other question, You asked to enunciate-core-annotations package maintainer
> to import the missing modules and / or upgrade the package?
> 
> https://apps.fedoraproject.org/packages/enunciate-core-annotations

Should enunciate-core-annotations agree to merge his package with this package,
what is the procedure? 
Should the enunciate-core-annotations be retired or something else need to be
done?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1352091] Review Request: enunciate - Build-time enhancement tool for Java-based Web services projects

2016-07-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1352091

Ding-Yi Chen  changed:

   What|Removed |Added

 CC||pahu...@redhat.com



--- Comment #9 from Ding-Yi Chen  ---
gil,

 The reasons I do not use the 2.X version are:
   # https://github.com/stoicflame/enunciate/issues/117
   # https://bugs.openjdk.java.net/browse/JDK-8143213

Patrick,
  Is it possible for me to merge enunciate-core-annotations into this package?


The spec has updated according to comment #6 and #7

Spec URL: https://dchen.fedorapeople.org/files/rpms/enunciate.spec
SRPM URL:
https://dchen.fedorapeople.org/files/rpms/enunciate-1.31-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1352091] Review Request: enunciate - Build-time enhancement tool for Java-based Web services projects

2016-07-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1352091

gil cattaneo  changed:

   What|Removed |Added

  Flags|needinfo?(puntogil@libero.i |
   |t)  |



--- Comment #10 from gil cattaneo  ---
(In reply to Ding-Yi Chen from comment #9)
> gil,
> 
>  The reasons I do not use the 2.X version are:
># https://github.com/stoicflame/enunciate/issues/117
># https://bugs.openjdk.java.net/browse/JDK-8143213
for me is ok this release until upstream bug#117 is not fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1352091] Review Request: enunciate - Build-time enhancement tool for Java-based Web services projects

2016-07-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1352091



--- Comment #11 from gil cattaneo  ---
(In reply to Ding-Yi Chen from comment #8)
> (In reply to gil cattaneo from comment #7)
> > Other question, You asked to enunciate-core-annotations package maintainer
> > to import the missing modules and / or upgrade the package?
> > 
> > https://apps.fedoraproject.org/packages/enunciate-core-annotations
> 
> Should enunciate-core-annotations agree to merge his package with this
> package, what is the procedure? 
> Should the enunciate-core-annotations be retired or something else need to
> be done?

maybe this is the better way for more infos see
https://fedoraproject.org/wiki/Package_Renaming_Process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org