[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 Robert-André Mauchin changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(kyle.harms@gmail. | |com)| Last Closed||2019-08-10 21:58:22 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Flags||needinfo?(kyle.harms@gmail.
||com)
--- Comment #8 from Robert-André Mauchin ---
(In reply to Kyle J. Harms from comment #4)
> Thanks for the review. I think I have addressed everything.
>
> Spec URL:
> http://copr-dist-git.fedorainfracloud.org/cgit/harmsk/sparkleshare/soup-
> sharp.git/plain/soup-sharp.spec
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/harmsk/sparkleshare/fedora-
> rawhide-x86_64/00389463-soup-sharp/soup-sharp-2.42.2-4.fc25.src.rpm
> Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14928668
Bumpity-bump, I need soup-sharp packaged too. Are you willing to continue with
it? I can comaintain and sponsor you?
- Drop:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
It is not not needed anymore
Maybe package the latest GIT master as it contains minor fixes to the pkgconfig
- Remove:
Group: Development/Libraries
It is not needed in Fedora.
- Use:
Source0:
https://github.com/stsundermann/%{name}/archive/%{version}/%{name}-%{version}.tar.gz
As I said I can sponsor and comaintain, if you're still interested in Fedora.
If no answer within one week, I'll close the bug and package on my own.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 --- Comment #7 from Dusty Mabe --- Hey Igor, It looked like you were doing the review and Kyle was trying to address your comments so I thought he was waiting on feedback from you to finish the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 Igor Gnatenko changed: What|Removed |Added Flags|needinfo?(ignatenko@redhat. | |com)| --- Comment #6 from Igor Gnatenko --- Dusty, why did you set needinfo? I just commented this request to provide my opinion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 Dusty Mabe changed: What|Removed |Added CC||dustym...@redhat.com Flags||needinfo?(ignatenko@redhat. ||com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 --- Comment #5 from Raphael Groner --- You should consider joining the mono SIG. Are you interested in doing more reviews for mono packages? https://fedoraproject.org/wiki/SIGs/Mono -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 --- Comment #4 from Kyle J. Harms --- Thanks for the review. I think I have addressed everything. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/harmsk/sparkleshare/soup-sharp.git/plain/soup-sharp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/harmsk/sparkleshare/fedora-rawhide-x86_64/00389463-soup-sharp/soup-sharp-2.42.2-4.fc25.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14928668 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714
--- Comment #3 from Igor Gnatenko ---
> Requires: %{name} = %{version}-%{release}
missing %{?_isa}
> Requires: pkgconfig
not needed
> %setup -q
> %autosetup
only one should be choosen
> make
not %{_smp_mflags}, better to use %make_build
> make DESTDIR=%{buildroot} install
can be %make_install
> %{_libdir}/libsoupsharpglue-2.42.2.so
2.42.2 -> %{version}
> %{_libdir}/libsoupsharpglue*.la
libtool files should not be packaged
> %{_libdir}/libsoupsharpglue*.a
static libraries should not be packaged or can be packaged to special -static
subpkg (but I don't recommend to do this)
> Source0:
> https://github.com/stsundermann/%{name}/archive/%{version}.zip#/%{name}-%{version}.tar.gz
.zip -> .tar.gz
something wrong here. also you canuse %{url} instead of https://github.com
until /archive
so, not ready ;)
* Missing BuildRequires for compiler..
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 --- Comment #2 from Raphael Groner --- Review swap with bug #1279093? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Review swap with bug #1321473? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 Nikos Roussos changed: What|Removed |Added CC||comzer...@fedoraproject.org Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
