[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 gil cattaneo changed: What|Removed |Added Status|NEW |CLOSED Fixed In Version||apfloat-java-1.8.2-1.fc26 Resolution|--- |RAWHIDE Last Closed||2016-11-14 13:13:53 --- Comment #11 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16451116 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 --- Comment #10 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/apfloat-java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 --- Comment #9 from Jonny Heggheim --- (In reply to gil cattaneo from comment #8) > If necessary, I will remove them before import According to http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries It is fine removing it in %prep, but you need to ask upstream to remove the binaries in their next release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 --- Comment #8 from gil cattaneo --- (In reply to Jonny Heggheim from comment #7) > Review approved, please ignore the bug in fedora-review. > > I noticed uou used rm -r when deleting .java files, not sure if it > intentional or copy/paste. If necessary, I will remove them before import Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/8666 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 Jonny Heggheim changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Flags|fedora-review? |fedora-review+ --- Comment #7 from Jonny Heggheim --- Review approved, please ignore the bug in fedora-review. I noticed uou used rm -r when deleting .java files, not sure if it intentional or copy/paste. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615
--- Comment #6 from Jonny Heggheim ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
built_JAR_files_.2F_Other_bundled_software'
I investigated this check, but I could not find any .jar og .class files in
BUILD after running rpmbuild -bp. This is a bug in fedora-review.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2.1 or later)", "Unknown or generated". 529 files have
unknown license.
Packager have asked upstream for clarifications.
[x]: License file installed when any subpackage combination is installed.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 --- Comment #5 from Jonny Heggheim --- (In reply to gil cattaneo from comment #3) > (In reply to Jonny Heggheim from comment #2) > > I will review this today/tomorrow. Can you look at bug 1187084? > > Can you take this bug instead bug 1276632? I am half done with this, I will look at bug 1276632 when this have been reviewed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 gil cattaneo changed: What|Removed |Added Attachment|0 |1 #1177358 is|| obsolete|| --- Comment #4 from gil cattaneo --- Created attachment 1220173 --> https://bugzilla.redhat.com/attachment.cgi?id=1220173&action=edit Source files without license headers - e-mail -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 --- Comment #3 from gil cattaneo --- (In reply to Jonny Heggheim from comment #2) > I will review this today/tomorrow. Can you look at bug 1187084? Can you take this bug instead bug 1276632? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 --- Comment #2 from Jonny Heggheim --- I will review this today/tomorrow. Can you look at bug 1187084? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1353615 Jonny Heggheim changed: What|Removed |Added CC||jonnyheggh...@sigaint.org Assignee|nob...@fedoraproject.org|jonnyheggh...@sigaint.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
